Kernel KVM virtualization development
 help / color / mirror / Atom feed
From: Andrew Jones <drjones@redhat.com>
To: kvm@vger.kernel.org
Cc: pbonzini@redhat.com, mst@redhat.com, agordeev@redhat.com,
	rkrcmar@redhat.com
Subject: [kvm-unit-tests PATCH 06/11] x86: move x86/pci to the common lib
Date: Fri, 15 Jan 2016 17:10:11 +0100	[thread overview]
Message-ID: <1452874216-3087-7-git-send-email-drjones@redhat.com> (raw)
In-Reply-To: <1452874216-3087-1-git-send-email-drjones@redhat.com>

Signed-off-by: Andrew Jones <drjones@redhat.com>
---
 config/config-x86-common.mak |  2 +-
 lib/{x86 => }/pci.c          |  6 ++++++
 lib/pci.h                    | 22 ++++++++++++++++++++++
 lib/x86/asm/pci.h            | 14 +++-----------
 x86/vmexit.c                 |  2 +-
 5 files changed, 33 insertions(+), 13 deletions(-)
 rename lib/{x86 => }/pci.c (86%)
 create mode 100644 lib/pci.h

diff --git a/config/config-x86-common.mak b/config/config-x86-common.mak
index 4a2746826784c..860cbb0a7db4d 100644
--- a/config/config-x86-common.mak
+++ b/config/config-x86-common.mak
@@ -10,8 +10,8 @@ cflatobjs += lib/x86/apic.o
 cflatobjs += lib/x86/atomic.o
 cflatobjs += lib/x86/desc.o
 cflatobjs += lib/x86/isr.o
-cflatobjs += lib/x86/pci.o
 cflatobjs += lib/x86/acpi.o
+cflatobjs += lib/pci.o
 
 $(libcflat): LDFLAGS += -nostdlib
 $(libcflat): CFLAGS += -ffreestanding -I lib
diff --git a/lib/x86/pci.c b/lib/pci.c
similarity index 86%
rename from lib/x86/pci.c
rename to lib/pci.c
index 7002d80836a4c..0058d70c888d8 100644
--- a/lib/x86/pci.c
+++ b/lib/pci.c
@@ -1,4 +1,10 @@
+/*
+ * Copyright (C) 2013, Red Hat Inc, Michael S. Tsirkin <mst@redhat.com>
+ *
+ * This work is licensed under the terms of the GNU LGPL, version 2.
+ */
 #include <linux/pci_regs.h>
+#include "pci.h"
 #include "asm/pci.h"
 
 /* Scan bus look for a specific device. Only bus 0 scanned for now. */
diff --git a/lib/pci.h b/lib/pci.h
new file mode 100644
index 0000000000000..65fcd9444461c
--- /dev/null
+++ b/lib/pci.h
@@ -0,0 +1,22 @@
+#ifndef PCI_H
+#define PCI_H
+/*
+ * API for scanning a PCI bus for a given device, as well to access
+ * BAR registers.
+ *
+ * Copyright (C) 2013, Red Hat Inc, Michael S. Tsirkin <mst@redhat.com>
+ *
+ * This work is licensed under the terms of the GNU LGPL, version 2.
+ */
+#include "libcflat.h"
+
+typedef uint16_t pcidevaddr_t;
+enum {
+    PCIDEVADDR_INVALID = 0x0
+};
+pcidevaddr_t pci_find_dev(uint16_t vendor_id, uint16_t device_id);
+unsigned long pci_bar_addr(pcidevaddr_t dev, int bar_num);
+bool pci_bar_is_memory(pcidevaddr_t dev, int bar_num);
+bool pci_bar_is_valid(pcidevaddr_t dev, int bar_num);
+
+#endif
diff --git a/lib/x86/asm/pci.h b/lib/x86/asm/pci.h
index 8ad93a87966c6..f7028defb63b2 100644
--- a/lib/x86/asm/pci.h
+++ b/lib/x86/asm/pci.h
@@ -1,18 +1,10 @@
-#ifndef PCI_H
-#define PCI_H
+#ifndef ASM_PCI_H
+#define ASM_PCI_H
 
 #include "libcflat.h"
+#include "pci.h"
 #include "asm/io.h"
 
-typedef uint16_t pcidevaddr_t;
-enum {
-    PCIDEVADDR_INVALID = 0x0
-};
-pcidevaddr_t pci_find_dev(uint16_t vendor_id, uint16_t device_id);
-unsigned long pci_bar_addr(pcidevaddr_t dev, int bar_num);
-bool pci_bar_is_memory(pcidevaddr_t dev, int bar_num);
-bool pci_bar_is_valid(pcidevaddr_t dev, int bar_num);
-
 static inline uint32_t pci_config_read(pcidevaddr_t dev, uint8_t reg)
 {
     uint32_t index = reg | (dev << 8) | (0x1 << 31);
diff --git a/x86/vmexit.c b/x86/vmexit.c
index 61243a9d63c9a..35c6fac747588 100644
--- a/x86/vmexit.c
+++ b/x86/vmexit.c
@@ -2,9 +2,9 @@
 #include "smp.h"
 #include "processor.h"
 #include "atomic.h"
+#include "pci.h"
 #include "x86/vm.h"
 #include "x86/desc.h"
-#include "asm/pci.h"
 #include "x86/acpi.h"
 #include "asm/io.h"
 
-- 
2.4.3


  parent reply	other threads:[~2016-01-15 16:10 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-15 16:10 [kvm-unit-tests PATCH 00/11] share pci-testdev with the framework Andrew Jones
2016-01-15 16:10 ` [kvm-unit-tests PATCH 01/11] asm-generic: add portio accessors to io.h Andrew Jones
2016-01-15 16:10 ` [kvm-unit-tests PATCH 02/11] x86: move io.h to asm Andrew Jones
2016-01-15 16:10 ` [kvm-unit-tests PATCH 03/11] x86: use common portio accessors from io.h Andrew Jones
2016-01-15 16:10 ` [kvm-unit-tests PATCH 04/11] x86: pci.h: remove useless include Andrew Jones
2016-01-15 16:10 ` [kvm-unit-tests PATCH 05/11] x86: mov pci.h to asm Andrew Jones
2016-01-15 16:10 ` Andrew Jones [this message]
2016-01-15 16:27   ` [kvm-unit-tests PATCH 06/11] x86: move x86/pci to the common lib Andrew Jones
2016-01-15 16:10 ` [kvm-unit-tests PATCH 07/11] x86: share pci-testdev hdr in " Andrew Jones
2016-01-15 16:10 ` [kvm-unit-tests PATCH 08/11] lib/pci: make PCIDEVADDR_INVALID truly invalid Andrew Jones
2016-01-15 16:10 ` [kvm-unit-tests PATCH 09/11] lib: add linux dir for kernel uapi headers Andrew Jones
2016-01-15 16:10 ` [kvm-unit-tests PATCH 10/11] Revert "arm/arm64: import include/uapi/linux/psci.h" Andrew Jones
2016-01-15 16:10 ` [kvm-unit-tests PATCH 11/11] lib/linux: import pci_regs.h Andrew Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1452874216-3087-7-git-send-email-drjones@redhat.com \
    --to=drjones@redhat.com \
    --cc=agordeev@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=rkrcmar@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox