[kvm:master 5/5] arch/x86//kvm/mmu.c:3725:2: note: in expansion of macro 'if'

[kvm:master 5/5] arch/x86//kvm/mmu.c:3725:2: note: in expansion of macro 'if'

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 3833 bytes --]

tree:   https://git.kernel.org/pub/scm/virt/kvm/kvm.git master
head:   0f77e26d68b2d6cad536d27707fc4b4955b3048b
commit: 0f77e26d68b2d6cad536d27707fc4b4955b3048b [5/5] KVM: async_pf: avoid async pf injection when in guest mode
config: i386-randconfig-x012-201723 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        git checkout 0f77e26d68b2d6cad536d27707fc4b4955b3048b
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

   In file included from include/uapi/linux/stddef.h:1:0,
                    from include/linux/stddef.h:4,
                    from include/uapi/linux/posix_types.h:4,
                    from include/uapi/linux/types.h:13,
                    from include/linux/types.h:5,
                    from include/linux/mm_types_task.h:10,
                    from include/linux/mm_types.h:4,
                    from arch/x86//kvm/irq.h:25,
                    from arch/x86//kvm/mmu.c:21:
   arch/x86//kvm/mmu.c: In function 'try_async_pf':
   arch/x86//kvm/mmu.c:3725:19: error: implicit declaration of function 'can_do_async_pf' [-Werror=implicit-function-declaration]
     if (!prefault && can_do_async_pf(vcpu)) {
                      ^
   include/linux/compiler.h:160:30: note: in definition of macro '__trace_if'
     if (__builtin_constant_p(!!(cond)) ? !!(cond) :   \
                                 ^~~~
>> arch/x86//kvm/mmu.c:3725:2: note: in expansion of macro 'if'
     if (!prefault && can_do_async_pf(vcpu)) {
     ^~
   cc1: some warnings being treated as errors

vim +/if +3725 arch/x86//kvm/mmu.c

0f77e26d Wanpeng Li     2017-06-08  3709  
af585b92 Gleb Natapov   2010-10-14  3710  	return kvm_x86_ops->interrupt_allowed(vcpu);
af585b92 Gleb Natapov   2010-10-14  3711  }
af585b92 Gleb Natapov   2010-10-14  3712  
78b2c54a Xiao Guangrong 2010-12-07  3713  static bool try_async_pf(struct kvm_vcpu *vcpu, bool prefault, gfn_t gfn,
ba049e93 Dan Williams   2016-01-15  3714  			 gva_t gva, kvm_pfn_t *pfn, bool write, bool *writable)
af585b92 Gleb Natapov   2010-10-14  3715  {
3520469d Paolo Bonzini  2015-04-02  3716  	struct kvm_memory_slot *slot;
af585b92 Gleb Natapov   2010-10-14  3717  	bool async;
af585b92 Gleb Natapov   2010-10-14  3718  
54bf36aa Paolo Bonzini  2015-04-08  3719  	slot = kvm_vcpu_gfn_to_memslot(vcpu, gfn);
3520469d Paolo Bonzini  2015-04-02  3720  	async = false;
3520469d Paolo Bonzini  2015-04-02  3721  	*pfn = __gfn_to_pfn_memslot(slot, gfn, false, &async, write, writable);
af585b92 Gleb Natapov   2010-10-14  3722  	if (!async)
af585b92 Gleb Natapov   2010-10-14  3723  		return false; /* *pfn has correct page already */
af585b92 Gleb Natapov   2010-10-14  3724  
78b2c54a Xiao Guangrong 2010-12-07 @3725  	if (!prefault && can_do_async_pf(vcpu)) {
c9b263d2 Xiao Guangrong 2010-11-01  3726  		trace_kvm_try_async_get_page(gva, gfn);
af585b92 Gleb Natapov   2010-10-14  3727  		if (kvm_find_async_pf_gfn(vcpu, gfn)) {
af585b92 Gleb Natapov   2010-10-14  3728  			trace_kvm_async_pf_doublefault(gva, gfn);
af585b92 Gleb Natapov   2010-10-14  3729  			kvm_make_request(KVM_REQ_APF_HALT, vcpu);
af585b92 Gleb Natapov   2010-10-14  3730  			return true;
af585b92 Gleb Natapov   2010-10-14  3731  		} else if (kvm_arch_setup_async_pf(vcpu, gva, gfn))
af585b92 Gleb Natapov   2010-10-14  3732  			return true;
af585b92 Gleb Natapov   2010-10-14  3733  	}

:::::: The code at line 3725 was first introduced by commit
:::::: 78b2c54aa4a7e9e4257d2b8e3a4b96d2d0c6e636 KVM: MMU: rename 'no_apf' to 'prefault'

:::::: TO: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
:::::: CC: Avi Kivity <avi@redhat.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 29534 bytes --]

Re: [kvm:master 5/5] arch/x86//kvm/mmu.c:3725:2: note: in expansion of macro 'if'

[Wanpeng Li]

2017-06-10 4:19 GMT+08:00 kbuild test robot <fengguang.wu@intel.com>:
> tree:   https://git.kernel.org/pub/scm/virt/kvm/kvm.git master
> head:   0f77e26d68b2d6cad536d27707fc4b4955b3048b
> commit: 0f77e26d68b2d6cad536d27707fc4b4955b3048b [5/5] KVM: async_pf: avoid async pf injection when in guest mode
> config: i386-randconfig-x012-201723 (attached as .config)
> compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
> reproduce:
>         git checkout 0f77e26d68b2d6cad536d27707fc4b4955b3048b
>         # save the attached .config to linux build tree
>         make ARCH=i386
>
> All warnings (new ones prefixed by >>):
>
>    In file included from include/uapi/linux/stddef.h:1:0,
>                     from include/linux/stddef.h:4,
>                     from include/uapi/linux/posix_types.h:4,
>                     from include/uapi/linux/types.h:13,
>                     from include/linux/types.h:5,
>                     from include/linux/mm_types_task.h:10,
>                     from include/linux/mm_types.h:4,
>                     from arch/x86//kvm/irq.h:25,
>                     from arch/x86//kvm/mmu.c:21:
>    arch/x86//kvm/mmu.c: In function 'try_async_pf':
>    arch/x86//kvm/mmu.c:3725:19: error: implicit declaration of function 'can_do_async_pf' [-Werror=implicit-function-declaration]
>      if (!prefault && can_do_async_pf(vcpu)) {

I believe the maintainer modified the patch slightly before applying,
do you mind to also replace can_do_async_pf() by kvm_can_do_async_pf()
in the function try_async_pf(), Paolo?

Regards,
Wanpeng Li

Re: [kvm:master 5/5] arch/x86//kvm/mmu.c:3725:2: note: in expansion of macro 'if'

[Paolo Bonzini]

> I believe the maintainer modified the patch slightly before applying,
> do you mind to also replace can_do_async_pf() by kvm_can_do_async_pf()
> in the function try_async_pf(), Paolo?

Yes, I had the change locally but forgot to commit.  Sorry.

Paolo

Re: [kvm:master 5/5] arch/x86//kvm/mmu.c:3725:2: note: in expansion of macro 'if'

[Wanpeng Li]

2017-06-11 14:38 GMT+08:00 Paolo Bonzini <pbonzini@redhat.com>:
>
>> I believe the maintainer modified the patch slightly before applying,
>> do you mind to also replace can_do_async_pf() by kvm_can_do_async_pf()
>> in the function try_async_pf(), Paolo?
>
> Yes, I had the change locally but forgot to commit.  Sorry.

Never mind, the help from you are always grateful for.

Regards,
Wanpeng Li