From: "Yang, Shunyong" <shunyong.yang@hxt-semitech.com>
To: "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
"kwankhede@nvidia.com" <kwankhede@nvidia.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"Zheng, Joey" <yu.zheng@hxt-semitech.com>
Subject: Re: [PATCH] vfio-mdev/samples: change RDI interrupt condition
Date: Tue, 20 Mar 2018 07:53:02 +0000 [thread overview]
Message-ID: <1521532382.3326.5.camel@hxt-semitech.com> (raw)
In-Reply-To: <c14684a6-9388-e38a-c99a-a393c5bcf2a4@nvidia.com>
Hi, Alex,
Gentle ping. Could you please help to pull this patch?
It's a small fix and Kirti has reviewed.
Thanks.
Shunyong.
On Fri, 2018-03-09 at 11:36 +0530, Kirti Wankhede wrote:
> Thanks for fixing it.
> Patch looks good to me.
> +Alex to pull this patch.
>
> Reviewed by: Kirti Wankhede <kwankhede@nvidia.com>
>
> Thanks,
> Kirti
>
> On 3/8/2018 12:38 PM, Shunyong Yang wrote:
> >
> > When FIFO mode is enabled, the receive data available interrupt
> > (UART_IIR_RDI in code) should be triggered when the number of data
> > in FIFO is equal or larger than interrupt trigger level.
> >
> > This patch changes the trigger level check to ensure multiple bytes
> > received from upper layer can trigger RDI interrupt correctly.
> >
> > Cc: Joey Zheng <yu.zheng@hxt-semitech.com>
> > Signed-off-by: Shunyong Yang <shunyong.yang@hxt-semitech.com>
> > ---
> > samples/vfio-mdev/mtty.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/samples/vfio-mdev/mtty.c b/samples/vfio-mdev/mtty.c
> > index 09f255bdf3ac..7abb79d8313d 100644
> > --- a/samples/vfio-mdev/mtty.c
> > +++ b/samples/vfio-mdev/mtty.c
> > @@ -534,7 +534,7 @@ static void handle_bar_read(unsigned int index,
> > struct mdev_state *mdev_state,
> >
> > /* Interrupt priority 2: Fifo trigger level
> > reached */
> > if ((ier & UART_IER_RDI) &&
> > - (mdev_state->s[index].rxtx.count ==
> > + (mdev_state->s[index].rxtx.count >=
> > mdev_state->s[index].intr_trigger_level))
> > *buf |= UART_IIR_RDI;
> >
> >
next prev parent reply other threads:[~2018-03-20 7:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-08 7:08 [PATCH] vfio-mdev/samples: change RDI interrupt condition Shunyong Yang
2018-03-09 6:06 ` Kirti Wankhede
2018-03-20 7:53 ` Yang, Shunyong [this message]
2018-03-22 21:48 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1521532382.3326.5.camel@hxt-semitech.com \
--to=shunyong.yang@hxt-semitech.com \
--cc=alex.williamson@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yu.zheng@hxt-semitech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox