* [PATCH -next] KVM: use vma_pages() helper
@ 2021-09-29 7:28 Yang Li
2021-09-29 12:56 ` Paolo Bonzini
0 siblings, 1 reply; 2+ messages in thread
From: Yang Li @ 2021-09-29 7:28 UTC (permalink / raw)
To: pbonzini; +Cc: kvm, linux-kernel, Yang Li
Use vma_pages function on vma object instead of explicit computation.
Fix the following coccicheck warning:
./virt/kvm/kvm_main.c:3526:29-35: WARNING: Consider using vma_pages
helper on vma
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
virt/kvm/kvm_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
index 7851f3a..8f0e9ea 100644
--- a/virt/kvm/kvm_main.c
+++ b/virt/kvm/kvm_main.c
@@ -3523,7 +3523,7 @@ static vm_fault_t kvm_vcpu_fault(struct vm_fault *vmf)
static int kvm_vcpu_mmap(struct file *file, struct vm_area_struct *vma)
{
struct kvm_vcpu *vcpu = file->private_data;
- unsigned long pages = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT;
+ unsigned long pages = vma_pages(vma);
if ((kvm_page_in_dirty_ring(vcpu->kvm, vma->vm_pgoff) ||
kvm_page_in_dirty_ring(vcpu->kvm, vma->vm_pgoff + pages - 1)) &&
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH -next] KVM: use vma_pages() helper
2021-09-29 7:28 [PATCH -next] KVM: use vma_pages() helper Yang Li
@ 2021-09-29 12:56 ` Paolo Bonzini
0 siblings, 0 replies; 2+ messages in thread
From: Paolo Bonzini @ 2021-09-29 12:56 UTC (permalink / raw)
To: Yang Li; +Cc: kvm, linux-kernel
On 29/09/21 09:28, Yang Li wrote:
> Use vma_pages function on vma object instead of explicit computation.
>
> Fix the following coccicheck warning:
> ./virt/kvm/kvm_main.c:3526:29-35: WARNING: Consider using vma_pages
> helper on vma
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> virt/kvm/kvm_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> index 7851f3a..8f0e9ea 100644
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -3523,7 +3523,7 @@ static vm_fault_t kvm_vcpu_fault(struct vm_fault *vmf)
> static int kvm_vcpu_mmap(struct file *file, struct vm_area_struct *vma)
> {
> struct kvm_vcpu *vcpu = file->private_data;
> - unsigned long pages = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT;
> + unsigned long pages = vma_pages(vma);
>
> if ((kvm_page_in_dirty_ring(vcpu->kvm, vma->vm_pgoff) ||
> kvm_page_in_dirty_ring(vcpu->kvm, vma->vm_pgoff + pages - 1)) &&
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-29 12:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-09-29 7:28 [PATCH -next] KVM: use vma_pages() helper Yang Li
2021-09-29 12:56 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox