From: Oliver Upton <oliver.upton@linux.dev>
To: Marc Zyngier <maz@kernel.org>, David Matlack <dmatlack@google.com>
Cc: Oliver Upton <oliver.upton@linux.dev>,
linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
James Morse <james.morse@arm.com>,
Zenghui Yu <yuzenghui@huawei.com>,
Sean Christopherson <seanjc@google.com>,
stable@vger.kernel.org,
Christoffer Dall <c.dall@virtualopensystems.com>,
kvmarm@lists.linux.dev, Will Deacon <will@kernel.org>
Subject: Re: [PATCH] KVM: arm64: Retry fault if vma_lookup() results become invalid
Date: Tue, 14 Mar 2023 18:10:18 +0000 [thread overview]
Message-ID: <167881740956.623301.15796552782250010868.b4-ty@linux.dev> (raw)
In-Reply-To: <20230313235454.2964067-1-dmatlack@google.com>
On Mon, 13 Mar 2023 16:54:54 -0700, David Matlack wrote:
> Read mmu_invalidate_seq before dropping the mmap_lock so that KVM can
> detect if the results of vma_lookup() (e.g. vma_shift) become stale
> before it acquires kvm->mmu_lock. This fixes a theoretical bug where a
> VMA could be changed by userspace after vma_lookup() and before KVM
> reads the mmu_invalidate_seq, causing KVM to install page table entries
> based on a (possibly) no-longer-valid vma_shift.
>
> [...]
Applied to kvmarm/fixes, thanks!
[1/1] KVM: arm64: Retry fault if vma_lookup() results become invalid
https://git.kernel.org/kvmarm/kvmarm/c/13ec9308a857
--
Best,
Oliver
prev parent reply other threads:[~2023-03-14 18:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-13 23:54 [PATCH] KVM: arm64: Retry fault if vma_lookup() results become invalid David Matlack
2023-03-14 16:31 ` Marc Zyngier
2023-03-14 16:46 ` Oliver Upton
2023-03-14 18:10 ` Oliver Upton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167881740956.623301.15796552782250010868.b4-ty@linux.dev \
--to=oliver.upton@linux.dev \
--cc=c.dall@virtualopensystems.com \
--cc=dmatlack@google.com \
--cc=james.morse@arm.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=maz@kernel.org \
--cc=mtosatti@redhat.com \
--cc=seanjc@google.com \
--cc=stable@vger.kernel.org \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox