From: Muli Ben-Yehuda <muli-7z/5BgaJwgfQT0dZR+AlfA@public.gmane.org>
To: kvm-devel <kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Subject: [PATCH resend #1] restore previous KERNELDIR behavior
Date: Wed, 14 Feb 2007 05:47:59 +0200 [thread overview]
Message-ID: <20070214034759.GB461@rhun.ibm.com> (raw)
My patch to fix the --kerneldir option to configure caused a subtle
change in behavior when --kerneldir wasn't specified. Previously,
kernel/Makefile would set KERNELDIR to /lib/modules/xxx. The fix
caused it to be set to $(readlink -f /lib/modules/xxx) (via
config.mak). Normally this wouldn't have made any difference, a
symlink and what it points to are synonymous, but various places rely
on KERNELDIR being of the form /lib/modules/xxx for pattern
substitution. Switch back to the old behavior.
This should fix the issue reported by Omar Khan <okhan-e94Sedi4moU@public.gmane.org> and
Pelle <Pelle-5JapdU7xTciEVqv0pETR8A@public.gmane.org>
Signed-off-by: Muli Ben-Yehuda <muli-7z/5BgaJwgfQT0dZR+AlfA@public.gmane.org>
Index: configure
===================================================================
--- configure (revision 4414)
+++ configure (working copy)
@@ -94,7 +94,7 @@
cat <<EOF > config.mak
PREFIX=$prefix
-KERNELDIR=$(readlink -f $kerneldir)
+KERNELDIR="$kerneldir"
WANT_MODULE=$want_module
EOF
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
reply other threads:[~2007-02-14 3:47 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070214034759.GB461@rhun.ibm.com \
--to=muli-7z/5bgajwgfqt0dzr+alfa@public.gmane.org \
--cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox