* ioctl number overlapped?
@ 2009-07-21 6:46 Yang, Sheng
2009-07-21 6:51 ` Gleb Natapov
0 siblings, 1 reply; 3+ messages in thread
From: Yang, Sheng @ 2009-07-21 6:46 UTC (permalink / raw)
To: kvm; +Cc: Marcelo Tosatti, Gleb Natapov
Happen to see this:
include/linux.kvm.h
503 #define KVM_IRQ_LINE_STATUS _IOWR(KVMIO, 0x67, struct kvm_irq_level)
504 #define KVM_REGISTER_COALESCED_MMIO \
505 _IOW(KVMIO, 0x67, struct kvm_coalesced_mmio_zone)
Both ioctl use 0x67, and the code has released to v2.6.30...
--
regards
Yang, Sheng
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: ioctl number overlapped?
2009-07-21 6:46 ioctl number overlapped? Yang, Sheng
@ 2009-07-21 6:51 ` Gleb Natapov
2009-07-29 12:11 ` Avi Kivity
0 siblings, 1 reply; 3+ messages in thread
From: Gleb Natapov @ 2009-07-21 6:51 UTC (permalink / raw)
To: Yang, Sheng; +Cc: kvm, Marcelo Tosatti
On Tue, Jul 21, 2009 at 02:46:44PM +0800, Yang, Sheng wrote:
> Happen to see this:
>
> include/linux.kvm.h
>
> 503 #define KVM_IRQ_LINE_STATUS _IOWR(KVMIO, 0x67, struct kvm_irq_level)
> 504 #define KVM_REGISTER_COALESCED_MMIO \
> 505 _IOW(KVMIO, 0x67, struct kvm_coalesced_mmio_zone)
>
> Both ioctl use 0x67, and the code has released to v2.6.30...
>
I don't think they are really overlapping. One of them is RW another W
(haven't checked if the structure sizeof is different).
--
Gleb.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: ioctl number overlapped?
2009-07-21 6:51 ` Gleb Natapov
@ 2009-07-29 12:11 ` Avi Kivity
0 siblings, 0 replies; 3+ messages in thread
From: Avi Kivity @ 2009-07-29 12:11 UTC (permalink / raw)
To: Gleb Natapov; +Cc: Yang, Sheng, kvm, Marcelo Tosatti
On 07/21/2009 09:51 AM, Gleb Natapov wrote:
> On Tue, Jul 21, 2009 at 02:46:44PM +0800, Yang, Sheng wrote:
>
>> Happen to see this:
>>
>> include/linux.kvm.h
>>
>> 503 #define KVM_IRQ_LINE_STATUS _IOWR(KVMIO, 0x67, struct kvm_irq_level)
>> 504 #define KVM_REGISTER_COALESCED_MMIO \
>> 505 _IOW(KVMIO, 0x67, struct kvm_coalesced_mmio_zone)
>>
>> Both ioctl use 0x67, and the code has released to v2.6.30...
>>
>>
> I don't think they are really overlapping. One of them is RW another W
> (haven't checked if the structure sizeof is different).
>
>
Nevertheless we shouldn't do this.
--
error compiling committee.c: too many arguments to function
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-07-29 12:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-21 6:46 ioctl number overlapped? Yang, Sheng
2009-07-21 6:51 ` Gleb Natapov
2009-07-29 12:11 ` Avi Kivity
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox