From: Marcelo Tosatti <mtosatti@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Avi Kivity <avi@redhat.com>, kvm-devel <kvm@vger.kernel.org>
Subject: Re: [PATCH] qemu-kvm: Fix guest single-stepping
Date: Fri, 18 Sep 2009 13:05:25 -0300 [thread overview]
Message-ID: <20090918160524.GA3888@amt.cnet> (raw)
In-Reply-To: <4AB277B5.5000105@siemens.com>
Applied, thanks.
On Thu, Sep 17, 2009 at 07:53:57PM +0200, Jan Kiszka wrote:
> Hopefully the last regression of 4c0960c0: KVM_SET_GUEST_DEBUG requires
> properly synchronized guest registers (on x86: eflags) on entry.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>
> qemu-kvm.c | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/qemu-kvm.c b/qemu-kvm.c
> index 78eeb6f..569397e 100644
> --- a/qemu-kvm.c
> +++ b/qemu-kvm.c
> @@ -2282,6 +2282,10 @@ static void kvm_invoke_set_guest_debug(void *data)
> {
> struct kvm_set_guest_debug_data *dbg_data = data;
>
> + if (cpu_single_env->kvm_cpu_state.regs_modified) {
> + kvm_arch_put_registers(cpu_single_env);
> + cpu_single_env->kvm_cpu_state.regs_modified = 0;
> + }
> dbg_data->err =
> kvm_set_guest_debug(cpu_single_env->kvm_cpu_state.vcpu_ctx,
> &dbg_data->dbg);
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2009-09-18 16:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-17 17:53 [PATCH] qemu-kvm: Fix guest single-stepping Jan Kiszka
2009-09-18 16:05 ` Marcelo Tosatti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090918160524.GA3888@amt.cnet \
--to=mtosatti@redhat.com \
--cc=avi@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox