public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] PPC: Fix typo in rebolting code
@ 2010-01-04 21:19 Alexander Graf
  2010-01-06  8:53 ` Marcelo Tosatti
  0 siblings, 1 reply; 2+ messages in thread
From: Alexander Graf @ 2010-01-04 21:19 UTC (permalink / raw)
  To: kvm-u79uwXL29TY76Z2rM5mHXA; +Cc: kvm-ppc

When we're loading bolted entries into the SLB again, we're checking if an
entry is in use and only slbmte it when it is.

Unfortunately, the check always goes to the skip label of the first entry,
resulting in an endless loop when it actually gets triggered.

Signed-off-by: Alexander Graf <agraf-l3A5Bk7waGM@public.gmane.org>
---
 arch/powerpc/kvm/book3s_64_slb.S |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/powerpc/kvm/book3s_64_slb.S b/arch/powerpc/kvm/book3s_64_slb.S
index ecd237a..8e44788 100644
--- a/arch/powerpc/kvm/book3s_64_slb.S
+++ b/arch/powerpc/kvm/book3s_64_slb.S
@@ -31,7 +31,7 @@
 #define REBOLT_SLB_ENTRY(num) \
 	ld	r10, SHADOW_SLB_ESID(num)(r11); \
 	cmpdi	r10, 0; \
-	beq	slb_exit_skip_1; \
+	beq	slb_exit_skip_ ## num; \
 	oris	r10, r10, SLB_ESID_V@h; \
 	ld	r9, SHADOW_SLB_VSID(num)(r11); \
 	slbmte	r9, r10; \
-- 
1.6.0.2

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] PPC: Fix typo in rebolting code
  2010-01-04 21:19 [PATCH] PPC: Fix typo in rebolting code Alexander Graf
@ 2010-01-06  8:53 ` Marcelo Tosatti
  0 siblings, 0 replies; 2+ messages in thread
From: Marcelo Tosatti @ 2010-01-06  8:53 UTC (permalink / raw)
  To: Alexander Graf; +Cc: kvm, kvm-ppc

On Mon, Jan 04, 2010 at 10:19:22PM +0100, Alexander Graf wrote:
> When we're loading bolted entries into the SLB again, we're checking if an
> entry is in use and only slbmte it when it is.
> 
> Unfortunately, the check always goes to the skip label of the first entry,
> resulting in an endless loop when it actually gets triggered.
> 
> Signed-off-by: Alexander Graf <agraf@suse.de>

Applied, thanks.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-01-06  9:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-04 21:19 [PATCH] PPC: Fix typo in rebolting code Alexander Graf
2010-01-06  8:53 ` Marcelo Tosatti

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox