From: Marcelo Tosatti <mtosatti@redhat.com>
To: Sheng Yang <sheng@linux.intel.com>
Cc: Avi Kivity <avi@redhat.com>, kvm@vger.kernel.org
Subject: Re: [PATCH 4/4] KVM: VMX: Enable EPT 1GB page support
Date: Wed, 6 Jan 2010 08:02:15 -0200 [thread overview]
Message-ID: <20100106100215.GB4553@amt.cnet> (raw)
In-Reply-To: <201001061725.27571.sheng@linux.intel.com>
On Wed, Jan 06, 2010 at 05:25:27PM +0800, Sheng Yang wrote:
> > > - for (level = PT_DIRECTORY_LEVEL; level <= host_level; ++level)
> > > + max_level = kvm_x86_ops->get_lpage_level() < host_level ?
> > > + kvm_x86_ops->get_lpage_level() : host_level;
> > > +
> >
> > BUG_ON(kvm_x86_ops->get_lpage_level() < host_level) instead? See
> > the if (host_level == PT_PAGE_TABLE_LEVEL) above.
>
> Sorry, I don't understand...
>
> Here, EPT can support either 2MB or 1GB page at most, So we represent the
> value through get_lpage_level(). Now 1GB page backed host memory can still
> using by 2MB page backed EPT if 1GB page EPT is not supported in the
> processor.
Oh, OK, i misundertood.
Applied, thanks.
prev parent reply other threads:[~2010-01-06 10:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-05 11:02 [PATCH 0/4 v2] EPT 1GB page support Sheng Yang
2010-01-05 11:02 ` [PATCH 1/4] KVM: x86: Moving PT_*_LEVEL to mmu.h Sheng Yang
2010-01-05 11:02 ` [PATCH 2/4] KVM: x86: Rename gb_page_enable() to get_lpage_level() in kvm_x86_ops Sheng Yang
2010-01-05 11:02 ` [PATCH 3/4] KVM: x86: Fix host_mapping_level() Sheng Yang
2010-01-05 11:02 ` [PATCH 4/4] KVM: VMX: Enable EPT 1GB page support Sheng Yang
2010-01-06 9:19 ` Marcelo Tosatti
2010-01-06 9:25 ` Sheng Yang
2010-01-06 10:02 ` Marcelo Tosatti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100106100215.GB4553@amt.cnet \
--to=mtosatti@redhat.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=sheng@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox