From: Marcelo Tosatti <mtosatti@redhat.com>
To: Mark Cave-Ayland <mark.cave-ayland@siriusit.co.uk>,
Anthony Liguori <aliguori@us.ibm.com>,
Yaniv Kaul <ykaul@redhat.com>
Cc: kvm@vger.kernel.org
Subject: Re: VNC framebuffer block artefacts on qemu-kvm-0.12.1.1
Date: Wed, 6 Jan 2010 11:51:18 -0200 [thread overview]
Message-ID: <20100106135118.GA28640@amt.cnet> (raw)
In-Reply-To: <4B4364AE.8080509@siriusit.co.uk>
[-- Attachment #1: Type: text/plain, Size: 1161 bytes --]
On Tue, Jan 05, 2010 at 04:11:26PM +0000, Mark Cave-Ayland wrote:
> Hi all,
>
> Having just upgraded from kvm-85 to qemu-kvm-0.12.1.1 on one of our
> servers, I've noticed that I am seeing block artefacts when connecting
> using VNC to the graphical VGA console of a WinXP guest.
>
> Looking at the VNC output, what I am seeing is that instead of updating
> some parts of the screen which require a redraw, they are just being
> replaced by light grey blocks of around 16x16 pixels. Generally, but not
> always, several of these blocks appear in a row. Moving the mouse over
> the relevant sections of the screen causes them to be redrawn correctly.
>
> I've tried this using both the cirrus and vga drivers, switching between
> 16/24/32 bit colour and also different resolutions and unfortunately the
> effect still remains :( Is there anything else I can do to help try and
> debug this? Again this is on an x86_64 Debian Lenny host with a 2.6.32.2
> kernel on Intel.
Mark,
Can you confirm that reverting commit
02c2b87fff97e77a1f6033fb09f53afa267c0c1e fixes the problem? (patch
attached).
Anthony: its reproducible with upstream/tcg.
[-- Attachment #2: qemu-revert-02c2.patch --]
[-- Type: text/plain, Size: 666 bytes --]
diff --git a/vnchextile.h b/vnchextile.h
index 432ed89..c96ede3 100644
--- a/vnchextile.h
+++ b/vnchextile.h
@@ -73,7 +73,7 @@ static void CONCAT(send_hextile_tile_, NAME)(VncState *vs,
*last_bg = bg;
}
- if (n_colors < 3 && (!*has_fg || *last_fg != fg)) {
+ if (!*has_fg || *last_fg != fg) {
flags |= 0x04;
*has_fg = 1;
*last_fg = fg;
@@ -165,6 +165,8 @@ static void CONCAT(send_hextile_tile_, NAME)(VncState *vs,
irow += ds_get_linesize(vs->ds) / sizeof(pixel_t);
}
+ /* A SubrectsColoured subtile invalidates the foreground color */
+ *has_fg = 0;
if (n_data > (w * h * sizeof(pixel_t))) {
n_colors = 4;
flags = 0x01;
next prev parent reply other threads:[~2010-01-06 13:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-05 16:11 VNC framebuffer block artefacts on qemu-kvm-0.12.1.1 Mark Cave-Ayland
2010-01-06 13:51 ` Marcelo Tosatti [this message]
2010-01-06 15:36 ` Mark Cave-Ayland
2010-01-06 17:58 ` Anthony Liguori
2010-01-06 18:12 ` Marcelo Tosatti
2010-01-06 19:06 ` Anthony Liguori
2010-01-06 22:21 ` Mark Cave-Ayland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100106135118.GA28640@amt.cnet \
--to=mtosatti@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=mark.cave-ayland@siriusit.co.uk \
--cc=ykaul@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox