Kernel KVM virtualization development
 help / color / mirror / Atom feed
From: Mark Cave-Ayland <mark.cave-ayland@siriusit.co.uk>
To: Anthony Liguori <aliguori@linux.vnet.ibm.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
	Anthony Liguori <aliguori@us.ibm.com>,
	Yaniv Kaul <ykaul@redhat.com>,
	kvm@vger.kernel.org
Subject: Re: VNC framebuffer block artefacts on qemu-kvm-0.12.1.1
Date: Wed, 06 Jan 2010 22:21:30 +0000	[thread overview]
Message-ID: <4B450CEA.9030306@siriusit.co.uk> (raw)
In-Reply-To: <4B44DF46.3030503@linux.vnet.ibm.com>

Anthony Liguori wrote:

> What about just adding back this bit:
> 
> @@ -165,6 +165,8 @@ static void CONCAT(send_hextile_tile_, 
> NAME)(VncState *vs,
>          irow += ds_get_linesize(vs->ds) / sizeof(pixel_t);
>      }
> 
> +    /* A SubrectsColoured subtile invalidates the foreground color */
> +    *has_fg = 0;
>      if (n_data>  (w * h * sizeof(pixel_t))) {
>          n_colors = 4;
>          flags = 0x01;
> 
> I think I can rationalize why that would be needed.

Hi Anthony,

I've done a rebuild with just the above part of the patch applied, and I 
can confirm that indeed it resolves the problem on my WinXP guest here.


Many thanks,

Mark.

-- 
Mark Cave-Ayland - Senior Technical Architect
PostgreSQL - PostGIS
Sirius Corporation plc - control through freedom
http://www.siriusit.co.uk
t: +44 870 608 0063

Sirius Labs: http://www.siriusit.co.uk/labs

      reply	other threads:[~2010-01-06 22:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-05 16:11 VNC framebuffer block artefacts on qemu-kvm-0.12.1.1 Mark Cave-Ayland
2010-01-06 13:51 ` Marcelo Tosatti
2010-01-06 15:36   ` Mark Cave-Ayland
2010-01-06 17:58   ` Anthony Liguori
2010-01-06 18:12     ` Marcelo Tosatti
2010-01-06 19:06   ` Anthony Liguori
2010-01-06 22:21     ` Mark Cave-Ayland [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B450CEA.9030306@siriusit.co.uk \
    --to=mark.cave-ayland@siriusit.co.uk \
    --cc=aliguori@linux.vnet.ibm.com \
    --cc=aliguori@us.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=ykaul@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox