From: Marcelo Tosatti <mtosatti@redhat.com>
To: Takuya Yoshikawa <yoshikawa.takuya@oss.ntt.co.jp>
Cc: avi@redhat.com, kvm@vger.kernel.org
Subject: Re: [PATCH rework] KVM: coalesced_mmio: fix kvm_coalesced_mmio_init()'s error handling
Date: Wed, 17 Mar 2010 16:08:05 -0300 [thread overview]
Message-ID: <20100317190805.GA12565@amt.cnet> (raw)
In-Reply-To: <20100315221330.76e7d7d3.yoshikawa.takuya@oss.ntt.co.jp>
On Mon, Mar 15, 2010 at 10:13:30PM +0900, Takuya Yoshikawa wrote:
> kvm_coalesced_mmio_init() keeps to hold the addresses of a coalesced
> mmio ring page and dev even after it has freed them.
>
> Also, if this function fails, though it might be rare, it seems to be
> suggesting the system's serious state: so we'd better stop the works
> following the kvm_creat_vm().
>
> This patch clears these problems.
>
> We move the coalesced mmio's initialization out of kvm_create_vm().
> This seems to be natural because it includes a registration which
> can be done only when vm is successfully created.
>
> Signed-off-by: Takuya Yoshikawa <yoshikawa.takuya@oss.ntt.co.jp>
> ---
> virt/kvm/coalesced_mmio.c | 2 ++
> virt/kvm/kvm_main.c | 12 ++++++++----
> 2 files changed, 10 insertions(+), 4 deletions(-)
Applied, thanks.
prev parent reply other threads:[~2010-03-17 19:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-15 13:13 [PATCH rework] KVM: coalesced_mmio: fix kvm_coalesced_mmio_init()'s error handling Takuya Yoshikawa
2010-03-17 19:08 ` Marcelo Tosatti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100317190805.GA12565@amt.cnet \
--to=mtosatti@redhat.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=yoshikawa.takuya@oss.ntt.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox