Kernel KVM virtualization development
 help / color / mirror / Atom feed
From: Alex Williamson <alex.williamson@redhat.com>
To: kvm@vger.kernel.org
Cc: ddutile@redhat.com, chrisw@redhat.com, gleb@redhat.com,
	alex.williamson@redhat.com
Subject: [PATCH 0/3] device-assignment: PCI option ROM fixes
Date: Fri, 30 Jul 2010 13:40:07 -0600	[thread overview]
Message-ID: <20100730193941.10110.92913.stgit@localhost6.localdomain6> (raw)

Changeset b4f8c249 in kvm.git makes the mprotects in device assignment
produce a "Bad address" hang when a device with an option ROM is
assigned.  We can avoid this by just using the slow mapping path since
ROM access doesn't need to be fast.  Apparently nobody has ever mapped
a ROM via this path, because passing NULL to cpu_register_io_memory()
doesn't work.  I also found we're overly restrictive in copying the
ROM from the host, I must have been lucky and had a ROM that matched
the BAR size when I added this.

Alex

---

Alex Williamson (3):
      device-assignment: Byte-wise ROM read
      device-assignment: Always use slow mapping for PCI option ROM
      device-assignment: Fix slow option ROM mapping


 hw/device-assignment.c |   21 ++++++++++-----------
 1 files changed, 10 insertions(+), 11 deletions(-)


             reply	other threads:[~2010-07-30 19:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-30 19:40 Alex Williamson [this message]
2010-07-30 19:40 ` [PATCH 1/3] device-assignment: Fix slow option ROM mapping Alex Williamson
2010-07-31 16:54   ` Chris Wright
2010-07-30 19:40 ` [PATCH 2/3] device-assignment: Always use slow mapping for PCI option ROM Alex Williamson
2010-07-31 16:55   ` Chris Wright
2010-07-30 19:40 ` [PATCH 3/3] device-assignment: Byte-wise ROM read Alex Williamson
2010-07-31 17:08   ` Chris Wright
2010-08-17  9:49 ` [PATCH 0/3] device-assignment: PCI option ROM fixes Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100730193941.10110.92913.stgit@localhost6.localdomain6 \
    --to=alex.williamson@redhat.com \
    --cc=chrisw@redhat.com \
    --cc=ddutile@redhat.com \
    --cc=gleb@redhat.com \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox