Kernel KVM virtualization development
 help / color / mirror / Atom feed
From: Chris Wright <chrisw@redhat.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: kvm@vger.kernel.org, ddutile@redhat.com, chrisw@redhat.com,
	gleb@redhat.com
Subject: Re: [PATCH 3/3] device-assignment: Byte-wise ROM read
Date: Sat, 31 Jul 2010 10:08:31 -0700	[thread overview]
Message-ID: <20100731170831.GC28601@x200.localdomain> (raw)
In-Reply-To: <20100730194025.10110.47519.stgit@localhost6.localdomain6>

* Alex Williamson (alex.williamson@redhat.com) wrote:
> The host kernel filters the PCI option ROM, returning only bytes for
> the actual ROM size, not for the whole BAR.  That means we typically
> do a short read of the PCI sysfs ROM file.  Read it a byte at a time
> so we know how much to actually copy and only skip the copy if we
> get nothing.

Acked-by: Chris Wright <chrisw@redhat.com>

  reply	other threads:[~2010-07-31 17:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-30 19:40 [PATCH 0/3] device-assignment: PCI option ROM fixes Alex Williamson
2010-07-30 19:40 ` [PATCH 1/3] device-assignment: Fix slow option ROM mapping Alex Williamson
2010-07-31 16:54   ` Chris Wright
2010-07-30 19:40 ` [PATCH 2/3] device-assignment: Always use slow mapping for PCI option ROM Alex Williamson
2010-07-31 16:55   ` Chris Wright
2010-07-30 19:40 ` [PATCH 3/3] device-assignment: Byte-wise ROM read Alex Williamson
2010-07-31 17:08   ` Chris Wright [this message]
2010-08-17  9:49 ` [PATCH 0/3] device-assignment: PCI option ROM fixes Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100731170831.GC28601@x200.localdomain \
    --to=chrisw@redhat.com \
    --cc=alex.williamson@redhat.com \
    --cc=ddutile@redhat.com \
    --cc=gleb@redhat.com \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox