public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Pekka Enberg <penberg@kernel.org>
Cc: Prasad Joshi <prasadjoshi124@gmail.com>,
	kvm@vger.kernel.org, asias.hejun@gmail.com, gorcunov@gmail.com,
	levinsasha928@gmail.com, chaitanyakulkarni15@gmail.com
Subject: Re: [PATCH] kvm tool: Remove the __stringify* defination from the util.h
Date: Sat, 16 Apr 2011 11:45:35 +0200	[thread overview]
Message-ID: <20110416094535.GB24711@elte.hu> (raw)
In-Reply-To: <BANLkTime5Zwqj0pLy6_Kxo1BTaLiOEto8A@mail.gmail.com>


* Pekka Enberg <penberg@kernel.org> wrote:

> On Fri, Apr 15, 2011 at 10:43 PM, Prasad Joshi <prasadjoshi124@gmail.com> wrote:
> > Include the Linux kernel header file linux/stringify.h file instead of
> > redefining the __stringify* macros
> >
> > Signed-off-by: Prasad Joshi <prasadjoshi124@gmail.com>
> > ---
> >  tools/kvm/include/kvm/util.h |    5 ++---
> >  1 files changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/tools/kvm/include/kvm/util.h b/tools/kvm/include/kvm/util.h
> > index ae033cc..c308f3f 100644
> > --- a/tools/kvm/include/kvm/util.h
> > +++ b/tools/kvm/include/kvm/util.h
> > @@ -1,3 +1,5 @@
> > +#include "../../../../include/linux/stringify.h"
> 
> #include <linux/stringify.h> should just work, no?

Only if kernel headers are installed. Also, and perhaps more importantly, in 
the context of perf it was more robust to use the same kernel repo's source 
code that perf resides in - should there be any fixes needed it's a lot easier 
to remedy things.

Thanks,

	Ingo

  reply	other threads:[~2011-04-16  9:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-15 19:43 [PATCH] kvm tool: Remove the __stringify* defination from the util.h Prasad Joshi
2011-04-16  9:26 ` Pekka Enberg
2011-04-16  9:45   ` Ingo Molnar [this message]
2011-04-16  9:47     ` Pekka Enberg
2011-04-16  9:49       ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110416094535.GB24711@elte.hu \
    --to=mingo@elte.hu \
    --cc=asias.hejun@gmail.com \
    --cc=chaitanyakulkarni15@gmail.com \
    --cc=gorcunov@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=levinsasha928@gmail.com \
    --cc=penberg@kernel.org \
    --cc=prasadjoshi124@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox