From: Ingo Molnar <mingo@elte.hu>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: KVM devel mailing list <kvm@vger.kernel.org>,
Amos Kong <kongjianjun@gmail.com>
Subject: Re: [PATCH] kvm tools: Setup bridged network by a script
Date: Sat, 16 Apr 2011 11:55:43 +0200 [thread overview]
Message-ID: <20110416095543.GA7305@elte.hu> (raw)
Hi, i noticed this small detail:
+ if (strcmp(params->script, "none")) {
+ pid = fork();
+ if (pid == 0) {
+ execl(params->script, params->script, net_device.tap_name, NULL);
+ _exit(1);
+ } else {
+ waitpid(pid, &status, 0);
+ if (WIFEXITED(status) && WEXITSTATUS(status) != 0) {
+ warning("Fail to setup tap by %s", params->script);
+ goto fail;
+ }
+ }
this path does not seem to have robust error handling: both fork() and
waitpid() can (and sometimes do) fail. If waitpid() fails then 'status' might
be ununitialized as well, IIRC.
Thanks,
Ingo
next reply other threads:[~2011-04-16 9:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-16 9:55 Ingo Molnar [this message]
2011-04-18 0:12 ` [PATCH] kvm tools: Add robust error handling for fork/waitpid() Amos Kong
2011-04-18 6:34 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110416095543.GA7305@elte.hu \
--to=mingo@elte.hu \
--cc=kongjianjun@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox