public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Amos Kong <kongjianjun@gmail.com>
Cc: kvm@vger.kernel.org, penberg@kernel.org, asias.hejun@gmail.com
Subject: Re: [PATCH] kvm tools: Add robust error handling for fork/waitpid()
Date: Mon, 18 Apr 2011 08:34:40 +0200	[thread overview]
Message-ID: <20110418063440.GA12814@elte.hu> (raw)
In-Reply-To: <20110418001250.4934.17958.stgit@localhost6.localdomain6>


* Amos Kong <kongjianjun@gmail.com> wrote:

> +		} else if (pid > 0) {
> +			while(waitpid(pid, &status, 0) != pid) {
>  			}
>  		}

Doesn't that look like an infinite loop when waitpid() returns an error?

Thanks,

	Ingo

      reply	other threads:[~2011-04-18  6:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-16  9:55 [PATCH] kvm tools: Setup bridged network by a script Ingo Molnar
2011-04-18  0:12 ` [PATCH] kvm tools: Add robust error handling for fork/waitpid() Amos Kong
2011-04-18  6:34   ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110418063440.GA12814@elte.hu \
    --to=mingo@elte.hu \
    --cc=asias.hejun@gmail.com \
    --cc=kongjianjun@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=penberg@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox