From: Kevin O'Connor <kevin@koconnor.net>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: seabios@seabios.org, kvm@vger.kernel.org
Subject: Re: [PATCH RFC] acpi: extract aml from .lst
Date: Thu, 27 Oct 2011 20:08:54 -0400 [thread overview]
Message-ID: <20111028000854.GC16619@morn.localdomain> (raw)
In-Reply-To: <20111026212801.GA12953@redhat.com>
On Wed, Oct 26, 2011 at 11:28:02PM +0200, Michael S. Tsirkin wrote:
> Add ACPI_EXTRACT_ALL_CODE directive, to support extracting
> AML code from listing into a named array. Use that instead including C
> file generated by iasl, this makes it possible to include multiple AML
> tables without resorting to preprocessor tricks.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>
> ---
>
> Kevin, you suggested something like the below, I think? Seems to work
> but RFC since I didn't have time to test this properly.
It looks okay to me (I didn't do any exhaustive tests either). It
would be preferable if we didn't have to change the acpi-dsdt.dsl file
though - that way users could still compile it with the iasl compiler
directly. Can the output default to "AmlCode" if no directive is
found?
-Kevin
next prev parent reply other threads:[~2011-10-28 0:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-26 21:28 [PATCH RFC] acpi: extract aml from .lst Michael S. Tsirkin
2011-10-28 0:08 ` Kevin O'Connor [this message]
2011-10-30 17:51 ` Kevin O'Connor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111028000854.GC16619@morn.localdomain \
--to=kevin@koconnor.net \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=seabios@seabios.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox