From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Pekka Enberg <penberg@kernel.org>
Cc: Richard Weinberger <richard@nod.at>,
Sasha Levin <levinsasha928@gmail.com>,
kvm@vger.kernel.org, mingo@elte.hu, asias.hejun@gmail.com
Subject: Re: kvm tools: clock sources for hrtimer
Date: Wed, 9 Nov 2011 23:25:34 +0400 [thread overview]
Message-ID: <20111109192534.GF608@moon> (raw)
In-Reply-To: <1320866034.1428.94.camel@jaguar>
On Wed, Nov 09, 2011 at 09:13:54PM +0200, Pekka Enberg wrote:
...
> Yup, "notsc" was used in the early days to avoid APIC emulation.
>
> Anyone care to send a patch to drop it from master?
>
> Pekka
>
Here we go
---
Subject: [PATCH] tools, kvm: Drop "notsc" no longer needed kernel option
"notsc" option has been used to avoid APIC calibration
problem at early days when we didn't support APIC at all.
Now with KVM APIC emulation used there is no longer need
for this option. Drop it.
Reported-by: Richard Weinberger <richard@nod.at>
Tested-by: Richard Weinberger <richard@nod.at>
Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
---
tools/kvm/builtin-run.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6.git/tools/kvm/builtin-run.c
===================================================================
--- linux-2.6.git.orig/tools/kvm/builtin-run.c
+++ linux-2.6.git/tools/kvm/builtin-run.c
@@ -830,7 +830,7 @@ int kvm_cmd_run(int argc, const char **a
vidmode = 0;
memset(real_cmdline, 0, sizeof(real_cmdline));
- strcpy(real_cmdline, "notsc noapic noacpi pci=conf1 reboot=k panic=1 i8042.direct=1 "
+ strcpy(real_cmdline, "noapic noacpi pci=conf1 reboot=k panic=1 i8042.direct=1 "
"i8042.dumbkbd=1 i8042.nopnp=1");
if (vnc || sdl) {
strcat(real_cmdline, " video=vesafb console=tty0");
prev parent reply other threads:[~2011-11-09 19:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-09 14:27 kvm tools: clock sources for hrtimer Richard Weinberger
2011-11-09 14:49 ` Sasha Levin
2011-11-09 15:42 ` Richard Weinberger
2011-11-09 15:49 ` Sasha Levin
2011-11-09 16:00 ` Cyrill Gorcunov
2011-11-09 16:14 ` Cyrill Gorcunov
2011-11-09 18:56 ` Richard Weinberger
2011-11-09 19:13 ` Pekka Enberg
2011-11-09 19:25 ` Cyrill Gorcunov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111109192534.GF608@moon \
--to=gorcunov@gmail.com \
--cc=asias.hejun@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=levinsasha928@gmail.com \
--cc=mingo@elte.hu \
--cc=penberg@kernel.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox