[PATCH] KVM: fix a syntax error in pmu.c

[PATCH] KVM: fix a syntax error in pmu.c

[Ren, Yongjie]

Fix a syntax error in arch/x86/kvm/pmu.c

Signed-off-by: Yongjie Ren <yongjie.ren@intel.com>
---
diff --git a/arch/x86/kvm/pmu.c b/arch/x86/kvm/pmu.c
index 061a03f..8f142bf 100644
--- a/arch/x86/kvm/pmu.c
+++ b/arch/x86/kvm/pmu.c
@@ -170,9 +170,9 @@ static void reprogram_counter(struct kvm_pmc *pmc, u32 type,
 		.exclude_host = 1,
 		.exclude_user = exclude_user,
 		.exclude_kernel = exclude_kernel,
-		.sample_period = (-pmc->counter) & pmc_bitmask(pmc),
 		.config = config,
 	};
+	attr.sample_period = (-pmc->counter) & pmc_bitmask(pmc),
 
 	event = perf_event_create_kernel_counter(&attr, -1, current,
 						 intr ? kvm_perf_overflow_intr :


Best Regards,
     Yongjie Ren  (Jay)

Re: [PATCH] KVM: fix a syntax error in pmu.c

[Gleb Natapov]

On Thu, Dec 29, 2011 at 09:40:37AM +0000, Ren, Yongjie wrote:
> Fix a syntax error in arch/x86/kvm/pmu.c
> 
That is fixed already in kvm.git next branch.

> Signed-off-by: Yongjie Ren <yongjie.ren@intel.com>
> ---
> diff --git a/arch/x86/kvm/pmu.c b/arch/x86/kvm/pmu.c
> index 061a03f..8f142bf 100644
> --- a/arch/x86/kvm/pmu.c
> +++ b/arch/x86/kvm/pmu.c
> @@ -170,9 +170,9 @@ static void reprogram_counter(struct kvm_pmc *pmc, u32 type,
>  		.exclude_host = 1,
>  		.exclude_user = exclude_user,
>  		.exclude_kernel = exclude_kernel,
> -		.sample_period = (-pmc->counter) & pmc_bitmask(pmc),
>  		.config = config,
>  	};
> +	attr.sample_period = (-pmc->counter) & pmc_bitmask(pmc),
>  
>  	event = perf_event_create_kernel_counter(&attr, -1, current,
>  						 intr ? kvm_perf_overflow_intr :
> 
> 
> Best Regards,
>      Yongjie Ren  (Jay)
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
			Gleb.

RE: [PATCH] KVM: fix a syntax error in pmu.c

[Ren, Yongjie]

> -----Original Message-----
> From: Gleb Natapov [mailto:gleb@redhat.com]
> Sent: Thursday, December 29, 2011 5:46 PM
> To: Ren, Yongjie
> Cc: avi@redhat.com; kvm@vger.kernel.org
> Subject: Re: [PATCH] KVM: fix a syntax error in pmu.c
> 
> On Thu, Dec 29, 2011 at 09:40:37AM +0000, Ren, Yongjie wrote:
> > Fix a syntax error in arch/x86/kvm/pmu.c
> >
> That is fixed already in kvm.git next branch.
> 
OK. Waiting for the fix in mater tree.

> > Signed-off-by: Yongjie Ren <yongjie.ren@intel.com>
> > ---
> > diff --git a/arch/x86/kvm/pmu.c b/arch/x86/kvm/pmu.c
> > index 061a03f..8f142bf 100644
> > --- a/arch/x86/kvm/pmu.c
> > +++ b/arch/x86/kvm/pmu.c
> > @@ -170,9 +170,9 @@ static void reprogram_counter(struct kvm_pmc
> *pmc, u32 type,
> >  		.exclude_host = 1,
> >  		.exclude_user = exclude_user,
> >  		.exclude_kernel = exclude_kernel,
> > -		.sample_period = (-pmc->counter) & pmc_bitmask(pmc),
> >  		.config = config,
> >  	};
> > +	attr.sample_period = (-pmc->counter) & pmc_bitmask(pmc),
> >
> >  	event = perf_event_create_kernel_counter(&attr, -1, current,
> >  						 intr ? kvm_perf_overflow_intr :
> >
> >
> > Best Regards,
> >      Yongjie Ren  (Jay)
> >
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe kvm" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> --
> 			Gleb.