From: Stephen Hemminger <stephen@networkplumber.org>
To: Gleb Natapov <gleb@minantech.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
kvm@vger.kernel.org, Cornelia Huck <cornelia.huck@de.ibm.com>
Subject: Re: [PATCH kvm-next 2/2] kvm: remove dead code
Date: Mon, 30 Dec 2013 14:27:20 -0800 [thread overview]
Message-ID: <20131230142720.2802b3b1@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <20131230073715.GB6244@minantech.com>
On Mon, 30 Dec 2013 09:37:15 +0200
Gleb Natapov <gleb@minantech.com> wrote:
> On Sun, Dec 29, 2013 at 12:13:08PM -0800, Stephen Hemminger wrote:
> > The function kvm_io_bus_read_cookie is defined but never used
> > in current in-tree code.
> >
> It was added recently by Cornelia (copied) with intention to be used in s390
> code. I assume the intention is still there.
The normal process is that the code is added in one patch just
before the code that uses it. Rather than the "if we build it they will come"
philosophy.
next prev parent reply other threads:[~2013-12-30 22:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-29 20:12 [PATCH kvm-next 1/2] kvm: make local functions static Stephen Hemminger
2013-12-29 20:13 ` [PATCH kvm-next 2/2] kvm: remove dead code Stephen Hemminger
2013-12-30 7:37 ` Gleb Natapov
2013-12-30 22:27 ` Stephen Hemminger [this message]
2013-12-31 15:18 ` Paolo Bonzini
2014-01-07 13:14 ` Cornelia Huck
2014-01-08 21:03 ` [PATCH kvm-next 1/2] kvm: make local functions static Marcelo Tosatti
2014-01-09 17:22 ` Hu Yaohui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131230142720.2802b3b1@nehalam.linuxnetplumber.net \
--to=stephen@networkplumber.org \
--cc=cornelia.huck@de.ibm.com \
--cc=gleb@minantech.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox