Re: [PATCH 11/15] MIPS: paravirt: Add pci controller for virtio

[Andreas Herrmann <andreas.herrmann@caviumnetworks.com>]

On Thu, May 22, 2014 at 10:17:07PM +0200, Andreas Herrmann wrote:
> On Wed, May 21, 2014 at 12:42:52PM +0100, James Hogan wrote:
> > On 20/05/14 15:47, Andreas Herrmann wrote:
> > > From: David Daney <david.daney@cavium.com>
> > > 
> > > Signed-off-by: David Daney <david.daney@cavium.com>
> > > Signed-off-by: Andreas Herrmann <andreas.herrmann@caviumnetworks.com>
> > > ---
> > >  arch/mips/Kconfig                |    1 +
> > >  arch/mips/paravirt/Kconfig       |    6 ++
> > >  arch/mips/pci/Makefile           |    2 +-
> > >  arch/mips/pci/pci-virtio-guest.c |  140 ++++++++++++++++++++++++++++++++++++++
> > >  4 files changed, 148 insertions(+), 1 deletion(-)
> > >  create mode 100644 arch/mips/paravirt/Kconfig
> > >  create mode 100644 arch/mips/pci/pci-virtio-guest.c
> > 
> > If I understand correctly this just drives a simple PCI controller for a
> > PCI bus that a virtio device happens to be usually plugged in to, yeh?
> 
> Yes.
> 
> > It sounds like it would make sense to take advantage of Will Deacon's
> > recent efforts to make a generic pci controller driver for this sort of
> > thing which specifically mentions emulation by kvmtool? Is it
> > effectively the same PCI controller that is being emulated?
> 
> I think, it's very similar. But it depends on OF.
>  
> > http://lists.infradead.org/pipermail/linux-arm-kernel/2014-February/thread.html#233491
> > http://lists.infradead.org/pipermail/linux-arm-kernel/2014-February/233491.html
> > http://lists.infradead.org/pipermail/linux-arm-kernel/2014-February/233490.html
> 
> Currently we are at v6:
> http://marc.info/?i=1399478839-3564-1-git-send-email-will.deacon@arm.com
> 
> Will take a closer look (trying to get it running for mips_paravirt).

FYI, I've dismissed this (for v2) after taking a closer look and after
I've seen https://lkml.org/lkml/2014/5/18/54.


Andreas