From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: Greg Kurz <gkurz@linux.vnet.ibm.com>
Cc: virtualization@lists.linux-foundation.org, qemu-devel@nongnu.org,
kvm@vger.kernel.org, thuth@linux.vnet.ibm.com, mst@redhat.com
Subject: Re: [PATCH RFC v2 07/12] dataplane: allow virtio-1 devices
Date: Tue, 25 Nov 2014 19:01:41 +0100 [thread overview]
Message-ID: <20141125190141.44a58471.cornelia.huck@de.ibm.com> (raw)
In-Reply-To: <20141125185556.44e23979@bahia.local>
On Tue, 25 Nov 2014 18:55:56 +0100
Greg Kurz <gkurz@linux.vnet.ibm.com> wrote:
> On Tue, 25 Nov 2014 14:24:18 +0100
> Cornelia Huck <cornelia.huck@de.ibm.com> wrote:
>
> > Handle endianness conversion for virtio-1 virtqueues correctly.
> >
> > Note that dataplane now needs to be built per-target.
> >
> > Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
> > ---
>
> We still have the same error as in your previous post...
>
> In file included from include/hw/virtio/dataplane/vring.h:23:0,
> from include/hw/virtio/virtio-scsi.h:21,
> from hw/virtio/virtio-pci.c:24:
> include/hw/virtio/virtio-access.h: In function ‘virtio_access_is_big_endian’:
> include/hw/virtio/virtio-access.h:28:15: error: attempt to use poisoned "TARGET_WORDS_BIGENDIAN"
> #elif defined(TARGET_WORDS_BIGENDIAN)
Grmpf, I thought I had fixed this. I'll do an update tomorrow.
>
> Either build virtio-pci per-target or probably better move the target tainted
> accessors to another file.
>
> > hw/block/dataplane/virtio-blk.c | 3 +-
> > hw/scsi/virtio-scsi-dataplane.c | 2 +-
> > hw/virtio/Makefile.objs | 2 +-
> > hw/virtio/dataplane/Makefile.objs | 2 +-
> > hw/virtio/dataplane/vring.c | 85 +++++++++++++++++++----------------
> > include/hw/virtio/dataplane/vring.h | 64 ++++++++++++++++++++++++--
> > 6 files changed, 113 insertions(+), 45 deletions(-)
next prev parent reply other threads:[~2014-11-25 18:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-25 13:24 [PATCH RFC v2 00/12] qemu: towards virtio-1 host support Cornelia Huck
2014-11-25 13:24 ` [PATCH RFC v2 01/12] linux-headers/virtio_config: Update with VIRTIO_F_VERSION_1 Cornelia Huck
2014-11-25 13:24 ` [PATCH RFC v2 02/12] virtio: cull virtio_bus_set_vdev_features Cornelia Huck
2014-11-25 13:24 ` [PATCH RFC v2 03/12] virtio: support more feature bits Cornelia Huck
2014-11-25 13:24 ` [PATCH RFC v2 04/12] s390x/virtio-ccw: fix check for WRITE_FEAT Cornelia Huck
2014-11-25 13:24 ` [PATCH RFC v2 05/12] virtio: introduce legacy virtio devices Cornelia Huck
2014-11-25 13:24 ` [PATCH RFC v2 06/12] virtio: allow virtio-1 queue layout Cornelia Huck
2014-11-25 13:24 ` [PATCH RFC v2 07/12] dataplane: allow virtio-1 devices Cornelia Huck
2014-11-25 17:55 ` Greg Kurz
2014-11-25 18:01 ` Cornelia Huck [this message]
2014-11-25 13:24 ` [PATCH RFC v2 08/12] s390x/css: Add a callback for when subchannel gets disabled Cornelia Huck
2014-11-25 13:24 ` [PATCH RFC v2 09/12] s390x/virtio-ccw: add virtio set-revision call Cornelia Huck
2014-11-25 13:24 ` [PATCH RFC v2 10/12] s390x/virtio-ccw: support virtio-1 set_vq format Cornelia Huck
2014-11-25 13:24 ` [PATCH RFC v2 11/12] virtio-net/virtio-blk: enable virtio 1.0 Cornelia Huck
2014-11-25 13:24 ` [PATCH RFC v2 12/12] s390x/virtio-ccw: " Cornelia Huck
2014-11-25 16:44 ` [PATCH RFC v2 00/12] qemu: towards virtio-1 host support Michael S. Tsirkin
2014-11-25 17:16 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141125190141.44a58471.cornelia.huck@de.ibm.com \
--to=cornelia.huck@de.ibm.com \
--cc=gkurz@linux.vnet.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@linux.vnet.ibm.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox