From: Marcelo Tosatti <mtosatti@redhat.com>
To: "Radim Krčmář" <rkrcmar@redhat.com>
Cc: kvm@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH kvm-unit-tests] x86: fix build (macro R interpreted as raw string)
Date: Wed, 18 Mar 2015 19:53:49 -0300 [thread overview]
Message-ID: <20150318225349.GB8702@amt.cnet> (raw)
In-Reply-To: <1426265284-29107-1-git-send-email-rkrcmar@redhat.com>
On Fri, Mar 13, 2015 at 05:48:04PM +0100, Radim Krčmář wrote:
> GCC 5.0.0 enables raw strings by default and they have higher priority
> than macros, thus R"[...]" is interpreted incorrectly:
>
> lib/x86/isr.c:112:30: error: invalid character ')' in raw string delimiter
> lib/x86/isr.c:112:8: error: stray ‘R’ in program
> lib/x86/isr.c:112:26: error: expected ‘:’ or ‘)’ before string constant
> "orl $0x200, (%%"R"sp)\n\t"
>
> Fix it by putting a space between macro R and a string literal.
> (We already do that somewhere.)
>
> Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
Applied, thanks.
prev parent reply other threads:[~2015-03-18 22:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-13 16:48 [PATCH kvm-unit-tests] x86: fix build (macro R interpreted as raw string) Radim Krčmář
2015-03-18 22:53 ` Marcelo Tosatti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150318225349.GB8702@amt.cnet \
--to=mtosatti@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox