public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Jones <drjones@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, dgibson@redhat.com,
	agraf@suse.de, thuth@redhat.com, lvivier@redhat.com
Subject: Re: [kvm-unit-tests PATCH 11/14] powerpc/ppc64: add rtas_power_off
Date: Tue, 4 Aug 2015 09:47:59 +0200	[thread overview]
Message-ID: <20150804074759.GD13384@hawk.localdomain> (raw)
In-Reply-To: <20150804040952.GE3080@voom.redhat.com>

On Tue, Aug 04, 2015 at 02:09:52PM +1000, David Gibson wrote:
> On Mon, Aug 03, 2015 at 07:08:17PM +0200, Paolo Bonzini wrote:
> > 
> > 
> > On 03/08/2015 16:41, Andrew Jones wrote:
> > > Add enough RTAS support to support power-off, and apply it to
> > > exit().
> > > 
> > > Signed-off-by: Andrew Jones <drjones@redhat.com>
> > 
> > Why not use virtio-mmio + testdev on ppc as well?  Similar to how we're
> > not using PSCI on ARM or ACPI on x86.
> 
> Strange as it seems, MMIO is actually a PITA for a simple pseries
> guest like this.  Basically, you have to enable the MMU - which
> requires a whole bunch of setup - in order to perform cache-inhibited
> loads and stores, which is what you need for IO.
> 
> There are hypercalls to sidestep this (H_LOGICAL_CI_LOAD and
> H_LOGICAL_CI_STORE), but having a hypercall and KVM exit for every IO
> access may be hideously slow.
> 
> In early development we did have a hypercall mediated virtio model,
> but it was abandoned once we got PCI working.

So I think by yours and Alex's responses, if we want testdev support
then we should target using pci to expose it. I'm ok with that, but
prefer not to be distracted with it while getting ppc kickstarted.
So, question for Paolo, are you OK with the exitcode snooper "cheat"?

Thanks,
drew

> 
> -- 
> David Gibson			| I'll have my music baroque, and my code
> david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
> 				| _way_ _around_!
> http://www.ozlabs.org/~dgibson



  reply	other threads:[~2015-08-04  7:48 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-03 14:41 [kvm-unit-tests PATCH 00/14] ppc64: initial drop Andrew Jones
2015-08-03 14:41 ` [kvm-unit-tests PATCH 01/14] lib: asm-generic: add missing casts Andrew Jones
2015-08-03 14:41 ` [kvm-unit-tests PATCH 02/14] lib: share arm-selftest utility functions Andrew Jones
2015-08-03 14:41 ` [kvm-unit-tests PATCH 03/14] config: no need to mix arch makefiles Andrew Jones
2015-08-03 14:41 ` [kvm-unit-tests PATCH 04/14] powerpc/ppc64: start skeleton framework Andrew Jones
2015-08-03 14:41 ` [kvm-unit-tests PATCH 05/14] powerpc/pp64: ppc-ify makefiles and linker script Andrew Jones
2015-08-03 14:41 ` [kvm-unit-tests PATCH 06/14] powerpc/ppc64: add boot rom source Andrew Jones
2015-08-03 14:41 ` [kvm-unit-tests PATCH 07/14] powerpc/ppc64: add bootloader to bounce into memory Andrew Jones
2015-08-03 14:41 ` [kvm-unit-tests PATCH 08/14] powerpc/ppc64: add HV putchar Andrew Jones
2015-08-04  3:50   ` David Gibson
2015-08-04  7:33     ` Andrew Jones
2015-08-03 14:41 ` [kvm-unit-tests PATCH 09/14] powerpc/ppc64: adapt arm's setup Andrew Jones
2015-08-03 14:41 ` [kvm-unit-tests PATCH 10/14] powerpc/ppc64: relocate linker VMAs Andrew Jones
2015-08-04  3:53   ` David Gibson
2015-08-04  7:35     ` Andrew Jones
2015-08-03 14:41 ` [kvm-unit-tests PATCH 11/14] powerpc/ppc64: add rtas_power_off Andrew Jones
2015-08-03 17:08   ` Paolo Bonzini
2015-08-03 18:02     ` Andrew Jones
2015-08-03 22:27       ` Alexander Graf
2015-08-04  4:09     ` David Gibson
2015-08-04  7:47       ` Andrew Jones [this message]
2015-08-04 13:15         ` Paolo Bonzini
2015-08-04 13:21           ` Andrew Jones
2015-08-05  0:06         ` David Gibson
2015-08-04  4:03   ` David Gibson
2015-08-04  7:51     ` Andrew Jones
2015-08-04  4:11   ` David Gibson
2015-08-04  7:54     ` Andrew Jones
2015-08-05  0:12       ` David Gibson
2015-08-03 14:41 ` [kvm-unit-tests PATCH 12/14] scripts: add exit code snooper Andrew Jones
2015-08-03 14:41 ` [kvm-unit-tests PATCH 13/14] powerpc/ppc64: add run script and unittests.cfg Andrew Jones
2015-08-03 14:41 ` [kvm-unit-tests PATCH 14/14] mkstandalone: add support for powerpc Andrew Jones
2015-08-03 17:06 ` [kvm-unit-tests PATCH 00/14] ppc64: initial drop Paolo Bonzini
2015-11-03  7:08 ` Thomas Huth
2015-11-03  9:40   ` Paolo Bonzini
2015-11-03 14:56     ` Andrew Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150804074759.GD13384@hawk.localdomain \
    --to=drjones@redhat.com \
    --cc=agraf@suse.de \
    --cc=david@gibson.dropbear.id.au \
    --cc=dgibson@redhat.com \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=lvivier@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox