Kernel KVM virtualization development
 help / color / mirror / Atom feed
* [kvm:vtd-pi 34/38] arch/x86/kvm/vmx.c:609:16: sparse: symbol 'vcpu_to_pi_desc' was not declared. Should it be static?
@ 2015-09-25 13:18 kbuild test robot
  2015-09-25 13:18 ` [PATCH kvm] KVM: x86: vcpu_to_pi_desc() can be static kbuild test robot
  0 siblings, 1 reply; 2+ messages in thread
From: kbuild test robot @ 2015-09-25 13:18 UTC (permalink / raw)
  To: Feng Wu; +Cc: kbuild-all, Paolo Bonzini, Alex Williamson, kvm

tree:   https://git.kernel.org/pub/scm/virt/kvm/kvm.git vtd-pi
head:   7690a83389ca993040950b6ed7b4b5efbd50a782
commit: 2d579d1d9677512d50d00f5864344331add3f9bc [34/38] KVM: x86: Update IRTE for posted-interrupts
reproduce:
  # apt-get install sparse
  git checkout 2d579d1d9677512d50d00f5864344331add3f9bc
  make ARCH=x86_64 allmodconfig
  make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> arch/x86/kvm/vmx.c:609:16: sparse: symbol 'vcpu_to_pi_desc' was not declared. Should it be static?
>> arch/x86/kvm/vmx.c:10347:5: sparse: symbol 'vmx_update_pi_irte' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH kvm] KVM: x86: vcpu_to_pi_desc() can be static
  2015-09-25 13:18 [kvm:vtd-pi 34/38] arch/x86/kvm/vmx.c:609:16: sparse: symbol 'vcpu_to_pi_desc' was not declared. Should it be static? kbuild test robot
@ 2015-09-25 13:18 ` kbuild test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kbuild test robot @ 2015-09-25 13:18 UTC (permalink / raw)
  To: Feng Wu; +Cc: kbuild-all, Paolo Bonzini, Alex Williamson, kvm


Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 vmx.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
index 4480752..c1833e1 100644
--- a/arch/x86/kvm/vmx.c
+++ b/arch/x86/kvm/vmx.c
@@ -606,7 +606,7 @@ static inline struct vcpu_vmx *to_vmx(struct kvm_vcpu *vcpu)
 	return container_of(vcpu, struct vcpu_vmx, vcpu);
 }
 
-struct pi_desc *vcpu_to_pi_desc(struct kvm_vcpu *vcpu)
+static struct pi_desc *vcpu_to_pi_desc(struct kvm_vcpu *vcpu)
 {
 	return &(to_vmx(vcpu)->pi_desc);
 }
@@ -10344,8 +10344,8 @@ static void vmx_enable_log_dirty_pt_masked(struct kvm *kvm,
  * @set: set or unset PI
  * returns 0 on success, < 0 on failure
  */
-int vmx_update_pi_irte(struct kvm *kvm, unsigned int host_irq,
-		       uint32_t guest_irq, bool set)
+static int vmx_update_pi_irte(struct kvm *kvm, unsigned int host_irq,
+			      uint32_t guest_irq, bool set)
 {
 	struct kvm_kernel_irq_routing_entry *e;
 	struct kvm_irq_routing_table *irq_rt;

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-09-25 13:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-25 13:18 [kvm:vtd-pi 34/38] arch/x86/kvm/vmx.c:609:16: sparse: symbol 'vcpu_to_pi_desc' was not declared. Should it be static? kbuild test robot
2015-09-25 13:18 ` [PATCH kvm] KVM: x86: vcpu_to_pi_desc() can be static kbuild test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox