Re: [kvm-unit-tests PATCH 2/6] mkstandalone: fix generation for arm

[Andrew Jones <drjones@redhat.com>]

On Tue, Jan 26, 2016 at 12:01:17PM +0100, Paolo Bonzini wrote:
> 
> 
> On 22/01/2016 15:58, Andrew Jones wrote:
> > The mkstandalone rewrite now packages the architecture run scripts.
> > This brings many benefits, but at the cost of no longer being able
> > to source additional files from the run script, at least not while
> > in standalone mode. We can live with that, but arm/run was sourcing
> > config.mak, so we need to stop that in standalone mode, as well as
> > to provide the standalone arm/run script what it needs.
> > 
> > Signed-off-by: Andrew Jones <drjones@redhat.com>
> > ---
> >  arm/run                 | 10 ++++++----
> >  scripts/mkstandalone.sh | 11 ++++++++++-
> >  2 files changed, 16 insertions(+), 5 deletions(-)
> > 
> > diff --git a/arm/run b/arm/run
> > index 4a648697d7fb5..0158ca5649a9f 100755
> > --- a/arm/run
> > +++ b/arm/run
> > @@ -1,10 +1,12 @@
> >  #!/bin/bash
> >  
> > -if [ ! -f config.mak ]; then
> > -	echo run ./configure first. See ./configure -h
> > -	exit 2
> > +if [ -z "$STANDALONE" ]; then
> 
> What do you think about checking:
> 
>     if [ "${ARCH:+set}" != set ]; then
> 
> instead?

That's a nice trick, but I sort of prefer the explicit STANDALONE
variable, and I see you already merged this version.

Thanks,
drew