public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: "Radim Krčmář" <rkrcmar@redhat.com>
To: Andrew Jones <drjones@redhat.com>
Cc: Thomas Huth <thuth@redhat.com>,
	kvm@vger.kernel.org, pbonzini@redhat.com, lvivier@redhat.com,
	andre.przywara@arm.com
Subject: Re: [kvm-unit-tests PATCH] report: introduce report_info
Date: Tue, 22 Nov 2016 14:32:51 +0100	[thread overview]
Message-ID: <20161122133250.GB12949@potion> (raw)
In-Reply-To: <20161118142658.qe4jo6lv35crmtmy@kamzik.brq.redhat.com>

2016-11-18 15:26+0100, Andrew Jones:
> On Fri, Nov 18, 2016 at 03:20:24PM +0100, Thomas Huth wrote:
>> On 18.11.2016 14:35, Andrew Jones wrote:
>> > Test writers sometimes want to output informational messages, but
>> > they don't want to use printf because they want the prefixes as
>> > well. Rather than creating "fake" tests that always pass, with
>> > report(fmt, true, ...), provide report_info(fmt, ...). This
>> > generates 'INFO: prefixes...: message'
>> > 
>> > While touching report code also add the lock to report_abort to
>> > ensure its output line integrity.
>> 
>> Since repor_abort() is a different topic, I'd suggest to move that hunk
>> into a different patch instead.
> 
> Yeah, I was being a big lazy there. I can respin with lazy-mode disabled,
> if you like, but I'll stay lazy just a little longer to see if Radim/Paolo
> take it as is :-)

I'd prefer two patches as well.  Laziness is good, though ...
If you stay lazy for more than a week from now, I'll apply v1 with a
note that we all agreed that this is not how patches should be split.

      reply	other threads:[~2016-11-22 13:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-18 13:35 [kvm-unit-tests PATCH] report: introduce report_info Andrew Jones
2016-11-18 14:20 ` Thomas Huth
2016-11-18 14:26   ` Andrew Jones
2016-11-22 13:32     ` Radim Krčmář [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161122133250.GB12949@potion \
    --to=rkrcmar@redhat.com \
    --cc=andre.przywara@arm.com \
    --cc=drjones@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=lvivier@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox