Kernel KVM virtualization development
 help / color / mirror / Atom feed
* [RFC] memory consumption of Qemu is twice as much as the previous version in KVM
@ 2017-05-22  7:04 Gonglei (Arei)
  2017-05-22  8:27 ` Paolo Bonzini
  0 siblings, 1 reply; 7+ messages in thread
From: Gonglei (Arei) @ 2017-05-22  7:04 UTC (permalink / raw)
  To: Paolo Bonzini; +Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org

Hi Paolo,

I found that the latest Qemu eat 2 time memory in KVM since Qemu-2.3.0.

Replication Steps:

1. I created a CentOS 7 with 4U8G using Qemu-2.3.0, 

# grep kvm_kvzalloc /proc/vmallocinfo | awk '{total+=$2}; END {print total}'
16932864
# grep kvm_kvzalloc /proc/vmallocinfo
0xffffc900205c7000-0xffffc90020fc8000 10489856 kvm_kvzalloc+0x3c/0x40 [kvm] pages=2560 vmalloc vpages N1=2560
0xffffc90020fc8000-0xffffc90020fce000   24576 kvm_kvzalloc+0x3c/0x40 [kvm] pages=5 vmalloc N1=5
0xffffc90020fce000-0xffffc90020fd4000   24576 kvm_kvzalloc+0x3c/0x40 [kvm] pages=5 vmalloc N1=5
0xffffc90020fd4000-0xffffc90020fd8000   16384 kvm_kvzalloc+0x3c/0x40 [kvm] pages=3 vmalloc N1=3
0xffffc9002438b000-0xffffc9002498c000 6295552 kvm_kvzalloc+0x3c/0x40 [kvm] pages=1536 vmalloc vpages N1=1536
0xffffc9002498c000-0xffffc90024990000   16384 kvm_kvzalloc+0x3c/0x40 [kvm] pages=3 vmalloc N1=3
0xffffc90024990000-0xffffc90024994000   16384 kvm_kvzalloc+0x3c/0x40 [kvm] pages=3 vmalloc N1=3
0xffffc90024994000-0xffffc90024997000   12288 kvm_kvzalloc+0x3c/0x40 [kvm] pages=2 vmalloc N1=2
0xffffc90024a75000-0xffffc90024a7e000   36864 kvm_kvzalloc+0x3c/0x40 [kvm] pages=8 vmalloc N1=8

PS: There is only this VM in my host.

2. Do the same test using the latest Qemu:

# grep kvm_kvzalloc /proc/vmallocinfo | awk '{total+=$2}; END {print total}'
33865728
linux-PsHdkO:~ # grep kvm_kvzalloc /proc/vmallocinfo 
0xffffc9001f181000-0xffffc9001fb82000 10489856 kvm_kvzalloc+0x25/0x30 [kvm] pages=2560 vmalloc vpages N1=2560
0xffffc9001fb82000-0xffffc9001fb88000   24576 kvm_kvzalloc+0x25/0x30 [kvm] pages=5 vmalloc N1=5
0xffffc9001fb88000-0xffffc9001fb8e000   24576 kvm_kvzalloc+0x25/0x30 [kvm] pages=5 vmalloc N1=5
0xffffc9001fb8e000-0xffffc9001fb92000   16384 kvm_kvzalloc+0x25/0x30 [kvm] pages=3 vmalloc N1=3
0xffffc90020854000-0xffffc90021255000 10489856 kvm_kvzalloc+0x25/0x30 [kvm] pages=2560 vmalloc vpages N1=2560
0xffffc90021255000-0xffffc9002125b000   24576 kvm_kvzalloc+0x25/0x30 [kvm] pages=5 vmalloc N1=5
0xffffc9002125b000-0xffffc90021261000   24576 kvm_kvzalloc+0x25/0x30 [kvm] pages=5 vmalloc N1=5
0xffffc90021261000-0xffffc90021265000   16384 kvm_kvzalloc+0x25/0x30 [kvm] pages=3 vmalloc N1=3
0xffffc9002616e000-0xffffc90026172000   16384 kvm_kvzalloc+0x25/0x30 [kvm] pages=3 vmalloc N1=3
0xffffc90026172000-0xffffc90026176000   16384 kvm_kvzalloc+0x25/0x30 [kvm] pages=3 vmalloc N1=3
0xffffc90026176000-0xffffc90026179000   12288 kvm_kvzalloc+0x25/0x30 [kvm] pages=2 vmalloc N1=2
0xffffc900261a9000-0xffffc900261ad000   16384 kvm_kvzalloc+0x25/0x30 [kvm] pages=3 vmalloc N1=3
0xffffc900261ad000-0xffffc900261b1000   16384 kvm_kvzalloc+0x25/0x30 [kvm] pages=3 vmalloc N1=3
0xffffc900261b1000-0xffffc900261b4000   12288 kvm_kvzalloc+0x25/0x30 [kvm] pages=2 vmalloc N1=2
0xffffc900280fe000-0xffffc900286ff000 6295552 kvm_kvzalloc+0x25/0x30 [kvm] pages=1536 vmalloc vpages N1=1536
0xffffc900286ff000-0xffffc90028d00000 6295552 kvm_kvzalloc+0x25/0x30 [kvm] pages=1536 vmalloc vpages N1=1536
0xffffc90028d87000-0xffffc90028d90000   36864 kvm_kvzalloc+0x25/0x30 [kvm] pages=8 vmalloc N1=8
0xffffc90028d9c000-0xffffc90028da5000   36864 kvm_kvzalloc+0x25/0x30 [kvm] pages=8 vmalloc N1=8


3. I found the first bad commit by 'git biscet'

linux-arei:/mnt/sdb/gonglei/opensource/qemu # git bisect bad
6410848bec38089424d54a6a8f10d4cf77182b5d is the first bad commit
commit 6410848bec38089424d54a6a8f10d4cf77182b5d
Author: Paolo Bonzini <pbonzini@redhat.com>
Date:   Thu Jun 18 18:30:16 2015 +0200

    target-i386: register a separate KVM address space including SMRAM regions
    
    Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

:040000 040000 b2435d7cd0829e6416b316f1ae2856e6f7b0023d 1acb81aecaf50f2d313b33f2b61a24f7f0bd6f07 M      target-i386
linux-PsHdkO:/mnt/sdb/gonglei/opensource/qemu #


Any ideas about this change? Do we really need to trigger two times memory region allocation?


Thanks,
-Gonglei

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [RFC] memory consumption of Qemu is twice as much as the previous version in KVM
  2017-05-22  7:04 [RFC] memory consumption of Qemu is twice as much as the previous version in KVM Gonglei (Arei)
@ 2017-05-22  8:27 ` Paolo Bonzini
  2017-05-22  8:32   ` [Qemu-devel] " Daniel P. Berrange
  0 siblings, 1 reply; 7+ messages in thread
From: Paolo Bonzini @ 2017-05-22  8:27 UTC (permalink / raw)
  To: Gonglei (Arei); +Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org



On 22/05/2017 09:04, Gonglei (Arei) wrote:
> Hi Paolo,
> 
> I found that the latest Qemu eat 2 time memory in KVM since Qemu-2.3.0.
> 
> Replication Steps:
> 
> 1. I created a CentOS 7 with 4U8G using Qemu-2.3.0, 
> 
> # grep kvm_kvzalloc /proc/vmallocinfo | awk '{total+=$2}; END {print total}'
> 16932864
> # grep kvm_kvzalloc /proc/vmallocinfo
> 0xffffc900205c7000-0xffffc90020fc8000 10489856 kvm_kvzalloc+0x3c/0x40 [kvm] pages=2560 vmalloc vpages N1=2560
> 0xffffc90020fc8000-0xffffc90020fce000   24576 kvm_kvzalloc+0x3c/0x40 [kvm] pages=5 vmalloc N1=5
> 0xffffc90020fce000-0xffffc90020fd4000   24576 kvm_kvzalloc+0x3c/0x40 [kvm] pages=5 vmalloc N1=5
> 0xffffc90020fd4000-0xffffc90020fd8000   16384 kvm_kvzalloc+0x3c/0x40 [kvm] pages=3 vmalloc N1=3
> 0xffffc9002438b000-0xffffc9002498c000 6295552 kvm_kvzalloc+0x3c/0x40 [kvm] pages=1536 vmalloc vpages N1=1536
> 0xffffc9002498c000-0xffffc90024990000   16384 kvm_kvzalloc+0x3c/0x40 [kvm] pages=3 vmalloc N1=3
> 0xffffc90024990000-0xffffc90024994000   16384 kvm_kvzalloc+0x3c/0x40 [kvm] pages=3 vmalloc N1=3
> 0xffffc90024994000-0xffffc90024997000   12288 kvm_kvzalloc+0x3c/0x40 [kvm] pages=2 vmalloc N1=2
> 0xffffc90024a75000-0xffffc90024a7e000   36864 kvm_kvzalloc+0x3c/0x40 [kvm] pages=8 vmalloc N1=8
> 
> PS: There is only this VM in my host.
> 
> 2. Do the same test using the latest Qemu:
> 
> # grep kvm_kvzalloc /proc/vmallocinfo | awk '{total+=$2}; END {print total}'
> 33865728
> linux-PsHdkO:~ # grep kvm_kvzalloc /proc/vmallocinfo 
> 0xffffc9001f181000-0xffffc9001fb82000 10489856 kvm_kvzalloc+0x25/0x30 [kvm] pages=2560 vmalloc vpages N1=2560
> 0xffffc9001fb82000-0xffffc9001fb88000   24576 kvm_kvzalloc+0x25/0x30 [kvm] pages=5 vmalloc N1=5
> 0xffffc9001fb88000-0xffffc9001fb8e000   24576 kvm_kvzalloc+0x25/0x30 [kvm] pages=5 vmalloc N1=5
> 0xffffc9001fb8e000-0xffffc9001fb92000   16384 kvm_kvzalloc+0x25/0x30 [kvm] pages=3 vmalloc N1=3
> 0xffffc90020854000-0xffffc90021255000 10489856 kvm_kvzalloc+0x25/0x30 [kvm] pages=2560 vmalloc vpages N1=2560
> 0xffffc90021255000-0xffffc9002125b000   24576 kvm_kvzalloc+0x25/0x30 [kvm] pages=5 vmalloc N1=5
> 0xffffc9002125b000-0xffffc90021261000   24576 kvm_kvzalloc+0x25/0x30 [kvm] pages=5 vmalloc N1=5
> 0xffffc90021261000-0xffffc90021265000   16384 kvm_kvzalloc+0x25/0x30 [kvm] pages=3 vmalloc N1=3
> 0xffffc9002616e000-0xffffc90026172000   16384 kvm_kvzalloc+0x25/0x30 [kvm] pages=3 vmalloc N1=3
> 0xffffc90026172000-0xffffc90026176000   16384 kvm_kvzalloc+0x25/0x30 [kvm] pages=3 vmalloc N1=3
> 0xffffc90026176000-0xffffc90026179000   12288 kvm_kvzalloc+0x25/0x30 [kvm] pages=2 vmalloc N1=2
> 0xffffc900261a9000-0xffffc900261ad000   16384 kvm_kvzalloc+0x25/0x30 [kvm] pages=3 vmalloc N1=3
> 0xffffc900261ad000-0xffffc900261b1000   16384 kvm_kvzalloc+0x25/0x30 [kvm] pages=3 vmalloc N1=3
> 0xffffc900261b1000-0xffffc900261b4000   12288 kvm_kvzalloc+0x25/0x30 [kvm] pages=2 vmalloc N1=2
> 0xffffc900280fe000-0xffffc900286ff000 6295552 kvm_kvzalloc+0x25/0x30 [kvm] pages=1536 vmalloc vpages N1=1536
> 0xffffc900286ff000-0xffffc90028d00000 6295552 kvm_kvzalloc+0x25/0x30 [kvm] pages=1536 vmalloc vpages N1=1536
> 0xffffc90028d87000-0xffffc90028d90000   36864 kvm_kvzalloc+0x25/0x30 [kvm] pages=8 vmalloc N1=8
> 0xffffc90028d9c000-0xffffc90028da5000   36864 kvm_kvzalloc+0x25/0x30 [kvm] pages=8 vmalloc N1=8
> 
> 
> 3. I found the first bad commit by 'git biscet'
> 
> linux-arei:/mnt/sdb/gonglei/opensource/qemu # git bisect bad
> 6410848bec38089424d54a6a8f10d4cf77182b5d is the first bad commit
> commit 6410848bec38089424d54a6a8f10d4cf77182b5d
> Author: Paolo Bonzini <pbonzini@redhat.com>
> Date:   Thu Jun 18 18:30:16 2015 +0200
> 
>     target-i386: register a separate KVM address space including SMRAM regions
>     
>     Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> 
> :040000 040000 b2435d7cd0829e6416b316f1ae2856e6f7b0023d 1acb81aecaf50f2d313b33f2b61a24f7f0bd6f07 M      target-i386
> linux-PsHdkO:/mnt/sdb/gonglei/opensource/qemu #
> 
> 
> Any ideas about this change? Do we really need to trigger two times memory region allocation?

We are registering two memory maps, so yes as long as "-machine smm=on"
is set.  We can skip the second address space if SMM is disabled.

Paolo

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [Qemu-devel] [RFC] memory consumption of Qemu is twice as much as the previous version in KVM
  2017-05-22  8:27 ` Paolo Bonzini
@ 2017-05-22  8:32   ` Daniel P. Berrange
  2017-05-22  8:40     ` Gonglei (Arei)
  2017-05-22  9:17     ` Paolo Bonzini
  0 siblings, 2 replies; 7+ messages in thread
From: Daniel P. Berrange @ 2017-05-22  8:32 UTC (permalink / raw)
  To: Paolo Bonzini; +Cc: Gonglei (Arei), qemu-devel@nongnu.org, kvm@vger.kernel.org

On Mon, May 22, 2017 at 10:27:59AM +0200, Paolo Bonzini wrote:
> 
> 
> On 22/05/2017 09:04, Gonglei (Arei) wrote:
> > Hi Paolo,
> > 
> > I found that the latest Qemu eat 2 time memory in KVM since Qemu-2.3.0.
> > 
> > Replication Steps:
> > 
> > 1. I created a CentOS 7 with 4U8G using Qemu-2.3.0, 
> > 
> > # grep kvm_kvzalloc /proc/vmallocinfo | awk '{total+=$2}; END {print total}'
> > 16932864
> > # grep kvm_kvzalloc /proc/vmallocinfo
> > 0xffffc900205c7000-0xffffc90020fc8000 10489856 kvm_kvzalloc+0x3c/0x40 [kvm] pages=2560 vmalloc vpages N1=2560
> > 0xffffc90020fc8000-0xffffc90020fce000   24576 kvm_kvzalloc+0x3c/0x40 [kvm] pages=5 vmalloc N1=5
> > 0xffffc90020fce000-0xffffc90020fd4000   24576 kvm_kvzalloc+0x3c/0x40 [kvm] pages=5 vmalloc N1=5
> > 0xffffc90020fd4000-0xffffc90020fd8000   16384 kvm_kvzalloc+0x3c/0x40 [kvm] pages=3 vmalloc N1=3
> > 0xffffc9002438b000-0xffffc9002498c000 6295552 kvm_kvzalloc+0x3c/0x40 [kvm] pages=1536 vmalloc vpages N1=1536
> > 0xffffc9002498c000-0xffffc90024990000   16384 kvm_kvzalloc+0x3c/0x40 [kvm] pages=3 vmalloc N1=3
> > 0xffffc90024990000-0xffffc90024994000   16384 kvm_kvzalloc+0x3c/0x40 [kvm] pages=3 vmalloc N1=3
> > 0xffffc90024994000-0xffffc90024997000   12288 kvm_kvzalloc+0x3c/0x40 [kvm] pages=2 vmalloc N1=2
> > 0xffffc90024a75000-0xffffc90024a7e000   36864 kvm_kvzalloc+0x3c/0x40 [kvm] pages=8 vmalloc N1=8
> > 
> > PS: There is only this VM in my host.
> > 
> > 2. Do the same test using the latest Qemu:
> > 
> > # grep kvm_kvzalloc /proc/vmallocinfo | awk '{total+=$2}; END {print total}'
> > 33865728
> > linux-PsHdkO:~ # grep kvm_kvzalloc /proc/vmallocinfo 
> > 0xffffc9001f181000-0xffffc9001fb82000 10489856 kvm_kvzalloc+0x25/0x30 [kvm] pages=2560 vmalloc vpages N1=2560
> > 0xffffc9001fb82000-0xffffc9001fb88000   24576 kvm_kvzalloc+0x25/0x30 [kvm] pages=5 vmalloc N1=5
> > 0xffffc9001fb88000-0xffffc9001fb8e000   24576 kvm_kvzalloc+0x25/0x30 [kvm] pages=5 vmalloc N1=5
> > 0xffffc9001fb8e000-0xffffc9001fb92000   16384 kvm_kvzalloc+0x25/0x30 [kvm] pages=3 vmalloc N1=3
> > 0xffffc90020854000-0xffffc90021255000 10489856 kvm_kvzalloc+0x25/0x30 [kvm] pages=2560 vmalloc vpages N1=2560
> > 0xffffc90021255000-0xffffc9002125b000   24576 kvm_kvzalloc+0x25/0x30 [kvm] pages=5 vmalloc N1=5
> > 0xffffc9002125b000-0xffffc90021261000   24576 kvm_kvzalloc+0x25/0x30 [kvm] pages=5 vmalloc N1=5
> > 0xffffc90021261000-0xffffc90021265000   16384 kvm_kvzalloc+0x25/0x30 [kvm] pages=3 vmalloc N1=3
> > 0xffffc9002616e000-0xffffc90026172000   16384 kvm_kvzalloc+0x25/0x30 [kvm] pages=3 vmalloc N1=3
> > 0xffffc90026172000-0xffffc90026176000   16384 kvm_kvzalloc+0x25/0x30 [kvm] pages=3 vmalloc N1=3
> > 0xffffc90026176000-0xffffc90026179000   12288 kvm_kvzalloc+0x25/0x30 [kvm] pages=2 vmalloc N1=2
> > 0xffffc900261a9000-0xffffc900261ad000   16384 kvm_kvzalloc+0x25/0x30 [kvm] pages=3 vmalloc N1=3
> > 0xffffc900261ad000-0xffffc900261b1000   16384 kvm_kvzalloc+0x25/0x30 [kvm] pages=3 vmalloc N1=3
> > 0xffffc900261b1000-0xffffc900261b4000   12288 kvm_kvzalloc+0x25/0x30 [kvm] pages=2 vmalloc N1=2
> > 0xffffc900280fe000-0xffffc900286ff000 6295552 kvm_kvzalloc+0x25/0x30 [kvm] pages=1536 vmalloc vpages N1=1536
> > 0xffffc900286ff000-0xffffc90028d00000 6295552 kvm_kvzalloc+0x25/0x30 [kvm] pages=1536 vmalloc vpages N1=1536
> > 0xffffc90028d87000-0xffffc90028d90000   36864 kvm_kvzalloc+0x25/0x30 [kvm] pages=8 vmalloc N1=8
> > 0xffffc90028d9c000-0xffffc90028da5000   36864 kvm_kvzalloc+0x25/0x30 [kvm] pages=8 vmalloc N1=8
> > 
> > 
> > 3. I found the first bad commit by 'git biscet'
> > 
> > linux-arei:/mnt/sdb/gonglei/opensource/qemu # git bisect bad
> > 6410848bec38089424d54a6a8f10d4cf77182b5d is the first bad commit
> > commit 6410848bec38089424d54a6a8f10d4cf77182b5d
> > Author: Paolo Bonzini <pbonzini@redhat.com>
> > Date:   Thu Jun 18 18:30:16 2015 +0200
> > 
> >     target-i386: register a separate KVM address space including SMRAM regions
> >     
> >     Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> > 
> > :040000 040000 b2435d7cd0829e6416b316f1ae2856e6f7b0023d 1acb81aecaf50f2d313b33f2b61a24f7f0bd6f07 M      target-i386
> > linux-PsHdkO:/mnt/sdb/gonglei/opensource/qemu #
> > 
> > 
> > Any ideas about this change? Do we really need to trigger two times memory region allocation?
> 
> We are registering two memory maps, so yes as long as "-machine smm=on"
> is set.  We can skip the second address space if SMM is disabled.

Am I right in thinking that it is just causing the same memory allocation
to be mapped twice at different addresses, not actually allocating double
the amount of memory ?

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

^ permalink raw reply	[flat|nested] 7+ messages in thread

* RE: [Qemu-devel] [RFC] memory consumption of Qemu is twice as much as the previous version in KVM
  2017-05-22  8:32   ` [Qemu-devel] " Daniel P. Berrange
@ 2017-05-22  8:40     ` Gonglei (Arei)
  2017-05-22  9:17     ` Paolo Bonzini
  1 sibling, 0 replies; 7+ messages in thread
From: Gonglei (Arei) @ 2017-05-22  8:40 UTC (permalink / raw)
  To: Daniel P. Berrange, Paolo Bonzini
  Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org


> -----Original Message-----
> From: kvm-owner@vger.kernel.org [mailto:kvm-owner@vger.kernel.org] On
> Behalf Of Daniel P. Berrange
> Sent: Monday, May 22, 2017 4:32 PM
> To: Paolo Bonzini
> Cc: Gonglei (Arei); qemu-devel@nongnu.org; kvm@vger.kernel.org
> Subject: Re: [Qemu-devel] [RFC] memory consumption of Qemu is twice as
> much as the previous version in KVM
> 
> On Mon, May 22, 2017 at 10:27:59AM +0200, Paolo Bonzini wrote:
> >
> >
> > On 22/05/2017 09:04, Gonglei (Arei) wrote:
> > > Hi Paolo,
> > >
> > > I found that the latest Qemu eat 2 time memory in KVM since Qemu-2.3.0.
> > >
> > > Replication Steps:
> > >
> > > 1. I created a CentOS 7 with 4U8G using Qemu-2.3.0,
> > >
> > > # grep kvm_kvzalloc /proc/vmallocinfo | awk '{total+=$2}; END {print total}'
> > > 16932864
> > > # grep kvm_kvzalloc /proc/vmallocinfo
> > > 0xffffc900205c7000-0xffffc90020fc8000 10489856 kvm_kvzalloc+0x3c/0x40
> [kvm] pages=2560 vmalloc vpages N1=2560
> > > 0xffffc90020fc8000-0xffffc90020fce000   24576 kvm_kvzalloc+0x3c/0x40
> [kvm] pages=5 vmalloc N1=5
> > > 0xffffc90020fce000-0xffffc90020fd4000   24576 kvm_kvzalloc+0x3c/0x40
> [kvm] pages=5 vmalloc N1=5
> > > 0xffffc90020fd4000-0xffffc90020fd8000   16384 kvm_kvzalloc+0x3c/0x40
> [kvm] pages=3 vmalloc N1=3
> > > 0xffffc9002438b000-0xffffc9002498c000 6295552 kvm_kvzalloc+0x3c/0x40
> [kvm] pages=1536 vmalloc vpages N1=1536
> > > 0xffffc9002498c000-0xffffc90024990000   16384 kvm_kvzalloc+0x3c/0x40
> [kvm] pages=3 vmalloc N1=3
> > > 0xffffc90024990000-0xffffc90024994000   16384 kvm_kvzalloc+0x3c/0x40
> [kvm] pages=3 vmalloc N1=3
> > > 0xffffc90024994000-0xffffc90024997000   12288 kvm_kvzalloc+0x3c/0x40
> [kvm] pages=2 vmalloc N1=2
> > > 0xffffc90024a75000-0xffffc90024a7e000   36864 kvm_kvzalloc+0x3c/0x40
> [kvm] pages=8 vmalloc N1=8
> > >
> > > PS: There is only this VM in my host.
> > >
> > > 2. Do the same test using the latest Qemu:
> > >
> > > # grep kvm_kvzalloc /proc/vmallocinfo | awk '{total+=$2}; END {print total}'
> > > 33865728
> > > linux-PsHdkO:~ # grep kvm_kvzalloc /proc/vmallocinfo
> > > 0xffffc9001f181000-0xffffc9001fb82000 10489856 kvm_kvzalloc+0x25/0x30
> [kvm] pages=2560 vmalloc vpages N1=2560
> > > 0xffffc9001fb82000-0xffffc9001fb88000   24576 kvm_kvzalloc+0x25/0x30
> [kvm] pages=5 vmalloc N1=5
> > > 0xffffc9001fb88000-0xffffc9001fb8e000   24576 kvm_kvzalloc+0x25/0x30
> [kvm] pages=5 vmalloc N1=5
> > > 0xffffc9001fb8e000-0xffffc9001fb92000   16384 kvm_kvzalloc+0x25/0x30
> [kvm] pages=3 vmalloc N1=3
> > > 0xffffc90020854000-0xffffc90021255000 10489856
> kvm_kvzalloc+0x25/0x30 [kvm] pages=2560 vmalloc vpages N1=2560
> > > 0xffffc90021255000-0xffffc9002125b000   24576 kvm_kvzalloc+0x25/0x30
> [kvm] pages=5 vmalloc N1=5
> > > 0xffffc9002125b000-0xffffc90021261000   24576 kvm_kvzalloc+0x25/0x30
> [kvm] pages=5 vmalloc N1=5
> > > 0xffffc90021261000-0xffffc90021265000   16384 kvm_kvzalloc+0x25/0x30
> [kvm] pages=3 vmalloc N1=3
> > > 0xffffc9002616e000-0xffffc90026172000   16384 kvm_kvzalloc+0x25/0x30
> [kvm] pages=3 vmalloc N1=3
> > > 0xffffc90026172000-0xffffc90026176000   16384 kvm_kvzalloc+0x25/0x30
> [kvm] pages=3 vmalloc N1=3
> > > 0xffffc90026176000-0xffffc90026179000   12288 kvm_kvzalloc+0x25/0x30
> [kvm] pages=2 vmalloc N1=2
> > > 0xffffc900261a9000-0xffffc900261ad000   16384 kvm_kvzalloc+0x25/0x30
> [kvm] pages=3 vmalloc N1=3
> > > 0xffffc900261ad000-0xffffc900261b1000   16384 kvm_kvzalloc+0x25/0x30
> [kvm] pages=3 vmalloc N1=3
> > > 0xffffc900261b1000-0xffffc900261b4000   12288 kvm_kvzalloc+0x25/0x30
> [kvm] pages=2 vmalloc N1=2
> > > 0xffffc900280fe000-0xffffc900286ff000 6295552 kvm_kvzalloc+0x25/0x30
> [kvm] pages=1536 vmalloc vpages N1=1536
> > > 0xffffc900286ff000-0xffffc90028d00000 6295552 kvm_kvzalloc+0x25/0x30
> [kvm] pages=1536 vmalloc vpages N1=1536
> > > 0xffffc90028d87000-0xffffc90028d90000   36864 kvm_kvzalloc+0x25/0x30
> [kvm] pages=8 vmalloc N1=8
> > > 0xffffc90028d9c000-0xffffc90028da5000   36864 kvm_kvzalloc+0x25/0x30
> [kvm] pages=8 vmalloc N1=8
> > >
> > >
> > > 3. I found the first bad commit by 'git biscet'
> > >
> > > linux-arei:/mnt/sdb/gonglei/opensource/qemu # git bisect bad
> > > 6410848bec38089424d54a6a8f10d4cf77182b5d is the first bad commit
> > > commit 6410848bec38089424d54a6a8f10d4cf77182b5d
> > > Author: Paolo Bonzini <pbonzini@redhat.com>
> > > Date:   Thu Jun 18 18:30:16 2015 +0200
> > >
> > >     target-i386: register a separate KVM address space including SMRAM
> regions
> > >
> > >     Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> > >
> > > :040000 040000 b2435d7cd0829e6416b316f1ae2856e6f7b0023d
> 1acb81aecaf50f2d313b33f2b61a24f7f0bd6f07 M      target-i386
> > > linux-PsHdkO:/mnt/sdb/gonglei/opensource/qemu #
> > >
> > >
> > > Any ideas about this change? Do we really need to trigger two times
> memory region allocation?
> >
> > We are registering two memory maps, so yes as long as "-machine smm=on"
> > is set.  We can skip the second address space if SMM is disabled.
> 
Sorry, I don't know much about SMM, do we have to register two memory maps to 
enable it?

> Am I right in thinking that it is just causing the same memory allocation
> to be mapped twice at different addresses, not actually allocating double
> the amount of memory ?
> 
No, it occupies physical memory in actually, and you can see different hva and pages
in above kvm_kvzalloc.

Thanks,
-Gonglei
 

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [Qemu-devel] [RFC] memory consumption of Qemu is twice as much as the previous version in KVM
  2017-05-22  8:32   ` [Qemu-devel] " Daniel P. Berrange
  2017-05-22  8:40     ` Gonglei (Arei)
@ 2017-05-22  9:17     ` Paolo Bonzini
  2017-05-22 15:11       ` Gonglei (Arei)
  1 sibling, 1 reply; 7+ messages in thread
From: Paolo Bonzini @ 2017-05-22  9:17 UTC (permalink / raw)
  To: Daniel P. Berrange
  Cc: Gonglei (Arei), qemu-devel@nongnu.org, kvm@vger.kernel.org

On 22/05/2017 10:32, Daniel P. Berrange wrote:
> On Mon, May 22, 2017 at 10:27:59AM +0200, Paolo Bonzini wrote:
>>
>>
>> On 22/05/2017 09:04, Gonglei (Arei) wrote:
>>> Hi Paolo,
>>>
>>> I found that the latest Qemu eat 2 time memory in KVM since Qemu-2.3.0.
>>>
>>> Replication Steps:
>>>
>>> 1. I created a CentOS 7 with 4U8G using Qemu-2.3.0, 
>>>
>>> # grep kvm_kvzalloc /proc/vmallocinfo | awk '{total+=$2}; END {print total}'
>>> 16932864
>>> # grep kvm_kvzalloc /proc/vmallocinfo
>>> 0xffffc900205c7000-0xffffc90020fc8000 10489856 kvm_kvzalloc+0x3c/0x40 [kvm] pages=2560 vmalloc vpages N1=2560
>>> 0xffffc90020fc8000-0xffffc90020fce000   24576 kvm_kvzalloc+0x3c/0x40 [kvm] pages=5 vmalloc N1=5
>>> 0xffffc90020fce000-0xffffc90020fd4000   24576 kvm_kvzalloc+0x3c/0x40 [kvm] pages=5 vmalloc N1=5
>>> 0xffffc90020fd4000-0xffffc90020fd8000   16384 kvm_kvzalloc+0x3c/0x40 [kvm] pages=3 vmalloc N1=3
>>> 0xffffc9002438b000-0xffffc9002498c000 6295552 kvm_kvzalloc+0x3c/0x40 [kvm] pages=1536 vmalloc vpages N1=1536
>>> 0xffffc9002498c000-0xffffc90024990000   16384 kvm_kvzalloc+0x3c/0x40 [kvm] pages=3 vmalloc N1=3
>>> 0xffffc90024990000-0xffffc90024994000   16384 kvm_kvzalloc+0x3c/0x40 [kvm] pages=3 vmalloc N1=3
>>> 0xffffc90024994000-0xffffc90024997000   12288 kvm_kvzalloc+0x3c/0x40 [kvm] pages=2 vmalloc N1=2
>>> 0xffffc90024a75000-0xffffc90024a7e000   36864 kvm_kvzalloc+0x3c/0x40 [kvm] pages=8 vmalloc N1=8
>>>
>>> PS: There is only this VM in my host.
>>>
>>> 2. Do the same test using the latest Qemu:
>>>
>>> # grep kvm_kvzalloc /proc/vmallocinfo | awk '{total+=$2}; END {print total}'
>>> 33865728
>>> linux-PsHdkO:~ # grep kvm_kvzalloc /proc/vmallocinfo 
>>> 0xffffc9001f181000-0xffffc9001fb82000 10489856 kvm_kvzalloc+0x25/0x30 [kvm] pages=2560 vmalloc vpages N1=2560
>>> 0xffffc9001fb82000-0xffffc9001fb88000   24576 kvm_kvzalloc+0x25/0x30 [kvm] pages=5 vmalloc N1=5
>>> 0xffffc9001fb88000-0xffffc9001fb8e000   24576 kvm_kvzalloc+0x25/0x30 [kvm] pages=5 vmalloc N1=5
>>> 0xffffc9001fb8e000-0xffffc9001fb92000   16384 kvm_kvzalloc+0x25/0x30 [kvm] pages=3 vmalloc N1=3
>>> 0xffffc90020854000-0xffffc90021255000 10489856 kvm_kvzalloc+0x25/0x30 [kvm] pages=2560 vmalloc vpages N1=2560
>>> 0xffffc90021255000-0xffffc9002125b000   24576 kvm_kvzalloc+0x25/0x30 [kvm] pages=5 vmalloc N1=5
>>> 0xffffc9002125b000-0xffffc90021261000   24576 kvm_kvzalloc+0x25/0x30 [kvm] pages=5 vmalloc N1=5
>>> 0xffffc90021261000-0xffffc90021265000   16384 kvm_kvzalloc+0x25/0x30 [kvm] pages=3 vmalloc N1=3
>>> 0xffffc9002616e000-0xffffc90026172000   16384 kvm_kvzalloc+0x25/0x30 [kvm] pages=3 vmalloc N1=3
>>> 0xffffc90026172000-0xffffc90026176000   16384 kvm_kvzalloc+0x25/0x30 [kvm] pages=3 vmalloc N1=3
>>> 0xffffc90026176000-0xffffc90026179000   12288 kvm_kvzalloc+0x25/0x30 [kvm] pages=2 vmalloc N1=2
>>> 0xffffc900261a9000-0xffffc900261ad000   16384 kvm_kvzalloc+0x25/0x30 [kvm] pages=3 vmalloc N1=3
>>> 0xffffc900261ad000-0xffffc900261b1000   16384 kvm_kvzalloc+0x25/0x30 [kvm] pages=3 vmalloc N1=3
>>> 0xffffc900261b1000-0xffffc900261b4000   12288 kvm_kvzalloc+0x25/0x30 [kvm] pages=2 vmalloc N1=2
>>> 0xffffc900280fe000-0xffffc900286ff000 6295552 kvm_kvzalloc+0x25/0x30 [kvm] pages=1536 vmalloc vpages N1=1536
>>> 0xffffc900286ff000-0xffffc90028d00000 6295552 kvm_kvzalloc+0x25/0x30 [kvm] pages=1536 vmalloc vpages N1=1536
>>> 0xffffc90028d87000-0xffffc90028d90000   36864 kvm_kvzalloc+0x25/0x30 [kvm] pages=8 vmalloc N1=8
>>> 0xffffc90028d9c000-0xffffc90028da5000   36864 kvm_kvzalloc+0x25/0x30 [kvm] pages=8 vmalloc N1=8
>>>
>>>
>>> 3. I found the first bad commit by 'git biscet'
>>>
>>> linux-arei:/mnt/sdb/gonglei/opensource/qemu # git bisect bad
>>> 6410848bec38089424d54a6a8f10d4cf77182b5d is the first bad commit
>>> commit 6410848bec38089424d54a6a8f10d4cf77182b5d
>>> Author: Paolo Bonzini <pbonzini@redhat.com>
>>> Date:   Thu Jun 18 18:30:16 2015 +0200
>>>
>>>     target-i386: register a separate KVM address space including SMRAM regions
>>>     
>>>     Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>>>
>>> :040000 040000 b2435d7cd0829e6416b316f1ae2856e6f7b0023d 1acb81aecaf50f2d313b33f2b61a24f7f0bd6f07 M      target-i386
>>> linux-PsHdkO:/mnt/sdb/gonglei/opensource/qemu #
>>>
>>>
>>> Any ideas about this change? Do we really need to trigger two times memory region allocation?
>>
>> We are registering two memory maps, so yes as long as "-machine smm=on"
>> is set.  We can skip the second address space if SMM is disabled.
> 
> Am I right in thinking that it is just causing the same memory allocation
> to be mapped twice at different addresses, not actually allocating double
> the amount of memory ?

These are kernel allocations done by KVM when it gets the
KVM_SET_USER_MEMORY_REGION ioctl; of course the two memory maps point to
the same userspace mmap-ed area.

Thanks,

Paolo

^ permalink raw reply	[flat|nested] 7+ messages in thread

* RE: [Qemu-devel] [RFC] memory consumption of Qemu is twice as much as the previous version in KVM
  2017-05-22  9:17     ` Paolo Bonzini
@ 2017-05-22 15:11       ` Gonglei (Arei)
  2017-05-22 15:30         ` Paolo Bonzini
  0 siblings, 1 reply; 7+ messages in thread
From: Gonglei (Arei) @ 2017-05-22 15:11 UTC (permalink / raw)
  To: Paolo Bonzini, Daniel P. Berrange
  Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org


> -----Original Message-----
> From: Paolo Bonzini [mailto:paolo.bonzini@gmail.com] On Behalf Of Paolo
> Bonzini
> Sent: Monday, May 22, 2017 5:17 PM
> To: Daniel P. Berrange
> Cc: Gonglei (Arei); qemu-devel@nongnu.org; kvm@vger.kernel.org
> Subject: Re: [Qemu-devel] [RFC] memory consumption of Qemu is twice as
> much as the previous version in KVM
> 
> On 22/05/2017 10:32, Daniel P. Berrange wrote:
> > On Mon, May 22, 2017 at 10:27:59AM +0200, Paolo Bonzini wrote:
> >>
> >>
> >> On 22/05/2017 09:04, Gonglei (Arei) wrote:
> >>> Hi Paolo,
> >>>
> >>> I found that the latest Qemu eat 2 time memory in KVM since Qemu-2.3.0.
> >>>
> >>> Replication Steps:
> >>>
> >>> 1. I created a CentOS 7 with 4U8G using Qemu-2.3.0,
> >>>
> >>> # grep kvm_kvzalloc /proc/vmallocinfo | awk '{total+=$2}; END {print total}'
> >>> 16932864
> >>> # grep kvm_kvzalloc /proc/vmallocinfo
> >>> 0xffffc900205c7000-0xffffc90020fc8000 10489856 kvm_kvzalloc+0x3c/0x40
> [kvm] pages=2560 vmalloc vpages N1=2560
> >>> 0xffffc90020fc8000-0xffffc90020fce000   24576 kvm_kvzalloc+0x3c/0x40
> [kvm] pages=5 vmalloc N1=5
> >>> 0xffffc90020fce000-0xffffc90020fd4000   24576 kvm_kvzalloc+0x3c/0x40
> [kvm] pages=5 vmalloc N1=5
> >>> 0xffffc90020fd4000-0xffffc90020fd8000   16384 kvm_kvzalloc+0x3c/0x40
> [kvm] pages=3 vmalloc N1=3
> >>> 0xffffc9002438b000-0xffffc9002498c000 6295552 kvm_kvzalloc+0x3c/0x40
> [kvm] pages=1536 vmalloc vpages N1=1536
> >>> 0xffffc9002498c000-0xffffc90024990000   16384 kvm_kvzalloc+0x3c/0x40
> [kvm] pages=3 vmalloc N1=3
> >>> 0xffffc90024990000-0xffffc90024994000   16384
> kvm_kvzalloc+0x3c/0x40 [kvm] pages=3 vmalloc N1=3
> >>> 0xffffc90024994000-0xffffc90024997000   12288
> kvm_kvzalloc+0x3c/0x40 [kvm] pages=2 vmalloc N1=2
> >>> 0xffffc90024a75000-0xffffc90024a7e000   36864
> kvm_kvzalloc+0x3c/0x40 [kvm] pages=8 vmalloc N1=8
> >>>
> >>> PS: There is only this VM in my host.
> >>>
> >>> 2. Do the same test using the latest Qemu:
> >>>
> >>> # grep kvm_kvzalloc /proc/vmallocinfo | awk '{total+=$2}; END {print total}'
> >>> 33865728
> >>> linux-PsHdkO:~ # grep kvm_kvzalloc /proc/vmallocinfo
> >>> 0xffffc9001f181000-0xffffc9001fb82000 10489856 kvm_kvzalloc+0x25/0x30
> [kvm] pages=2560 vmalloc vpages N1=2560
> >>> 0xffffc9001fb82000-0xffffc9001fb88000   24576 kvm_kvzalloc+0x25/0x30
> [kvm] pages=5 vmalloc N1=5
> >>> 0xffffc9001fb88000-0xffffc9001fb8e000   24576 kvm_kvzalloc+0x25/0x30
> [kvm] pages=5 vmalloc N1=5
> >>> 0xffffc9001fb8e000-0xffffc9001fb92000   16384 kvm_kvzalloc+0x25/0x30
> [kvm] pages=3 vmalloc N1=3
> >>> 0xffffc90020854000-0xffffc90021255000 10489856
> kvm_kvzalloc+0x25/0x30 [kvm] pages=2560 vmalloc vpages N1=2560
> >>> 0xffffc90021255000-0xffffc9002125b000   24576
> kvm_kvzalloc+0x25/0x30 [kvm] pages=5 vmalloc N1=5
> >>> 0xffffc9002125b000-0xffffc90021261000   24576
> kvm_kvzalloc+0x25/0x30 [kvm] pages=5 vmalloc N1=5
> >>> 0xffffc90021261000-0xffffc90021265000   16384
> kvm_kvzalloc+0x25/0x30 [kvm] pages=3 vmalloc N1=3
> >>> 0xffffc9002616e000-0xffffc90026172000   16384
> kvm_kvzalloc+0x25/0x30 [kvm] pages=3 vmalloc N1=3
> >>> 0xffffc90026172000-0xffffc90026176000   16384
> kvm_kvzalloc+0x25/0x30 [kvm] pages=3 vmalloc N1=3
> >>> 0xffffc90026176000-0xffffc90026179000   12288
> kvm_kvzalloc+0x25/0x30 [kvm] pages=2 vmalloc N1=2
> >>> 0xffffc900261a9000-0xffffc900261ad000   16384
> kvm_kvzalloc+0x25/0x30 [kvm] pages=3 vmalloc N1=3
> >>> 0xffffc900261ad000-0xffffc900261b1000   16384
> kvm_kvzalloc+0x25/0x30 [kvm] pages=3 vmalloc N1=3
> >>> 0xffffc900261b1000-0xffffc900261b4000   12288
> kvm_kvzalloc+0x25/0x30 [kvm] pages=2 vmalloc N1=2
> >>> 0xffffc900280fe000-0xffffc900286ff000 6295552 kvm_kvzalloc+0x25/0x30
> [kvm] pages=1536 vmalloc vpages N1=1536
> >>> 0xffffc900286ff000-0xffffc90028d00000 6295552 kvm_kvzalloc+0x25/0x30
> [kvm] pages=1536 vmalloc vpages N1=1536
> >>> 0xffffc90028d87000-0xffffc90028d90000   36864
> kvm_kvzalloc+0x25/0x30 [kvm] pages=8 vmalloc N1=8
> >>> 0xffffc90028d9c000-0xffffc90028da5000   36864
> kvm_kvzalloc+0x25/0x30 [kvm] pages=8 vmalloc N1=8
> >>>
> >>>
> >>> 3. I found the first bad commit by 'git biscet'
> >>>
> >>> linux-arei:/mnt/sdb/gonglei/opensource/qemu # git bisect bad
> >>> 6410848bec38089424d54a6a8f10d4cf77182b5d is the first bad commit
> >>> commit 6410848bec38089424d54a6a8f10d4cf77182b5d
> >>> Author: Paolo Bonzini <pbonzini@redhat.com>
> >>> Date:   Thu Jun 18 18:30:16 2015 +0200
> >>>
> >>>     target-i386: register a separate KVM address space including
> SMRAM regions
> >>>
> >>>     Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> >>>
> >>> :040000 040000 b2435d7cd0829e6416b316f1ae2856e6f7b0023d
> 1acb81aecaf50f2d313b33f2b61a24f7f0bd6f07 M      target-i386
> >>> linux-PsHdkO:/mnt/sdb/gonglei/opensource/qemu #
> >>>
> >>>
> >>> Any ideas about this change? Do we really need to trigger two times
> memory region allocation?
> >>
> >> We are registering two memory maps, so yes as long as "-machine
> smm=on"
> >> is set.  We can skip the second address space if SMM is disabled.
> >
> > Am I right in thinking that it is just causing the same memory allocation
> > to be mapped twice at different addresses, not actually allocating double
> > the amount of memory ?
> 
> These are kernel allocations done by KVM when it gets the
> KVM_SET_USER_MEMORY_REGION ioctl; of course the two memory maps
> point to
> the same userspace mmap-ed area.
> 
Oh? What's the mmapd-ed area you pointed?
If the KVM allocate memory by vmalloc(), then it will occupy physical
memory (non physically contiguous memory) IMO.

We can get the information from /proc/meminfo:

# cat /proc/meminfo |grep Vmalloc     
VmallocTotal:   34359738367 kB
VmallocUsed:      532796 kB
VmallocChunk:   34292018200 kB

So I think this part of memory is double after that SMM commit. Right?

Thanks,
-Gonglei


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [Qemu-devel] [RFC] memory consumption of Qemu is twice as much as the previous version in KVM
  2017-05-22 15:11       ` Gonglei (Arei)
@ 2017-05-22 15:30         ` Paolo Bonzini
  0 siblings, 0 replies; 7+ messages in thread
From: Paolo Bonzini @ 2017-05-22 15:30 UTC (permalink / raw)
  To: Gonglei (Arei), Daniel P. Berrange
  Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org



On 22/05/2017 17:11, Gonglei (Arei) wrote:
>> These are kernel allocations done by KVM when it gets the
>> KVM_SET_USER_MEMORY_REGION ioctl; of course the two memory maps
>> point to
>> the same userspace mmap-ed area.
>
> Oh? What's the mmapd-ed area you pointed?

I mean the MAP_ANON pages that back the guest memory.

> If the KVM allocate memory by vmalloc(), then it will occupy physical
> memory (non physically contiguous memory) IMO.
> 
> We can get the information from /proc/meminfo:
> 
> # cat /proc/meminfo |grep Vmalloc     
> VmallocTotal:   34359738367 kB
> VmallocUsed:      532796 kB
> VmallocChunk:   34292018200 kB
> 
> So I think this part of memory is double after that SMM commit. Right?

Yes.

Paolo

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2017-05-22 15:30 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-22  7:04 [RFC] memory consumption of Qemu is twice as much as the previous version in KVM Gonglei (Arei)
2017-05-22  8:27 ` Paolo Bonzini
2017-05-22  8:32   ` [Qemu-devel] " Daniel P. Berrange
2017-05-22  8:40     ` Gonglei (Arei)
2017-05-22  9:17     ` Paolo Bonzini
2017-05-22 15:11       ` Gonglei (Arei)
2017-05-22 15:30         ` Paolo Bonzini

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox