From: Alex Williamson <alex.williamson@redhat.com>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: b.reynal@virtualopensystems.com, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org
Subject: Re: [PATCH] vfio: platform: constify amba_id
Date: Wed, 30 Aug 2017 15:24:36 -0600 [thread overview]
Message-ID: <20170830152436.7a06373a@w520.home> (raw)
In-Reply-To: <d055db1ba7813edb095992f938c8d41e7e1c0ebb.1503508563.git.arvind.yadav.cs@gmail.com>
On Wed, 23 Aug 2017 22:47:15 +0530
Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:
> amba_id are not supposed to change at runtime. All functions
> working with const amba_id. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> drivers/vfio/platform/vfio_amba.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/vfio/platform/vfio_amba.c b/drivers/vfio/platform/vfio_amba.c
> index 31372fb..62dfbfe 100644
> --- a/drivers/vfio/platform/vfio_amba.c
> +++ b/drivers/vfio/platform/vfio_amba.c
> @@ -93,7 +93,7 @@ static int vfio_amba_remove(struct amba_device *adev)
> return -EINVAL;
> }
>
> -static struct amba_id pl330_ids[] = {
> +static const struct amba_id pl330_ids[] = {
> { 0, 0 },
> };
>
Applied to next branch for v4.14. Thanks,
Alex
prev parent reply other threads:[~2017-08-30 21:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-23 17:17 [PATCH] vfio: platform: constify amba_id Arvind Yadav
2017-08-30 21:24 ` Alex Williamson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170830152436.7a06373a@w520.home \
--to=alex.williamson@redhat.com \
--cc=arvind.yadav.cs@gmail.com \
--cc=b.reynal@virtualopensystems.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox