From: "Radim Krčmář" <rkrcmar@redhat.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Juergen Gross <jgross@suse.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: add X86_LOCAL_APIC dependency
Date: Thu, 5 Oct 2017 20:01:10 +0200 [thread overview]
Message-ID: <20171005180107.GJ21107@flask> (raw)
In-Reply-To: <20171004102823.1887173-1-arnd@arndb.de>
2017-10-04 12:28+0200, Arnd Bergmann:
> The rework of the posted interrupt handling broke building without
> support for the local APIC:
>
> ERROR: "boot_cpu_physical_apicid" [arch/x86/kvm/kvm-intel.ko] undefined!
>
> That configuration is probably not particularly useful anyway, so
> we can avoid the randconfig failures by adding a Kconfig dependency.
Yeah, and we can follow up by removing few ifdefs.
> Fixes: 8b306e2f3c41 ("KVM: VMX: avoid double list add with VT-d posted interrupts")
The offending cpu_physical_id() was there even before, so it is probably
the change of condition in pi_post_block that violated dead code
detection.
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
Applied, thanks.
prev parent reply other threads:[~2017-10-05 18:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-04 10:28 [PATCH] KVM: add X86_LOCAL_APIC dependency Arnd Bergmann
2017-10-05 18:01 ` Radim Krčmář [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171005180107.GJ21107@flask \
--to=rkrcmar@redhat.com \
--cc=arnd@arndb.de \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox