public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Stefan Raspl <raspl@linux.vnet.ibm.com>
To: kvm@vger.kernel.org
Cc: pbonzini@redhat.com, rkrcmar@redhat.com, frankja@linux.vnet.ibm.com
Subject: [PATCH 0/6] tools/kvm_stat improvements
Date: Wed, 14 Feb 2018 22:45:47 +0100	[thread overview]
Message-ID: <20180214214553.96753-1-raspl@linux.vnet.ibm.com> (raw)

Some bugfixes (patches 1&2), simplifications (patch 4), plus rework that
lays the basis for introducing a (hopefully) neater drilldown mode in
patch 7.
Note that in absence of any knowledge of the interdependencies of the
events in debugfs on other platforms like x86, this new 'functionality'
was only added for S390 for now. Adding other platforms would be easy
enough, though.
Furthermore note that the data passing between Providers and Stats is
pretty much at its limit now - if we'd ever wanted to put in more
attributes along with the event data passed from Providers to Stats, we
should probably switch to passing more involved data structures with
indicator flags, etc. Not sure if performance is a concern, but from a
coding/maintaining point of view that's something we should consider in
that case.

Changes in v2:
* Patch [1]:
   - Switched to single underscore prefixing for "private"
     methods.
* Patch [4]:
   - Renamed methods to "tracepoint_is_child" and "debugfs_is_child"
     from "trc_is_child" et al.
   - Also, moved "child_events" and "pid" from DebugfsProvider and
     TracepointProvider up to "Provider".


---


Stefan Raspl (6):
  tools/kvm_stat: mark private methods as such
  tools/kvm_stat: eliminate extra guest/pid selection dialog
  tools/kvm_stat: cache compiled regular expression
  tools/kvm_stat: separate drilldown and fields filtering
  tools/kvm_stat: group child events indented after parent
  tools/kvm_stat: print 'Total' line for multiple events only

 tools/kvm/kvm_stat/kvm_stat     | 435 ++++++++++++++++++++++------------------
 tools/kvm/kvm_stat/kvm_stat.txt |   4 +-
 2 files changed, 246 insertions(+), 193 deletions(-)

-- 
2.13.5

             reply	other threads:[~2018-02-14 21:46 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-14 21:45 Stefan Raspl [this message]
2018-02-14 21:45 ` [PATCH 1/6] tools/kvm_stat: mark private methods as such Stefan Raspl
2018-02-14 21:45 ` [PATCH 2/6] tools/kvm_stat: eliminate extra guest/pid selection dialog Stefan Raspl
2018-02-14 21:45 ` [PATCH 3/6] tools/kvm_stat: cache compiled regular expression Stefan Raspl
2018-02-15  7:32   ` Janosch Frank
2018-02-15  8:14     ` Stefan Raspl
2018-02-14 21:45 ` [PATCH 4/6] tools/kvm_stat: separate drilldown and fields filtering Stefan Raspl
2018-02-14 21:45 ` [PATCH 5/6] tools/kvm_stat: group child events indented after parent Stefan Raspl
2018-02-14 21:45 ` [PATCH 6/6] tools/kvm_stat: print 'Total' line for multiple events only Stefan Raspl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180214214553.96753-1-raspl@linux.vnet.ibm.com \
    --to=raspl@linux.vnet.ibm.com \
    --cc=frankja@linux.vnet.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=rkrcmar@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox