From: Alex Williamson <alex.williamson@redhat.com>
To: Li Qiang <liq3ea@gmail.com>
Cc: eric.auger@redhat.com, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, liqiang02@corp.netease.com
Subject: Re: [PATCH] vfio: fix potential memory leak in vfio_msi_cap_len
Date: Tue, 4 Sep 2018 09:52:50 -0600 [thread overview]
Message-ID: <20180904095250.32e170c5@t450s.home> (raw)
In-Reply-To: <1535374041-3551-1-git-send-email-liq3ea@gmail.com>
On Mon, 27 Aug 2018 05:47:21 -0700
Li Qiang <liq3ea@gmail.com> wrote:
> Free the vdev->msi_perm in error path.
>
> Signed-off-by: Li Qiang <liq3ea@gmail.com>
> ---
> drivers/vfio/pci/vfio_pci_config.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/vfio/pci/vfio_pci_config.c b/drivers/vfio/pci/vfio_pci_config.c
> index 115a36f6f403..62023b4a373b 100644
> --- a/drivers/vfio/pci/vfio_pci_config.c
> +++ b/drivers/vfio/pci/vfio_pci_config.c
> @@ -1180,8 +1180,10 @@ static int vfio_msi_cap_len(struct vfio_pci_device *vdev, u8 pos)
> return -ENOMEM;
>
> ret = init_pci_cap_msi_perm(vdev->msi_perm, len, flags);
> - if (ret)
> + if (ret) {
> + kfree(vdev->msi_perm);
> return ret;
> + }
>
> return len;
> }
Fix looks correct to me, I'll queue this for v4.20 with Eric's R-b.
Thanks,
Alex
prev parent reply other threads:[~2018-09-04 15:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-27 12:47 [PATCH] vfio: fix potential memory leak in vfio_msi_cap_len Li Qiang
2018-08-30 14:15 ` David Hildenbrand
2018-09-03 17:00 ` Auger Eric
2018-09-04 15:52 ` Alex Williamson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180904095250.32e170c5@t450s.home \
--to=alex.williamson@redhat.com \
--cc=eric.auger@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liq3ea@gmail.com \
--cc=liqiang02@corp.netease.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox