From: Will Deacon <will.deacon@arm.com>
To: Leo Yan <leo.yan@linaro.org>
Cc: kvm@vger.kernel.org, Marc Zyngier <marc.zyngier@arm.com>,
Robin Murphy <robin.murphy@arm.com>,
kvmarm@lists.cs.columbia.edu
Subject: Re: [PATCH kvmtool v3 0/3] vfio-pci: Support INTx mode re-enabling
Date: Tue, 2 Apr 2019 17:50:25 +0100 [thread overview]
Message-ID: <20190402165025.GA1442@fuggles.cambridge.arm.com> (raw)
In-Reply-To: <20190326074131.4284-1-leo.yan@linaro.org>
Hi Leo,
On Tue, Mar 26, 2019 at 03:41:28PM +0800, Leo Yan wrote:
> When enable vfio-pci mode for NIC driver on Juno board, the IRQ is
> failed to forward properly from host to guest, finally root caused this
> issue is related with kvmtool cannot re-enable INTx mode properly.
>
> So the basic working flow to reproduce this issue is as below:
>
> Host Guest
> ------------- --------------------
> INTx mode
> MSI enable failed in NIC driver
> MSI disable in NIC driver
> Switch back to INTx mode --> kvmtool doesn't support
>
> So this patch is to support INTx mode re-enabling; patch 0001 is one
> minor fixing up for eventfd releasing; patch 0002 introduces a new
> function vfio_pci_init_intx() which is used to finish INTx one-time
> initialisation; patch 0003 is the core patch for support INTx mode
> re-enabling, when kvmtool detects MSI is disabled it rollbacks to INTx
> mode.
>
> This patch set has been tested on Juno-r2 board.
>
> == Changes for V3 ==
> * Add new function vfio_pci_init_intx() for one-time initialisation.
> * Simplized INTx re-enabling (don't change irq_line anymore at the
> runtime).
Just checking, but is this series intended to supersede this one:
https://www.spinics.net/lists/kvm/msg183750.html
?
Thanks,
Will
next prev parent reply other threads:[~2019-04-02 16:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-26 7:41 [PATCH kvmtool v3 0/3] vfio-pci: Support INTx mode re-enabling Leo Yan
2019-03-26 7:41 ` [PATCH kvmtool v3 1/3] vfio-pci: Release INTx's unmask eventfd properly Leo Yan
2019-03-26 7:41 ` [PATCH kvmtool v3 2/3] vfio-pci: Add new function for INTx one-time initialisation Leo Yan
2019-04-04 11:06 ` Jean-Philippe Brucker
2019-03-26 7:41 ` [PATCH kvmtool v3 3/3] vfio-pci: Re-enable INTx mode when disable MSI/MSIX Leo Yan
2019-04-04 11:06 ` Jean-Philippe Brucker
2019-04-05 3:46 ` Leo Yan
2019-04-05 3:46 ` Leo Yan
2019-04-02 16:50 ` Will Deacon [this message]
2019-04-03 3:58 ` [PATCH kvmtool v3 0/3] vfio-pci: Support INTx mode re-enabling Leo Yan
2019-04-03 12:43 ` Will Deacon
2019-04-04 2:57 ` Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190402165025.GA1442@fuggles.cambridge.arm.com \
--to=will.deacon@arm.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=leo.yan@linaro.org \
--cc=marc.zyngier@arm.com \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox