* [PATCH] x86: Fix the register order to match struct regs
@ 2019-10-24 22:27 Aaron Lewis
2019-10-25 16:47 ` Jim Mattson
0 siblings, 1 reply; 2+ messages in thread
From: Aaron Lewis @ 2019-10-24 22:27 UTC (permalink / raw)
To: kvm; +Cc: Aaron Lewis, Jim Mattson
Fix the order the registers show up in SAVE_GPR and SAVE_GPR_C to ensure
the correct registers get the correct values. Previously, the registers
were being written to (and read from) the wrong fields.
Reviewed-by: Jim Mattson <jmattson@google.com>
Signed-off-by: Aaron Lewis <aaronlewis@google.com>
---
x86/vmx.h | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/x86/vmx.h b/x86/vmx.h
index 8496be7..8527997 100644
--- a/x86/vmx.h
+++ b/x86/vmx.h
@@ -492,9 +492,9 @@ enum vm_instruction_error_number {
#define SAVE_GPR \
"xchg %rax, regs\n\t" \
- "xchg %rbx, regs+0x8\n\t" \
- "xchg %rcx, regs+0x10\n\t" \
- "xchg %rdx, regs+0x18\n\t" \
+ "xchg %rcx, regs+0x8\n\t" \
+ "xchg %rdx, regs+0x10\n\t" \
+ "xchg %rbx, regs+0x18\n\t" \
"xchg %rbp, regs+0x28\n\t" \
"xchg %rsi, regs+0x30\n\t" \
"xchg %rdi, regs+0x38\n\t" \
@@ -511,9 +511,9 @@ enum vm_instruction_error_number {
#define SAVE_GPR_C \
"xchg %%rax, regs\n\t" \
- "xchg %%rbx, regs+0x8\n\t" \
- "xchg %%rcx, regs+0x10\n\t" \
- "xchg %%rdx, regs+0x18\n\t" \
+ "xchg %%rcx, regs+0x8\n\t" \
+ "xchg %%rdx, regs+0x10\n\t" \
+ "xchg %%rbx, regs+0x18\n\t" \
"xchg %%rbp, regs+0x28\n\t" \
"xchg %%rsi, regs+0x30\n\t" \
"xchg %%rdi, regs+0x38\n\t" \
--
2.24.0.rc0.303.g954a862665-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] x86: Fix the register order to match struct regs
2019-10-24 22:27 [PATCH] x86: Fix the register order to match struct regs Aaron Lewis
@ 2019-10-25 16:47 ` Jim Mattson
0 siblings, 0 replies; 2+ messages in thread
From: Jim Mattson @ 2019-10-25 16:47 UTC (permalink / raw)
To: Aaron Lewis; +Cc: kvm list
On Thu, Oct 24, 2019 at 10:28 PM Aaron Lewis <aaronlewis@google.com> wrote:
>
> Fix the order the registers show up in SAVE_GPR and SAVE_GPR_C to ensure
> the correct registers get the correct values. Previously, the registers
> were being written to (and read from) the wrong fields.
>
> Reviewed-by: Jim Mattson <jmattson@google.com>
> Signed-off-by: Aaron Lewis <aaronlewis@google.com>
Subject should have been [kvm-unit-tests PATCH] x86: Fix the register
order to match struct regs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-25 16:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-24 22:27 [PATCH] x86: Fix the register order to match struct regs Aaron Lewis
2019-10-25 16:47 ` Jim Mattson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox