From: Claudio Imbrenda <imbrenda@linux.ibm.com>
To: kvm@vger.kernel.org
Cc: linux-s390@vger.kernel.org, thuth@redhat.com, david@redhat.com,
borntraeger@de.ibm.com, frankja@linux.ibm.com
Subject: [kvm-unit-tests PATCH v8 5/6] s390x: lib: fix program interrupt handler if sclp_busy was set
Date: Mon, 20 Jan 2020 19:42:55 +0100 [thread overview]
Message-ID: <20200120184256.188698-6-imbrenda@linux.ibm.com> (raw)
In-Reply-To: <20200120184256.188698-1-imbrenda@linux.ibm.com>
Fix the program interrupt handler for the case where sclp_busy is set.
The interrupt handler will attempt to write an error message on the
console using the SCLP, and will wait for sclp_busy to become false
before doing so. If an exception happenes between setting the flag and
the SCLP call, or if the call itself raises an exception, we need to
clear the flag so we can successfully print the error message.
Signed-off-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
---
lib/s390x/interrupt.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/lib/s390x/interrupt.c b/lib/s390x/interrupt.c
index 05f30be..ccb376a 100644
--- a/lib/s390x/interrupt.c
+++ b/lib/s390x/interrupt.c
@@ -106,10 +106,13 @@ static void fixup_pgm_int(void)
void handle_pgm_int(void)
{
- if (!pgm_int_expected)
+ if (!pgm_int_expected) {
+ /* Force sclp_busy to false, otherwise we will loop forever */
+ sclp_handle_ext();
report_abort("Unexpected program interrupt: %d at %#lx, ilen %d\n",
lc->pgm_int_code, lc->pgm_old_psw.addr,
lc->pgm_int_id);
+ }
pgm_int_expected = false;
fixup_pgm_int();
--
2.24.1
next prev parent reply other threads:[~2020-01-20 18:43 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-20 18:42 [kvm-unit-tests PATCH v8 0/6] s390x: SCLP Unit test Claudio Imbrenda
2020-01-20 18:42 ` [kvm-unit-tests PATCH v8 1/6] s390x: export sclp_setup_int Claudio Imbrenda
2020-01-20 18:42 ` [kvm-unit-tests PATCH v8 2/6] s390x: sclp: add service call instruction wrapper Claudio Imbrenda
2020-01-20 18:42 ` [kvm-unit-tests PATCH v8 3/6] s390x: lib: fix stfl wrapper asm Claudio Imbrenda
2020-01-21 6:15 ` Thomas Huth
2020-01-21 9:17 ` David Hildenbrand
2020-01-21 12:42 ` Janosch Frank
2020-01-20 18:42 ` [kvm-unit-tests PATCH v8 4/6] s390x: lib: add SPX and STPX instruction wrapper Claudio Imbrenda
2020-01-20 18:42 ` Claudio Imbrenda [this message]
2020-01-21 6:19 ` [kvm-unit-tests PATCH v8 5/6] s390x: lib: fix program interrupt handler if sclp_busy was set Thomas Huth
2020-01-21 9:18 ` David Hildenbrand
2020-01-20 18:42 ` [kvm-unit-tests PATCH v8 6/6] s390x: SCLP unit test Claudio Imbrenda
2020-01-22 9:55 ` David Hildenbrand
2020-01-22 10:10 ` David Hildenbrand
2020-01-22 10:22 ` David Hildenbrand
2020-01-22 10:31 ` Thomas Huth
2020-01-22 10:32 ` David Hildenbrand
2020-01-22 10:39 ` Thomas Huth
2020-01-22 10:40 ` David Hildenbrand
2020-01-22 11:20 ` David Hildenbrand
2020-01-22 12:13 ` Thomas Huth
2020-01-22 12:16 ` Thomas Huth
2020-01-22 14:15 ` strict aliasing in kvm-unit-tests (was: Re: [kvm-unit-tests PATCH v8 6/6] s390x: SCLP unit test) Thomas Huth
2020-01-22 14:42 ` Paolo Bonzini
2020-01-22 15:01 ` Laurent Vivier
2020-01-22 9:55 ` [kvm-unit-tests PATCH v8 0/6] s390x: SCLP Unit test David Hildenbrand
2020-01-22 10:02 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200120184256.188698-6-imbrenda@linux.ibm.com \
--to=imbrenda@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox