Re: [PATCH v2 kvmtool 06/30] arm/pci: Advertise only PCI bus 0 in the DT

[Andre Przywara <andre.przywara@arm.com>]

On Thu, 23 Jan 2020 13:47:41 +0000
Alexandru Elisei <alexandru.elisei@arm.com> wrote:

Hi,

> The "bus-range" property encodes the PCI bus number of the PCI
> controller and the largest bus number of any PCI buses that are
> subordinate to this node [1]. kvmtool emulates only PCI bus 0.

I am wondering if that ever becomes a limitation, but in the current context it looks like the right thing to do.

> Advertise this in the PCI DT node by setting "bus-range" to <0,0>.
> 
> [1] IEEE Std 1275-1994, Section 3 "Bus Nodes Properties and Methods"
> 
> Signed-off-by: Alexandru Elisei <alexandru.elisei@arm.com>

Reviewed-by: Andre Przywara <andre.przywara@arm.com>

Cheers,
Andre

> ---
>  arm/pci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arm/pci.c b/arm/pci.c
> index 557cfa98938d..ed325fa4a811 100644
> --- a/arm/pci.c
> +++ b/arm/pci.c
> @@ -30,7 +30,7 @@ void pci__generate_fdt_nodes(void *fdt)
>  	struct of_interrupt_map_entry irq_map[OF_PCI_IRQ_MAP_MAX];
>  	unsigned nentries = 0;
>  	/* Bus range */
> -	u32 bus_range[] = { cpu_to_fdt32(0), cpu_to_fdt32(1), };
> +	u32 bus_range[] = { cpu_to_fdt32(0), cpu_to_fdt32(0), };
>  	/* Configuration Space */
>  	u64 cfg_reg_prop[] = { cpu_to_fdt64(KVM_PCI_CFG_AREA),
>  			       cpu_to_fdt64(ARM_PCI_CFG_SIZE), };