Kernel KVM virtualization development
 help / color / mirror / Atom feed
* [PATCH] KVM: s390: remove unneeded semicolon in gisa_vcpu_kicker()
@ 2020-04-18  8:19 Jason Yan
  2020-04-20  6:46 ` Cornelia Huck
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Jason Yan @ 2020-04-18  8:19 UTC (permalink / raw)
  To: borntraeger, frankja, david, cohuck, heiko.carstens, gor,
	Ulrich.Weigand, kvm, linux-s390, linux-kernel
  Cc: Jason Yan, Hulk Robot

Fix the following coccicheck warning:

arch/s390/kvm/interrupt.c:3085:2-3: Unneeded semicolon

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
 arch/s390/kvm/interrupt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/s390/kvm/interrupt.c b/arch/s390/kvm/interrupt.c
index 8191106bf7b9..559177123d0f 100644
--- a/arch/s390/kvm/interrupt.c
+++ b/arch/s390/kvm/interrupt.c
@@ -3082,7 +3082,7 @@ static enum hrtimer_restart gisa_vcpu_kicker(struct hrtimer *timer)
 		__airqs_kick_single_vcpu(kvm, pending_mask);
 		hrtimer_forward_now(timer, ns_to_ktime(gi->expires));
 		return HRTIMER_RESTART;
-	};
+	}
 
 	return HRTIMER_NORESTART;
 }
-- 
2.21.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] KVM: s390: remove unneeded semicolon in gisa_vcpu_kicker()
  2020-04-18  8:19 [PATCH] KVM: s390: remove unneeded semicolon in gisa_vcpu_kicker() Jason Yan
@ 2020-04-20  6:46 ` Cornelia Huck
  2020-04-20  7:05 ` David Hildenbrand
  2020-04-20  7:31 ` Christian Borntraeger
  2 siblings, 0 replies; 4+ messages in thread
From: Cornelia Huck @ 2020-04-20  6:46 UTC (permalink / raw)
  To: Jason Yan
  Cc: borntraeger, frankja, david, heiko.carstens, gor, Ulrich.Weigand,
	kvm, linux-s390, linux-kernel, Hulk Robot

On Sat, 18 Apr 2020 16:19:26 +0800
Jason Yan <yanaijie@huawei.com> wrote:

> Fix the following coccicheck warning:
> 
> arch/s390/kvm/interrupt.c:3085:2-3: Unneeded semicolon
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>

Fixes: 9f30f6216378 ("KVM: s390: add gib_alert_irq_handler()")

> ---
>  arch/s390/kvm/interrupt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/s390/kvm/interrupt.c b/arch/s390/kvm/interrupt.c
> index 8191106bf7b9..559177123d0f 100644
> --- a/arch/s390/kvm/interrupt.c
> +++ b/arch/s390/kvm/interrupt.c
> @@ -3082,7 +3082,7 @@ static enum hrtimer_restart gisa_vcpu_kicker(struct hrtimer *timer)
>  		__airqs_kick_single_vcpu(kvm, pending_mask);
>  		hrtimer_forward_now(timer, ns_to_ktime(gi->expires));
>  		return HRTIMER_RESTART;
> -	};
> +	}
>  
>  	return HRTIMER_NORESTART;
>  }

Reviewed-by: Cornelia Huck <cohuck@redhat.com>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] KVM: s390: remove unneeded semicolon in gisa_vcpu_kicker()
  2020-04-18  8:19 [PATCH] KVM: s390: remove unneeded semicolon in gisa_vcpu_kicker() Jason Yan
  2020-04-20  6:46 ` Cornelia Huck
@ 2020-04-20  7:05 ` David Hildenbrand
  2020-04-20  7:31 ` Christian Borntraeger
  2 siblings, 0 replies; 4+ messages in thread
From: David Hildenbrand @ 2020-04-20  7:05 UTC (permalink / raw)
  To: Jason Yan, borntraeger, frankja, cohuck, heiko.carstens, gor,
	Ulrich.Weigand, kvm, linux-s390, linux-kernel
  Cc: Hulk Robot

On 18.04.20 10:19, Jason Yan wrote:
> Fix the following coccicheck warning:
> 
> arch/s390/kvm/interrupt.c:3085:2-3: Unneeded semicolon
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
> ---
>  arch/s390/kvm/interrupt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/s390/kvm/interrupt.c b/arch/s390/kvm/interrupt.c
> index 8191106bf7b9..559177123d0f 100644
> --- a/arch/s390/kvm/interrupt.c
> +++ b/arch/s390/kvm/interrupt.c
> @@ -3082,7 +3082,7 @@ static enum hrtimer_restart gisa_vcpu_kicker(struct hrtimer *timer)
>  		__airqs_kick_single_vcpu(kvm, pending_mask);
>  		hrtimer_forward_now(timer, ns_to_ktime(gi->expires));
>  		return HRTIMER_RESTART;
> -	};
> +	}
>  
>  	return HRTIMER_NORESTART;
>  }
> 

Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Thanks,

David / dhildenb


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] KVM: s390: remove unneeded semicolon in gisa_vcpu_kicker()
  2020-04-18  8:19 [PATCH] KVM: s390: remove unneeded semicolon in gisa_vcpu_kicker() Jason Yan
  2020-04-20  6:46 ` Cornelia Huck
  2020-04-20  7:05 ` David Hildenbrand
@ 2020-04-20  7:31 ` Christian Borntraeger
  2 siblings, 0 replies; 4+ messages in thread
From: Christian Borntraeger @ 2020-04-20  7:31 UTC (permalink / raw)
  To: Jason Yan, frankja, david, cohuck, heiko.carstens, gor,
	Ulrich.Weigand, kvm, linux-s390, linux-kernel
  Cc: Hulk Robot

On 18.04.20 10:19, Jason Yan wrote:
> Fix the following coccicheck warning:
> 
> arch/s390/kvm/interrupt.c:3085:2-3: Unneeded semicolon
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>

Thanks applied.

> ---
>  arch/s390/kvm/interrupt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/s390/kvm/interrupt.c b/arch/s390/kvm/interrupt.c
> index 8191106bf7b9..559177123d0f 100644
> --- a/arch/s390/kvm/interrupt.c
> +++ b/arch/s390/kvm/interrupt.c
> @@ -3082,7 +3082,7 @@ static enum hrtimer_restart gisa_vcpu_kicker(struct hrtimer *timer)
>  		__airqs_kick_single_vcpu(kvm, pending_mask);
>  		hrtimer_forward_now(timer, ns_to_ktime(gi->expires));
>  		return HRTIMER_RESTART;
> -	};
> +	}
> 
>  	return HRTIMER_NORESTART;
>  }
> 


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-04-20  7:31 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-18  8:19 [PATCH] KVM: s390: remove unneeded semicolon in gisa_vcpu_kicker() Jason Yan
2020-04-20  6:46 ` Cornelia Huck
2020-04-20  7:05 ` David Hildenbrand
2020-04-20  7:31 ` Christian Borntraeger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox