* [PATCH] RISC-V: KVM: Fix incorrect reg_subtype labels in kvm_riscv_vcpu_set_reg_isa_ext function
@ 2024-05-23 2:13 zhouquan
2024-05-23 9:06 ` Andrew Jones
2024-05-31 5:42 ` Anup Patel
0 siblings, 2 replies; 3+ messages in thread
From: zhouquan @ 2024-05-23 2:13 UTC (permalink / raw)
To: anup, atishp
Cc: paul.walmsley, palmer, aou, kvm, kvm-riscv, linux-riscv,
linux-kernel, Quan Zhou
From: Quan Zhou <zhouquan@iscas.ac.cn>
In the function kvm_riscv_vcpu_set_reg_isa_ext, the original code
used incorrect reg_subtype labels KVM_REG_RISCV_SBI_MULTI_EN/DIS.
These have been corrected to KVM_REG_RISCV_ISA_MULTI_EN/DIS respectively.
Although they are numerically equivalent, the actual processing
will not result in errors, but it may lead to ambiguous code semantics.
Signed-off-by: Quan Zhou <zhouquan@iscas.ac.cn>
---
arch/riscv/kvm/vcpu_onereg.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/riscv/kvm/vcpu_onereg.c b/arch/riscv/kvm/vcpu_onereg.c
index c676275ea0a0..62874fbca29f 100644
--- a/arch/riscv/kvm/vcpu_onereg.c
+++ b/arch/riscv/kvm/vcpu_onereg.c
@@ -724,9 +724,9 @@ static int kvm_riscv_vcpu_set_reg_isa_ext(struct kvm_vcpu *vcpu,
switch (reg_subtype) {
case KVM_REG_RISCV_ISA_SINGLE:
return riscv_vcpu_set_isa_ext_single(vcpu, reg_num, reg_val);
- case KVM_REG_RISCV_SBI_MULTI_EN:
+ case KVM_REG_RISCV_ISA_MULTI_EN:
return riscv_vcpu_set_isa_ext_multi(vcpu, reg_num, reg_val, true);
- case KVM_REG_RISCV_SBI_MULTI_DIS:
+ case KVM_REG_RISCV_ISA_MULTI_DIS:
return riscv_vcpu_set_isa_ext_multi(vcpu, reg_num, reg_val, false);
default:
return -ENOENT;
base-commit: 29c73fc794c83505066ee6db893b2a83ac5fac63
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] RISC-V: KVM: Fix incorrect reg_subtype labels in kvm_riscv_vcpu_set_reg_isa_ext function
2024-05-23 2:13 [PATCH] RISC-V: KVM: Fix incorrect reg_subtype labels in kvm_riscv_vcpu_set_reg_isa_ext function zhouquan
@ 2024-05-23 9:06 ` Andrew Jones
2024-05-31 5:42 ` Anup Patel
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Jones @ 2024-05-23 9:06 UTC (permalink / raw)
To: zhouquan
Cc: anup, atishp, paul.walmsley, palmer, aou, kvm, kvm-riscv,
linux-riscv, linux-kernel
On Thu, May 23, 2024 at 10:13:34AM GMT, zhouquan@iscas.ac.cn wrote:
> From: Quan Zhou <zhouquan@iscas.ac.cn>
>
> In the function kvm_riscv_vcpu_set_reg_isa_ext, the original code
> used incorrect reg_subtype labels KVM_REG_RISCV_SBI_MULTI_EN/DIS.
> These have been corrected to KVM_REG_RISCV_ISA_MULTI_EN/DIS respectively.
> Although they are numerically equivalent, the actual processing
> will not result in errors, but it may lead to ambiguous code semantics.
>
> Signed-off-by: Quan Zhou <zhouquan@iscas.ac.cn>
> ---
> arch/riscv/kvm/vcpu_onereg.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/riscv/kvm/vcpu_onereg.c b/arch/riscv/kvm/vcpu_onereg.c
> index c676275ea0a0..62874fbca29f 100644
> --- a/arch/riscv/kvm/vcpu_onereg.c
> +++ b/arch/riscv/kvm/vcpu_onereg.c
> @@ -724,9 +724,9 @@ static int kvm_riscv_vcpu_set_reg_isa_ext(struct kvm_vcpu *vcpu,
> switch (reg_subtype) {
> case KVM_REG_RISCV_ISA_SINGLE:
> return riscv_vcpu_set_isa_ext_single(vcpu, reg_num, reg_val);
> - case KVM_REG_RISCV_SBI_MULTI_EN:
> + case KVM_REG_RISCV_ISA_MULTI_EN:
> return riscv_vcpu_set_isa_ext_multi(vcpu, reg_num, reg_val, true);
> - case KVM_REG_RISCV_SBI_MULTI_DIS:
> + case KVM_REG_RISCV_ISA_MULTI_DIS:
> return riscv_vcpu_set_isa_ext_multi(vcpu, reg_num, reg_val, false);
> default:
> return -ENOENT;
>
> base-commit: 29c73fc794c83505066ee6db893b2a83ac5fac63
> --
> 2.34.1
>
>
Reviewed-by: Andrew Jones <ajones@ventanamicro.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] RISC-V: KVM: Fix incorrect reg_subtype labels in kvm_riscv_vcpu_set_reg_isa_ext function
2024-05-23 2:13 [PATCH] RISC-V: KVM: Fix incorrect reg_subtype labels in kvm_riscv_vcpu_set_reg_isa_ext function zhouquan
2024-05-23 9:06 ` Andrew Jones
@ 2024-05-31 5:42 ` Anup Patel
1 sibling, 0 replies; 3+ messages in thread
From: Anup Patel @ 2024-05-31 5:42 UTC (permalink / raw)
To: zhouquan
Cc: atishp, paul.walmsley, palmer, aou, kvm, kvm-riscv, linux-riscv,
linux-kernel
On Thu, May 23, 2024 at 7:43 AM <zhouquan@iscas.ac.cn> wrote:
>
> From: Quan Zhou <zhouquan@iscas.ac.cn>
>
> In the function kvm_riscv_vcpu_set_reg_isa_ext, the original code
> used incorrect reg_subtype labels KVM_REG_RISCV_SBI_MULTI_EN/DIS.
> These have been corrected to KVM_REG_RISCV_ISA_MULTI_EN/DIS respectively.
> Although they are numerically equivalent, the actual processing
> will not result in errors, but it may lead to ambiguous code semantics.
>
> Signed-off-by: Quan Zhou <zhouquan@iscas.ac.cn>
Queued this patch for Linux-6.10-rcX fixes.
I have added an appropriate Fixes tag as well.
Thanks,
Anup
> ---
> arch/riscv/kvm/vcpu_onereg.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/riscv/kvm/vcpu_onereg.c b/arch/riscv/kvm/vcpu_onereg.c
> index c676275ea0a0..62874fbca29f 100644
> --- a/arch/riscv/kvm/vcpu_onereg.c
> +++ b/arch/riscv/kvm/vcpu_onereg.c
> @@ -724,9 +724,9 @@ static int kvm_riscv_vcpu_set_reg_isa_ext(struct kvm_vcpu *vcpu,
> switch (reg_subtype) {
> case KVM_REG_RISCV_ISA_SINGLE:
> return riscv_vcpu_set_isa_ext_single(vcpu, reg_num, reg_val);
> - case KVM_REG_RISCV_SBI_MULTI_EN:
> + case KVM_REG_RISCV_ISA_MULTI_EN:
> return riscv_vcpu_set_isa_ext_multi(vcpu, reg_num, reg_val, true);
> - case KVM_REG_RISCV_SBI_MULTI_DIS:
> + case KVM_REG_RISCV_ISA_MULTI_DIS:
> return riscv_vcpu_set_isa_ext_multi(vcpu, reg_num, reg_val, false);
> default:
> return -ENOENT;
>
> base-commit: 29c73fc794c83505066ee6db893b2a83ac5fac63
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-05-31 5:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-23 2:13 [PATCH] RISC-V: KVM: Fix incorrect reg_subtype labels in kvm_riscv_vcpu_set_reg_isa_ext function zhouquan
2024-05-23 9:06 ` Andrew Jones
2024-05-31 5:42 ` Anup Patel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox