Re: nointxmask device

public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed

* Re: nointxmask device
       [not found] <VI1PR10MB8207C507DB5420AB4C7281E0DB9A2@VI1PR10MB8207.EURPRD10.PROD.OUTLOOK.COM>
@ 2024-09-10 13:49 ` Bjorn Helgaas
  2024-09-11 22:12   ` Alex Williamson
  0 siblings, 1 reply; 3+ messages in thread
From: Bjorn Helgaas @ 2024-09-10 13:49 UTC (permalink / raw)
  To: zdravko delineshev; +Cc: linux-pci@vger.kernel.org, Alex Williamson, kvm

[+cc Alex, kvm]

On Tue, Sep 10, 2024 at 01:13:41PM +0000, zdravko delineshev wrote:
> 
> Hello,
> 
> i found a note in the vfio-pci parameters to email devices fixed by the nointxmask parameter.
> 
> Here is the one i have and i am trying to pass trough. it is currently working fine, with nointxmask=1 .
> 
> 
> 81:00.0 Audio device: Creative Labs EMU20k2 [Sound Blaster X-Fi Titanium Series] (rev 03)
>         Subsystem: Creative Labs EMU20k2 [Sound Blaster X-Fi Titanium Series]
>         Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr+ Stepping- SERR+ FastB2B- DisINTx-
>         Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
>         Latency: 0, Cache Line Size: 32 bytes
>         Interrupt: pin A routed to IRQ 409
>         NUMA node: 1
>         IOMMU group: 23
>         Region 0: Memory at d3200000 (64-bit, non-prefetchable) [size=64K]
>         Region 2: Memory at d3000000 (64-bit, non-prefetchable) [size=2M]
>         Region 4: Memory at d2000000 (64-bit, non-prefetchable) [size=16M]
>         Capabilities: [40] Power Management version 3
>                 Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA PME(D0-,D1-,D2-,D3hot-,D3cold-)
>                 Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=0 PME-
>         Capabilities: [48] MSI: Enable- Count=1/1 Maskable- 64bit+
>                 Address: 0000000000000000  Data: 0000
>         Capabilities: [58] Express (v2) Endpoint, MSI 00
>                 DevCap: MaxPayload 128 bytes, PhantFunc 0, Latency L0s <64ns, L1 <1us
>                         ExtTag- AttnBtn- AttnInd- PwrInd- RBE+ FLReset- SlotPowerLimit 0W
>                 DevCtl: CorrErr- NonFatalErr- FatalErr+ UnsupReq-
>                         RlxdOrd+ ExtTag- PhantFunc- AuxPwr+ NoSnoop+
>                         MaxPayload 128 bytes, MaxReadReq 512 bytes
>                 DevSta: CorrErr- NonFatalErr- FatalErr- UnsupReq- AuxPwr- TransPend-
>                 LnkCap: Port #0, Speed 2.5GT/s, Width x1, ASPM L0s L1, Exit Latency L0s <64ns, L1 <1us
>                         ClockPM- Surprise- LLActRep- BwNot- ASPMOptComp-
>                 LnkCtl: ASPM Disabled; RCB 64 bytes, Disabled- CommClk-
>                         ExtSynch- ClockPM- AutWidDis- BWInt- AutBWInt-
>                 LnkSta: Speed 2.5GT/s, Width x1
>                         TrErr- Train- SlotClk- DLActive- BWMgmt- ABWMgmt-
>                 DevCap2: Completion Timeout: Range ABCD, TimeoutDis- NROPrPrP- LTR-
>                          10BitTagComp- 10BitTagReq- OBFF Not Supported, ExtFmt- EETLPPrefix-
>                          EmergencyPowerReduction Not Supported, EmergencyPowerReductionInit-
>                          FRS- TPHComp- ExtTPHComp-
>                          AtomicOpsCap: 32bit- 64bit- 128bitCAS-
>                 DevCtl2: Completion Timeout: 50us to 50ms, TimeoutDis- LTR- 10BitTagReq- OBFF Disabled,
>                          AtomicOpsCtl: ReqEn-
>                 LnkCtl2: Target Link Speed: 2.5GT/s, EnterCompliance- SpeedDis-
>                          Transmit Margin: Normal Operating Range, EnterModifiedCompliance- ComplianceSOS-
>                          Compliance Preset/De-emphasis: -6dB de-emphasis, 0dB preshoot
>                 LnkSta2: Current De-emphasis Level: -6dB, EqualizationComplete- EqualizationPhase1-
>                          EqualizationPhase2- EqualizationPhase3- LinkEqualizationRequest-
>                          Retimer- 2Retimers- CrosslinkRes: unsupported
>         Capabilities: [100 v1] Device Serial Number ff-ff-ff-ff-ff-ff-ff-ff
>         Capabilities: [300 v1] Advanced Error Reporting
>                 UESta:  DLP- SDES- TLP- FCP- CmpltTO- CmpltAbrt- UnxCmplt- RxOF- MalfTLP- ECRC- UnsupReq- ACSViol-
>                 UEMsk:  DLP- SDES+ TLP- FCP- CmpltTO- CmpltAbrt- UnxCmplt- RxOF- MalfTLP- ECRC- UnsupReq+ ACSViol-
>                 UESvrt: DLP+ SDES+ TLP- FCP+ CmpltTO- CmpltAbrt- UnxCmplt- RxOF+ MalfTLP+ ECRC- UnsupReq- ACSViol-
>                 CESta:  RxErr- BadTLP- BadDLLP- Rollover- Timeout- AdvNonFatalErr+
>                 CEMsk:  RxErr- BadTLP- BadDLLP- Rollover- Timeout- AdvNonFatalErr+
>                 AERCap: First Error Pointer: 00, ECRCGenCap+ ECRCGenEn- ECRCChkCap+ ECRCChkEn-
>                         MultHdrRecCap- MultHdrRecEn- TLPPfxPres- HdrLogCap-
>                 HeaderLog: 00000000 00000000 00000000 00000000
>         Kernel driver in use: vfio-pci
>         Kernel modules: snd_ctxfi
> 00: 02 11 0b 00 46 01 10 00 03 00 03 04 08 00 00 00
> 10: 04 00 20 d3 00 00 00 00 04 00 00 d3 00 00 00 00
> 20: 04 00 00 d2 00 00 00 00 00 00 00 00 02 11 44 00
> 30: 00 00 00 00 40 00 00 00 00 00 00 00 0b 01 00 00
> 40: 01 48 03 00 00 00 00 00 05 58 80 00 00 00 00 00
> 50: 00 00 00 00 00 00 00 00 10 00 02 00 00 80 00 00
> 60: 14 2c 20 00 11 0c 00 00 00 00 11 00 00 00 00 00
> 70: 00 00 00 00 00 00 00 00 00 00 00 00 0f 00 00 00
> 80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 90: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> a0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> b0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> c0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> d0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> e0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> f0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: nointxmask device
  2024-09-10 13:49 ` nointxmask device Bjorn Helgaas
@ 2024-09-11 22:12   ` Alex Williamson
  2024-09-12 19:52     ` zdravko delineshev
  0 siblings, 1 reply; 3+ messages in thread
From: Alex Williamson @ 2024-09-11 22:12 UTC (permalink / raw)
  To: zdravko delineshev; +Cc: Bjorn Helgaas, linux-pci@vger.kernel.org, kvm

On Tue, 10 Sep 2024 08:49:18 -0500
Bjorn Helgaas <helgaas@kernel.org> wrote:

> [+cc Alex, kvm]
> 
> On Tue, Sep 10, 2024 at 01:13:41PM +0000, zdravko delineshev wrote:
> > 
> > Hello,
> > 
> > i found a note in the vfio-pci parameters to email devices fixed by the nointxmask parameter.
> > 
> > Here is the one i have and i am trying to pass trough. it is currently working fine, with nointxmask=1 .

What are the symptoms without using nointxmask=1?  Please provide any
dmesg snippets in the host related to using this device.

> > 81:00.0 Audio device: Creative Labs EMU20k2 [Sound Blaster X-Fi Titanium Series] (rev 03)
> >         Subsystem: Creative Labs EMU20k2 [Sound Blaster X-Fi Titanium Series]
> >         Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr+ Stepping- SERR+ FastB2B- DisINTx-
> >         Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
> >         Latency: 0, Cache Line Size: 32 bytes
> >         Interrupt: pin A routed to IRQ 409
> >         NUMA node: 1
> >         IOMMU group: 23
> >         Region 0: Memory at d3200000 (64-bit, non-prefetchable) [size=64K]
> >         Region 2: Memory at d3000000 (64-bit, non-prefetchable) [size=2M]
> >         Region 4: Memory at d2000000 (64-bit, non-prefetchable) [size=16M]
> >         Capabilities: [40] Power Management version 3
> >                 Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA PME(D0-,D1-,D2-,D3hot-,D3cold-)
> >                 Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=0 PME-
> >         Capabilities: [48] MSI: Enable- Count=1/1 Maskable- 64bit+
> >                 Address: 0000000000000000  Data: 0000

The device supports MSI, but the snd-ctxfs driver we have in the Linux
kernel has no support for it, therefore reporting zero for the INTx pin
is not an option.

Are you able to verify a kernel patch?

Adding it to the existing broken INTx quirk should simply be:

diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index a2ce4e08edf5..c7596e9aabb0 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -3608,6 +3608,8 @@ DECLARE_PCI_FIXUP_FINAL(0x1814, 0x0601, /* Ralink RT2800 802.11n PCI */
 			quirk_broken_intx_masking);
 DECLARE_PCI_FIXUP_FINAL(0x1b7c, 0x0004, /* Ceton InfiniTV4 */
 			quirk_broken_intx_masking);
+DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_CREATIVE, PCI_DEVICE_ID_CREATIVE_20K2,
+			quirk_broken_intx_masking);
 
 /*
  * Realtek RTL8169 PCI Gigabit Ethernet Controller (rev 10)


Thanks,
Alex

> >         Capabilities: [58] Express (v2) Endpoint, MSI 00
> >                 DevCap: MaxPayload 128 bytes, PhantFunc 0, Latency L0s <64ns, L1 <1us
> >                         ExtTag- AttnBtn- AttnInd- PwrInd- RBE+ FLReset- SlotPowerLimit 0W
> >                 DevCtl: CorrErr- NonFatalErr- FatalErr+ UnsupReq-
> >                         RlxdOrd+ ExtTag- PhantFunc- AuxPwr+ NoSnoop+
> >                         MaxPayload 128 bytes, MaxReadReq 512 bytes
> >                 DevSta: CorrErr- NonFatalErr- FatalErr- UnsupReq- AuxPwr- TransPend-
> >                 LnkCap: Port #0, Speed 2.5GT/s, Width x1, ASPM L0s L1, Exit Latency L0s <64ns, L1 <1us
> >                         ClockPM- Surprise- LLActRep- BwNot- ASPMOptComp-
> >                 LnkCtl: ASPM Disabled; RCB 64 bytes, Disabled- CommClk-
> >                         ExtSynch- ClockPM- AutWidDis- BWInt- AutBWInt-
> >                 LnkSta: Speed 2.5GT/s, Width x1
> >                         TrErr- Train- SlotClk- DLActive- BWMgmt- ABWMgmt-
> >                 DevCap2: Completion Timeout: Range ABCD, TimeoutDis- NROPrPrP- LTR-
> >                          10BitTagComp- 10BitTagReq- OBFF Not Supported, ExtFmt- EETLPPrefix-
> >                          EmergencyPowerReduction Not Supported, EmergencyPowerReductionInit-
> >                          FRS- TPHComp- ExtTPHComp-
> >                          AtomicOpsCap: 32bit- 64bit- 128bitCAS-
> >                 DevCtl2: Completion Timeout: 50us to 50ms, TimeoutDis- LTR- 10BitTagReq- OBFF Disabled,
> >                          AtomicOpsCtl: ReqEn-
> >                 LnkCtl2: Target Link Speed: 2.5GT/s, EnterCompliance- SpeedDis-
> >                          Transmit Margin: Normal Operating Range, EnterModifiedCompliance- ComplianceSOS-
> >                          Compliance Preset/De-emphasis: -6dB de-emphasis, 0dB preshoot
> >                 LnkSta2: Current De-emphasis Level: -6dB, EqualizationComplete- EqualizationPhase1-
> >                          EqualizationPhase2- EqualizationPhase3- LinkEqualizationRequest-
> >                          Retimer- 2Retimers- CrosslinkRes: unsupported
> >         Capabilities: [100 v1] Device Serial Number ff-ff-ff-ff-ff-ff-ff-ff
> >         Capabilities: [300 v1] Advanced Error Reporting
> >                 UESta:  DLP- SDES- TLP- FCP- CmpltTO- CmpltAbrt- UnxCmplt- RxOF- MalfTLP- ECRC- UnsupReq- ACSViol-
> >                 UEMsk:  DLP- SDES+ TLP- FCP- CmpltTO- CmpltAbrt- UnxCmplt- RxOF- MalfTLP- ECRC- UnsupReq+ ACSViol-
> >                 UESvrt: DLP+ SDES+ TLP- FCP+ CmpltTO- CmpltAbrt- UnxCmplt- RxOF+ MalfTLP+ ECRC- UnsupReq- ACSViol-
> >                 CESta:  RxErr- BadTLP- BadDLLP- Rollover- Timeout- AdvNonFatalErr+
> >                 CEMsk:  RxErr- BadTLP- BadDLLP- Rollover- Timeout- AdvNonFatalErr+
> >                 AERCap: First Error Pointer: 00, ECRCGenCap+ ECRCGenEn- ECRCChkCap+ ECRCChkEn-
> >                         MultHdrRecCap- MultHdrRecEn- TLPPfxPres- HdrLogCap-
> >                 HeaderLog: 00000000 00000000 00000000 00000000
> >         Kernel driver in use: vfio-pci
> >         Kernel modules: snd_ctxfi
> > 00: 02 11 0b 00 46 01 10 00 03 00 03 04 08 00 00 00
> > 10: 04 00 20 d3 00 00 00 00 04 00 00 d3 00 00 00 00
> > 20: 04 00 00 d2 00 00 00 00 00 00 00 00 02 11 44 00
> > 30: 00 00 00 00 40 00 00 00 00 00 00 00 0b 01 00 00
> > 40: 01 48 03 00 00 00 00 00 05 58 80 00 00 00 00 00
> > 50: 00 00 00 00 00 00 00 00 10 00 02 00 00 80 00 00
> > 60: 14 2c 20 00 11 0c 00 00 00 00 11 00 00 00 00 00
> > 70: 00 00 00 00 00 00 00 00 00 00 00 00 0f 00 00 00
> > 80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> > 90: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> > a0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> > b0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> > c0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> > d0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> > e0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> > f0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  
> 


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: nointxmask device
  2024-09-11 22:12   ` Alex Williamson
@ 2024-09-12 19:52     ` zdravko delineshev
  0 siblings, 0 replies; 3+ messages in thread
From: zdravko delineshev @ 2024-09-12 19:52 UTC (permalink / raw)
  To: Alex Williamson
  Cc: Bjorn Helgaas, linux-pci@vger.kernel.org, kvm@vger.kernel.org

Hello,

Here is the dmesg output BEFORE enabling the flag:

2024-09-01T01:32:02.885775+03:00 proxmox kernel: [  843.996111] irq 409: nobody cared (try booting with the "irqpoll" option)
2024-09-01T01:32:02.885792+03:00 proxmox kernel: [  843.996682] CPU: 46 PID: 7672 Comm: kvm Tainted: P           O       6.8.12-1-pve #1
2024-09-01T01:32:02.885793+03:00 proxmox kernel: [  843.997142] Hardware name: Supermicro Super Server/X11DPX-T, BIOS 4.2 12/15/2023
2024-09-01T01:32:02.885794+03:00 proxmox kernel: [  843.997566] Call Trace:
2024-09-01T01:32:02.885795+03:00 proxmox kernel: [  843.997973]  <TASK>
2024-09-01T01:32:02.885796+03:00 proxmox kernel: [  843.998370]  dump_stack_lvl+0x76/0xa0
2024-09-01T01:32:02.885797+03:00 proxmox kernel: [  843.998766]  dump_stack+0x10/0x20
2024-09-01T01:32:02.885798+03:00 proxmox kernel: [  843.999153]  __report_bad_irq+0x30/0xd0
2024-09-01T01:32:02.885799+03:00 proxmox kernel: [  843.999539]  note_interrupt+0x2e1/0x320
2024-09-01T01:32:02.885800+03:00 proxmox kernel: [  843.999917]  handle_irq_event+0x79/0x80
2024-09-01T01:32:02.885802+03:00 proxmox kernel: [  844.000296]  handle_fasteoi_irq+0x7d/0x200
2024-09-01T01:32:02.885803+03:00 proxmox kernel: [  844.000677]  __common_interrupt+0x3e/0xb0
2024-09-01T01:32:02.885804+03:00 proxmox kernel: [  844.001057]  common_interrupt+0x44/0xb0
2024-09-01T01:32:02.885815+03:00 proxmox kernel: [  844.001435]  asm_common_interrupt+0x27/0x40
2024-09-01T01:32:02.885816+03:00 proxmox kernel: [  844.001812] RIP: 0033:0x5c4d6fb518be
2024-09-01T01:32:02.885817+03:00 proxmox kernel: [  844.002209] Code: ff 48 69 04 24 00 ca 9a 3b 48 03 44 24 08 eb d4 e8 c7 f2 d9 ff 0f 1f 80 00 00 00 00 53 0f 1f 80 00 00 00 00 8b 1d 72 a3 2a 01 <e8> 3d ff ff ff 83 e3 fe 8b 15
64 a3 2a 01 39 da 75 e8 5b 31 d2 c3
2024-09-01T01:32:02.885819+03:00 proxmox kernel: [  844.002618] RSP: 002b:00007ffdea5752f0 EFLAGS: 00000246
2024-09-01T01:32:02.885820+03:00 proxmox kernel: [  844.003027] RAX: 0000000000000000 RBX: 0000000000000002 RCX: 0000000000000000
2024-09-01T01:32:02.885821+03:00 proxmox kernel: [  844.003436] RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000001
2024-09-01T01:32:02.885822+03:00 proxmox kernel: [  844.003844] RBP: 00005c4d72c4fe70 R08: 0000000000000000 R09: 0000000000000000
2024-09-01T01:32:02.885823+03:00 proxmox kernel: [  844.004247] R10: 0000000000000000 R11: 0000000000000000 R12: 00005c4d70e13860
2024-09-01T01:32:02.885824+03:00 proxmox kernel: [  844.004649] R13: 00005c4d70dfc7f8 R14: 00005c4d70e137c8 R15: 00007ffdea575360
2024-09-01T01:32:02.885825+03:00 proxmox kernel: [  844.005054]  </TASK>
2024-09-01T01:32:02.885826+03:00 proxmox kernel: [  844.005455] handlers:
2024-09-01T01:32:02.885827+03:00 proxmox kernel: [  844.005851] [<00000000eac396f2>] vfio_intx_handler [vfio_pci_core]
2024-09-01T01:32:02.885828+03:00 proxmox kernel: [  844.006265] Disabling IRQ #409
2024-09-01T01:32:03.377945+03:00 proxmox kernel: [  844.484106] irq 16: nobody cared (try booting with the "irqpoll" option)
2024-09-01T01:32:03.377963+03:00 proxmox kernel: [  844.484635] CPU: 8 PID: 0 Comm: swapper/8 Tainted: P           O       6.8.12-1-pve #1
2024-09-01T01:32:03.377964+03:00 proxmox kernel: [  844.485087] Hardware name: Supermicro Super Server/X11DPX-T, BIOS 4.2 12/15/2023
2024-09-01T01:32:03.377965+03:00 proxmox kernel: [  844.485494] Call Trace:
2024-09-01T01:32:03.377966+03:00 proxmox kernel: [  844.485901]  <IRQ>
2024-09-01T01:32:03.377967+03:00 proxmox kernel: [  844.486299]  dump_stack_lvl+0x76/0xa0
2024-09-01T01:32:03.377968+03:00 proxmox kernel: [  844.486707]  dump_stack+0x10/0x20
2024-09-01T01:32:03.377969+03:00 proxmox kernel: [  844.487104]  __report_bad_irq+0x30/0xd0
2024-09-01T01:32:03.377971+03:00 proxmox kernel: [  844.487507]  note_interrupt+0x2e1/0x320
2024-09-01T01:32:03.377972+03:00 proxmox kernel: [  844.487908]  handle_irq_event+0x79/0x80
2024-09-01T01:32:03.377973+03:00 proxmox kernel: [  844.488308]  handle_fasteoi_irq+0x7d/0x200
2024-09-01T01:32:03.377974+03:00 proxmox kernel: [  844.488706]  __common_interrupt+0x3e/0xb0
2024-09-01T01:32:03.377975+03:00 proxmox kernel: [  844.489112]  common_interrupt+0x9f/0xb0
2024-09-01T01:32:03.377986+03:00 proxmox kernel: [  844.489511]  </IRQ>
2024-09-01T01:32:03.377987+03:00 proxmox kernel: [  844.489900]  <TASK>
2024-09-01T01:32:03.377988+03:00 proxmox kernel: [  844.490287]  asm_common_interrupt+0x27/0x40
2024-09-01T01:32:03.377989+03:00 proxmox kernel: [  844.490681] RIP: 0010:pv_native_safe_halt+0xb/0x10
2024-09-01T01:32:03.377990+03:00 proxmox kernel: [  844.491075] Code: 22 d7 31 ff c3 cc cc cc cc 66 0f 1f 44 00 00 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 66 90 0f 00 2d 29 58 37 00 fb f4 <c3> cc cc cc cc 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 83
2024-09-01T01:32:03.377991+03:00 proxmox kernel: [  844.491497] RSP: 0018:ffffb4c54029fea0 EFLAGS: 00000246
2024-09-01T01:32:03.377992+03:00 proxmox kernel: [  844.491923] RAX: 0000000000000000 RBX: 0000000000000008 RCX: 0000000000000000
2024-09-01T01:32:03.377993+03:00 proxmox kernel: [  844.492354] RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000000
2024-09-01T01:32:03.377994+03:00 proxmox kernel: [  844.492781] RBP: ffffb4c54029fea8 R08: 0000000000000000 R09: 0000000000000000
2024-09-01T01:32:03.377995+03:00 proxmox kernel: [  844.493207] R10: 0000000000000000 R11: 0000000000000000 R12: ffff9bd807f68000
2024-09-01T01:32:03.377996+03:00 proxmox kernel: [  844.493634] R13: 0000000000000000 R14: 0000000000000000 R15: ffff9bd807f68000
2024-09-01T01:32:03.377997+03:00 proxmox kernel: [  844.494064]  ? default_idle+0x9/0x30
2024-09-01T01:32:03.377998+03:00 proxmox kernel: [  844.494496]  arch_cpu_idle+0x9/0x10
2024-09-01T01:32:03.377999+03:00 proxmox kernel: [  844.494930]  default_idle_call+0x2c/0xf0
2024-09-01T01:32:03.377999+03:00 proxmox kernel: [  844.495361]  do_idle+0x216/0x260
2024-09-01T01:32:03.378000+03:00 proxmox kernel: [  844.495793]  cpu_startup_entry+0x2a/0x30
2024-09-01T01:32:03.378001+03:00 proxmox kernel: [  844.496225]  start_secondary+0x119/0x140
2024-09-01T01:32:03.378002+03:00 proxmox kernel: [  844.496655]  secondary_startup_64_no_verify+0x184/0x18b
2024-09-01T01:32:03.378004+03:00 proxmox kernel: [  844.497090]  </TASK>
2024-09-01T01:32:03.378005+03:00 proxmox kernel: [  844.497519] handlers:
2024-09-01T01:32:03.378006+03:00 proxmox kernel: [  844.497944] [<0000000067e8c516>] i801_isr [i2c_i801]
2024-09-01T01:32:03.378007+03:00 proxmox kernel: [  844.498383] Disabling IRQ #16



This is a message AFTER enabling the flag, but device continued to operate. it has appeared only ONCE, and since this timestamp there are no other issues observed:

2024-09-06T16:02:31.196668+03:00 proxmox kernel: [  754.479693] Hardware name: Supermicro Super Server/X11DPX-T, BIOS 4.2 12/15/2023
2024-09-06T16:02:31.196669+03:00 proxmox kernel: [  754.480098] Call Trace:
2024-09-06T16:02:31.196671+03:00 proxmox kernel: [  754.480488]  <IRQ>
2024-09-06T16:02:31.196672+03:00 proxmox kernel: [  754.480878]  dump_stack_lvl+0x76/0xa0
2024-09-06T16:02:31.196673+03:00 proxmox kernel: [  754.481274]  dump_stack+0x10/0x20
2024-09-06T16:02:31.196674+03:00 proxmox kernel: [  754.481661]  __report_bad_irq+0x30/0xd0
2024-09-06T16:02:31.196675+03:00 proxmox kernel: [  754.482043]  note_interrupt+0x2e1/0x320
2024-09-06T16:02:31.196677+03:00 proxmox kernel: [  754.482423]  handle_irq_event+0x79/0x80
2024-09-06T16:02:31.196685+03:00 proxmox kernel: [  754.482802]  handle_fasteoi_irq+0x7d/0x200
2024-09-06T16:02:31.196686+03:00 proxmox kernel: [  754.483179]  __common_interrupt+0x3e/0xb0
2024-09-06T16:02:31.196688+03:00 proxmox kernel: [  754.483556]  common_interrupt+0x9f/0xb0
2024-09-06T16:02:31.196689+03:00 proxmox kernel: [  754.483931]  </IRQ>
2024-09-06T16:02:31.196690+03:00 proxmox kernel: [  754.484297]  <TASK>
2024-09-06T16:02:31.196691+03:00 proxmox kernel: [  754.484663]  asm_common_interrupt+0x27/0x40
2024-09-06T16:02:31.196692+03:00 proxmox kernel: [  754.485032] RIP: 0010:pv_native_safe_halt+0xb/0x10
2024-09-06T16:02:31.196693+03:00 proxmox kernel: [  754.485403] Code: 22 d7 31 ff c3 cc cc cc cc 66 0f 1f 44 00 00 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 66 90 0f 00 2d 29 58 37 00 fb f4 <c3> cc cc cc cc 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 90 83
2024-09-06T16:02:31.196702+03:00 proxmox kernel: [  754.485806] RSP: 0018:ffffb501c029fea0 EFLAGS: 00000246
2024-09-06T16:02:31.196703+03:00 proxmox kernel: [  754.486210] RAX: 0000000000000000 RBX: 0000000000000008 RCX: 0000000000000000
2024-09-06T16:02:31.196704+03:00 proxmox kernel: [  754.486617] RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000000
2024-09-06T16:02:31.196705+03:00 proxmox kernel: [  754.487022] RBP: ffffb501c029fea8 R08: 0000000000000000 R09: 0000000000000000
2024-09-06T16:02:31.196706+03:00 proxmox kernel: [  754.487427] R10: 0000000000000000 R11: 0000000000000000 R12: ffffa0a207fa0000
2024-09-06T16:02:31.196707+03:00 proxmox kernel: [  754.487833] R13: 0000000000000000 R14: 0000000000000000 R15: ffffa0a207fa0000
2024-09-06T16:02:31.196708+03:00 proxmox kernel: [  754.488241]  ? default_idle+0x9/0x30
2024-09-06T16:02:31.196709+03:00 proxmox kernel: [  754.488645]  arch_cpu_idle+0x9/0x10
2024-09-06T16:02:31.196710+03:00 proxmox kernel: [  754.489047]  default_idle_call+0x2c/0xf0
2024-09-06T16:02:31.196711+03:00 proxmox kernel: [  754.489449]  do_idle+0x216/0x260
2024-09-06T16:02:31.196712+03:00 proxmox kernel: [  754.489852]  cpu_startup_entry+0x2a/0x30
2024-09-06T16:02:31.196712+03:00 proxmox kernel: [  754.490252]  start_secondary+0x119/0x140
2024-09-06T16:02:31.196713+03:00 proxmox kernel: [  754.490653]  secondary_startup_64_no_verify+0x184/0x18b
2024-09-06T16:02:31.196714+03:00 proxmox kernel: [  754.491059]  </TASK>
2024-09-06T16:02:31.196715+03:00 proxmox kernel: [  754.491453] handlers:
2024-09-06T16:02:31.196716+03:00 proxmox kernel: [  754.491846] [<000000009e36e508>] i801_isr [i2c_i801]
2024-09-06T16:02:31.196717+03:00 proxmox kernel: [  754.492249] Disabling IRQ #16


________________________________________
From: Alex Williamson <alex.williamson@redhat.com>
Sent: Thursday, September 12, 2024 1:12 AM
To: zdravko delineshev <delineshev@outlook.com>
Cc: Bjorn Helgaas <helgaas@kernel.org>; linux-pci@vger.kernel.org <linux-pci@vger.kernel.org>; kvm@vger.kernel.org <kvm@vger.kernel.org>
Subject: Re: nointxmask device
 
On Tue, 10 Sep 2024 08:49:18 -0500
Bjorn Helgaas <helgaas@kernel.org> wrote:

> [+cc Alex, kvm]
>
> On Tue, Sep 10, 2024 at 01:13:41PM +0000, zdravko delineshev wrote:
> >
> > Hello,
> >
> > i found a note in the vfio-pci parameters to email devices fixed by the nointxmask parameter.
> >
> > Here is the one i have and i am trying to pass trough. it is currently working fine, with nointxmask=1 .

What are the symptoms without using nointxmask=1?  Please provide any
dmesg snippets in the host related to using this device.

> > 81:00.0 Audio device: Creative Labs EMU20k2 [Sound Blaster X-Fi Titanium Series] (rev 03)
> >         Subsystem: Creative Labs EMU20k2 [Sound Blaster X-Fi Titanium Series]
> >         Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr+ Stepping- SERR+ FastB2B- DisINTx-
> >         Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
> >         Latency: 0, Cache Line Size: 32 bytes
> >         Interrupt: pin A routed to IRQ 409
> >         NUMA node: 1
> >         IOMMU group: 23
> >         Region 0: Memory at d3200000 (64-bit, non-prefetchable) [size=64K]
> >         Region 2: Memory at d3000000 (64-bit, non-prefetchable) [size=2M]
> >         Region 4: Memory at d2000000 (64-bit, non-prefetchable) [size=16M]
> >         Capabilities: [40] Power Management version 3
> >                 Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA PME(D0-,D1-,D2-,D3hot-,D3cold-)
> >                 Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=0 PME-
> >         Capabilities: [48] MSI: Enable- Count=1/1 Maskable- 64bit+
> >                 Address: 0000000000000000  Data: 0000

The device supports MSI, but the snd-ctxfs driver we have in the Linux
kernel has no support for it, therefore reporting zero for the INTx pin
is not an option.

Are you able to verify a kernel patch?

Adding it to the existing broken INTx quirk should simply be:

diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index a2ce4e08edf5..c7596e9aabb0 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -3608,6 +3608,8 @@ DECLARE_PCI_FIXUP_FINAL(0x1814, 0x0601, /* Ralink RT2800 802.11n PCI */
                         quirk_broken_intx_masking);
 DECLARE_PCI_FIXUP_FINAL(0x1b7c, 0x0004, /* Ceton InfiniTV4 */
                         quirk_broken_intx_masking);
+DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_CREATIVE, PCI_DEVICE_ID_CREATIVE_20K2,
+                       quirk_broken_intx_masking);
 
 /*
  * Realtek RTL8169 PCI Gigabit Ethernet Controller (rev 10)


Thanks,
Alex

> >         Capabilities: [58] Express (v2) Endpoint, MSI 00
> >                 DevCap: MaxPayload 128 bytes, PhantFunc 0, Latency L0s <64ns, L1 <1us
> >                         ExtTag- AttnBtn- AttnInd- PwrInd- RBE+ FLReset- SlotPowerLimit 0W
> >                 DevCtl: CorrErr- NonFatalErr- FatalErr+ UnsupReq-
> >                         RlxdOrd+ ExtTag- PhantFunc- AuxPwr+ NoSnoop+
> >                         MaxPayload 128 bytes, MaxReadReq 512 bytes
> >                 DevSta: CorrErr- NonFatalErr- FatalErr- UnsupReq- AuxPwr- TransPend-
> >                 LnkCap: Port #0, Speed 2.5GT/s, Width x1, ASPM L0s L1, Exit Latency L0s <64ns, L1 <1us
> >                         ClockPM- Surprise- LLActRep- BwNot- ASPMOptComp-
> >                 LnkCtl: ASPM Disabled; RCB 64 bytes, Disabled- CommClk-
> >                         ExtSynch- ClockPM- AutWidDis- BWInt- AutBWInt-
> >                 LnkSta: Speed 2.5GT/s, Width x1
> >                         TrErr- Train- SlotClk- DLActive- BWMgmt- ABWMgmt-
> >                 DevCap2: Completion Timeout: Range ABCD, TimeoutDis- NROPrPrP- LTR-
> >                          10BitTagComp- 10BitTagReq- OBFF Not Supported, ExtFmt- EETLPPrefix-
> >                          EmergencyPowerReduction Not Supported, EmergencyPowerReductionInit-
> >                          FRS- TPHComp- ExtTPHComp-
> >                          AtomicOpsCap: 32bit- 64bit- 128bitCAS-
> >                 DevCtl2: Completion Timeout: 50us to 50ms, TimeoutDis- LTR- 10BitTagReq- OBFF Disabled,
> >                          AtomicOpsCtl: ReqEn-
> >                 LnkCtl2: Target Link Speed: 2.5GT/s, EnterCompliance- SpeedDis-
> >                          Transmit Margin: Normal Operating Range, EnterModifiedCompliance- ComplianceSOS-
> >                          Compliance Preset/De-emphasis: -6dB de-emphasis, 0dB preshoot
> >                 LnkSta2: Current De-emphasis Level: -6dB, EqualizationComplete- EqualizationPhase1-
> >                          EqualizationPhase2- EqualizationPhase3- LinkEqualizationRequest-
> >                          Retimer- 2Retimers- CrosslinkRes: unsupported
> >         Capabilities: [100 v1] Device Serial Number ff-ff-ff-ff-ff-ff-ff-ff
> >         Capabilities: [300 v1] Advanced Error Reporting
> >                 UESta:  DLP- SDES- TLP- FCP- CmpltTO- CmpltAbrt- UnxCmplt- RxOF- MalfTLP- ECRC- UnsupReq- ACSViol-
> >                 UEMsk:  DLP- SDES+ TLP- FCP- CmpltTO- CmpltAbrt- UnxCmplt- RxOF- MalfTLP- ECRC- UnsupReq+ ACSViol-
> >                 UESvrt: DLP+ SDES+ TLP- FCP+ CmpltTO- CmpltAbrt- UnxCmplt- RxOF+ MalfTLP+ ECRC- UnsupReq- ACSViol-
> >                 CESta:  RxErr- BadTLP- BadDLLP- Rollover- Timeout- AdvNonFatalErr+
> >                 CEMsk:  RxErr- BadTLP- BadDLLP- Rollover- Timeout- AdvNonFatalErr+
> >                 AERCap: First Error Pointer: 00, ECRCGenCap+ ECRCGenEn- ECRCChkCap+ ECRCChkEn-
> >                         MultHdrRecCap- MultHdrRecEn- TLPPfxPres- HdrLogCap-
> >                 HeaderLog: 00000000 00000000 00000000 00000000
> >         Kernel driver in use: vfio-pci
> >         Kernel modules: snd_ctxfi
> > 00: 02 11 0b 00 46 01 10 00 03 00 03 04 08 00 00 00
> > 10: 04 00 20 d3 00 00 00 00 04 00 00 d3 00 00 00 00
> > 20: 04 00 00 d2 00 00 00 00 00 00 00 00 02 11 44 00
> > 30: 00 00 00 00 40 00 00 00 00 00 00 00 0b 01 00 00
> > 40: 01 48 03 00 00 00 00 00 05 58 80 00 00 00 00 00
> > 50: 00 00 00 00 00 00 00 00 10 00 02 00 00 80 00 00
> > 60: 14 2c 20 00 11 0c 00 00 00 00 11 00 00 00 00 00
> > 70: 00 00 00 00 00 00 00 00 00 00 00 00 0f 00 00 00
> > 80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> > 90: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> > a0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> > b0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> > c0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> > d0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> > e0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> > f0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 
>

^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-09-12 19:52 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <VI1PR10MB8207C507DB5420AB4C7281E0DB9A2@VI1PR10MB8207.EURPRD10.PROD.OUTLOOK.COM>
2024-09-10 13:49 ` nointxmask device Bjorn Helgaas
2024-09-11 22:12   ` Alex Williamson
2024-09-12 19:52     ` zdravko delineshev

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox