* [PATCH v1 1/1] s390/kvm: initialize uninitialized flags variable
@ 2024-10-30 16:19 Claudio Imbrenda
2024-10-30 17:04 ` Heiko Carstens
2024-11-04 9:43 ` Janosch Frank
0 siblings, 2 replies; 3+ messages in thread
From: Claudio Imbrenda @ 2024-10-30 16:19 UTC (permalink / raw)
To: linux-kernel
Cc: borntraeger, nsg, nrb, frankja, seiden, hca, agordeev, gor,
gerald.schaefer, kvm, linux-s390
The flags variable was being used uninitialized.
Initialize it to 0 as expected.
For some reason neither gcc nor clang reported a warning.
Fixes: ce2b276ebe51 ("s390/mm/fault: Handle guest-related program interrupts in KVM")
Reported-by: Janosch Frank <frankja@linux.ibm.com>
Signed-off-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
---
arch/s390/kvm/kvm-s390.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
index a5750c14bb4d..8b3afda99397 100644
--- a/arch/s390/kvm/kvm-s390.c
+++ b/arch/s390/kvm/kvm-s390.c
@@ -4729,8 +4729,8 @@ static int vcpu_post_run_addressing_exception(struct kvm_vcpu *vcpu)
static int vcpu_post_run_handle_fault(struct kvm_vcpu *vcpu)
{
+ unsigned int flags = 0;
unsigned long gaddr;
- unsigned int flags;
int rc = 0;
gaddr = current->thread.gmap_teid.addr * PAGE_SIZE;
--
2.47.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/1] s390/kvm: initialize uninitialized flags variable
2024-10-30 16:19 [PATCH v1 1/1] s390/kvm: initialize uninitialized flags variable Claudio Imbrenda
@ 2024-10-30 17:04 ` Heiko Carstens
2024-11-04 9:43 ` Janosch Frank
1 sibling, 0 replies; 3+ messages in thread
From: Heiko Carstens @ 2024-10-30 17:04 UTC (permalink / raw)
To: Claudio Imbrenda
Cc: linux-kernel, borntraeger, nsg, nrb, frankja, seiden, agordeev,
gor, gerald.schaefer, kvm, linux-s390
On Wed, Oct 30, 2024 at 05:19:06PM +0100, Claudio Imbrenda wrote:
> The flags variable was being used uninitialized.
> Initialize it to 0 as expected.
>
> For some reason neither gcc nor clang reported a warning.
>
> Fixes: ce2b276ebe51 ("s390/mm/fault: Handle guest-related program interrupts in KVM")
> Reported-by: Janosch Frank <frankja@linux.ibm.com>
> Signed-off-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
> ---
> arch/s390/kvm/kvm-s390.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1 1/1] s390/kvm: initialize uninitialized flags variable
2024-10-30 16:19 [PATCH v1 1/1] s390/kvm: initialize uninitialized flags variable Claudio Imbrenda
2024-10-30 17:04 ` Heiko Carstens
@ 2024-11-04 9:43 ` Janosch Frank
1 sibling, 0 replies; 3+ messages in thread
From: Janosch Frank @ 2024-11-04 9:43 UTC (permalink / raw)
To: Claudio Imbrenda, linux-kernel
Cc: borntraeger, nsg, nrb, seiden, hca, agordeev, gor,
gerald.schaefer, kvm, linux-s390
On 10/30/24 5:19 PM, Claudio Imbrenda wrote:
> The flags variable was being used uninitialized.
> Initialize it to 0 as expected.
>
> For some reason neither gcc nor clang reported a warning.
>
> Fixes: ce2b276ebe51 ("s390/mm/fault: Handle guest-related program interrupts in KVM")
> Reported-by: Janosch Frank <frankja@linux.ibm.com>
> Signed-off-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
Thanks for tracking this down, tprot selftest is green with this fix.
Reviewed-by: Janosch Frank <frankja@linux.ibm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-11-04 9:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-30 16:19 [PATCH v1 1/1] s390/kvm: initialize uninitialized flags variable Claudio Imbrenda
2024-10-30 17:04 ` Heiko Carstens
2024-11-04 9:43 ` Janosch Frank
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox