From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Pedro Barbuda" <pbarbuda@microsoft.com>,
"Alexander Graf" <agraf@csgraf.de>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Mohamed Mediouni" <mohamed@unpredictable.fr>,
kvm@vger.kernel.org, qemu-arm@nongnu.org,
"Alex Bennée" <alex.bennee@linaro.org>,
"Richard Henderson" <richard.henderson@linaro.org>
Subject: [PATCH v3 21/32] target/arm: use syndrome helpers to query VNCR bit
Date: Wed, 22 Apr 2026 13:52:38 +0100 [thread overview]
Message-ID: <20260422125250.1303100-22-alex.bennee@linaro.org> (raw)
In-Reply-To: <20260422125250.1303100-1-alex.bennee@linaro.org>
These are only valid for data abort syndromes.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
target/arm/tcg/tlb_helper.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/target/arm/tcg/tlb_helper.c b/target/arm/tcg/tlb_helper.c
index c74d8e785a6..bbe1e70bc43 100644
--- a/target/arm/tcg/tlb_helper.c
+++ b/target/arm/tcg/tlb_helper.c
@@ -48,7 +48,7 @@ static inline uint64_t merge_syn_data_abort(uint32_t template_syn,
* ST64BV, or ST64BV0 insns report syndrome info even for stage-1
* faults and regardless of the target EL.
*/
- if (template_syn & ARM_EL_VNCR) {
+ if (FIELD_EX32(template_syn, DABORT_ISS, VNCR)) {
/*
* FEAT_NV2 faults on accesses via VNCR_EL2 are a special case:
* they are always reported as "same EL", even though we are going
@@ -190,7 +190,7 @@ void arm_deliver_fault(ARMCPU *cpu, vaddr addr,
* because we masked that out in disas_set_insn_syndrome())
*/
bool is_vncr = (access_type != MMU_INST_FETCH) &&
- (env->exception.syndrome & ARM_EL_VNCR);
+ FIELD_EX32(env->exception.syndrome, DABORT_ISS, VNCR);
if (is_vncr) {
/* FEAT_NV2 faults on accesses via VNCR_EL2 go to EL2 */
--
2.47.3
next prev parent reply other threads:[~2026-04-22 13:02 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-22 12:52 [PATCH v3 00/32] target/arm: fully model WFxT instructions for A-profile Alex Bennée
2026-04-22 12:52 ` [PATCH v3 01/32] target/arm: migrate basic syndrome helpers to registerfields Alex Bennée
2026-04-22 12:52 ` [PATCH v3 02/32] target/arm: migrate system/cp trap syndromes " Alex Bennée
2026-04-22 12:52 ` [PATCH v3 03/32] target/arm: migrate FP/SIMD " Alex Bennée
2026-04-22 12:52 ` [PATCH v3 04/32] target/arm: migrate eret " Alex Bennée
2026-04-22 12:52 ` [PATCH v3 05/32] target/arm: migrate SME " Alex Bennée
2026-04-22 12:52 ` [PATCH v3 06/32] target/arm: migrate PAC " Alex Bennée
2026-04-22 12:52 ` [PATCH v3 07/32] target/arm: migrate BTI " Alex Bennée
2026-04-22 12:52 ` [PATCH v3 08/32] target/arm: migrate BXJ " Alex Bennée
2026-04-22 12:52 ` [PATCH v3 09/32] target/arm: migrate Granule Protection traps " Alex Bennée
2026-04-22 12:52 ` [PATCH v3 10/32] target/arm: migrate fault syndromes " Alex Bennée
2026-04-22 16:54 ` Philippe Mathieu-Daudé
2026-04-22 12:52 ` [PATCH v3 11/32] target/arm: migrate debug " Alex Bennée
2026-04-22 12:52 ` [PATCH v3 12/32] target/arm: migrate wfx " Alex Bennée
2026-04-22 12:52 ` [PATCH v3 13/32] target/arm: migrate gcs " Alex Bennée
2026-04-22 12:52 ` [PATCH v3 14/32] target/arm: migrate memory op " Alex Bennée
2026-04-22 12:52 ` [PATCH v3 15/32] target/arm: migrate check_hcr_el2_trap to use syndrome helper Alex Bennée
2026-04-22 12:52 ` [PATCH v3 16/32] target/arm: use syndrome helpers in arm_cpu_do_interrupt_aarch32_hyp Alex Bennée
2026-04-22 12:52 ` [PATCH v3 17/32] target/arm: use syndrome helpers to set SAME_EL EC bit Alex Bennée
2026-04-22 12:52 ` [PATCH v3 18/32] target/arm: make whpx use syndrome helpers for decode Alex Bennée
2026-04-22 12:52 ` [PATCH v3 19/32] target/arm: make hvf " Alex Bennée
2026-04-22 16:54 ` Philippe Mathieu-Daudé
2026-04-22 12:52 ` [PATCH v3 20/32] target/arm: use syndrome helpers in merge_syn_data_abort Alex Bennée
2026-04-22 12:52 ` Alex Bennée [this message]
2026-04-22 12:52 ` [PATCH v3 22/32] target/arm: remove old syndrome defines Alex Bennée
2026-04-22 12:52 ` [PATCH v3 23/32] target/arm: report register in WFIT syndromes Alex Bennée
2026-04-22 12:52 ` [PATCH v3 24/32] target/arm: teach arm_cpu_has_work about halting reasons Alex Bennée
2026-04-22 12:52 ` [PATCH v3 25/32] target/arm: redefine event stream fields Alex Bennée
2026-04-22 12:52 ` [PATCH v3 26/32] target/arm: ensure aarch64 DISAS_WFE will exit Alex Bennée
2026-04-22 16:57 ` Philippe Mathieu-Daudé
2026-04-22 12:52 ` [PATCH v3 27/32] target/arm: implements SEV/SEVL for all modes Alex Bennée
2026-04-22 12:52 ` [PATCH v3 28/32] target/arm: hoist event broadcast code into a helper Alex Bennée
2026-04-22 12:52 ` [PATCH v3 29/32] target/arm: implement global monitor events Alex Bennée
2026-04-22 12:52 ` [PATCH v3 30/32] target/arm: enable event stream on WFE instructions Alex Bennée
2026-04-22 12:52 ` [PATCH v3 31/32] target/arm: handle the WFE trap case Alex Bennée
2026-04-22 12:52 ` [PATCH v3 32/32] target/arm: implement WFET Alex Bennée
2026-04-24 18:20 ` [PATCH v3 00/32] target/arm: fully model WFxT instructions for A-profile Alex Bennée
2026-04-27 10:47 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260422125250.1303100-22-alex.bennee@linaro.org \
--to=alex.bennee@linaro.org \
--cc=agraf@csgraf.de \
--cc=kvm@vger.kernel.org \
--cc=mohamed@unpredictable.fr \
--cc=pbarbuda@microsoft.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox