Re: [PATCH v3 26/32] target/arm: ensure aarch64 DISAS_WFE will exit

["Philippe Mathieu-Daudé" <philmd@linaro.org>]

On 22/4/26 14:52, Alex Bennée wrote:
> This mirrors the logic for DISAS_WFE in 32 bit world.
> 
> Fixes: 252ec405768 (target-arm: implement WFE/YIELD as a yield for AArch64)
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>   target/arm/tcg/translate-a64.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/target/arm/tcg/translate-a64.c b/target/arm/tcg/translate-a64.c
> index 073454b9195..d79c8ab431b 100644
> --- a/target/arm/tcg/translate-a64.c
> +++ b/target/arm/tcg/translate-a64.c
> @@ -10917,6 +10917,7 @@ static void aarch64_tr_tb_stop(DisasContextBase *dcbase, CPUState *cpu)
>           case DISAS_WFE:
>               gen_a64_update_pc(dc, 4);
>               gen_helper_wfe(tcg_env);

If we mirror the logic we can also mirror the comment,
otherwise the description rationale isn't very helping:

             /*
              * The helper can return if the event register is set, so we
              * must go back to the main loop to check for events.
              */

> +            tcg_gen_exit_tb(NULL, 0);
>               break;
>           case DISAS_YIELD:
>               gen_a64_update_pc(dc, 4);

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>