* Re: [PATCH 6.18 091/270] LoongArch: KVM: Compile switch.S directly into the kernel [not found] <20260512173940.376401154@linuxfoundation.org> @ 2026-05-12 20:52 ` Miguel Ojeda 2026-05-12 21:53 ` Sean Christopherson 0 siblings, 1 reply; 8+ messages in thread From: Miguel Ojeda @ 2026-05-12 20:52 UTC (permalink / raw) To: gregkh, Tianrui Zhao, Bibo Mao, Huacai Chen Cc: kvm, loongarch, Sean Christopherson, Dave Hansen, chenhuacai, lixianglai, patches, stable On Tue, 12 May 2026 19:38:12 +0200 Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > > 6.18-stable review patch. If anyone has any objections, please let me know. > > ------------------ > > From: Xianglai Li <lixianglai@loongson.cn> > > commit 5203012fa6045aac4b69d4e7c212e16dcf38ef10 upstream. > > If we directly compile the switch.S file into the kernel, the address of > the kvm_exc_entry function will definitely be within the DMW memory area. > Therefore, we will no longer need to perform a copy relocation of the > kvm_exc_entry. > > So this patch compiles switch.S directly into the kernel, and then remove > the copy relocation execution logic for the kvm_exc_entry function. > > Cc: stable@vger.kernel.org > Signed-off-by: Xianglai Li <lixianglai@loongson.cn> > Signed-off-by: Huacai Chen <chenhuacai@loongson.cn> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> For loongarch64, I am seeing a bunch of errors like: arch/loongarch/kvm/switch.S:201:1: error: unrecognized instruction mnemonic EXPORT_SYMBOL_FOR_KVM(kvm_exc_entry) ^ `EXPORT_SYMBOL_FOR_KVM` does not exist in 6.18. Does this need a subset of commit 6276c67f2bc4 ("x86: Restrict KVM-induced symbol exports to KVM modules where obvious/possible")? Cc'ing a few folks... Thanks! Cheers, Miguel ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 6.18 091/270] LoongArch: KVM: Compile switch.S directly into the kernel 2026-05-12 20:52 ` [PATCH 6.18 091/270] LoongArch: KVM: Compile switch.S directly into the kernel Miguel Ojeda @ 2026-05-12 21:53 ` Sean Christopherson 2026-05-13 3:06 ` Huacai Chen 0 siblings, 1 reply; 8+ messages in thread From: Sean Christopherson @ 2026-05-12 21:53 UTC (permalink / raw) To: Miguel Ojeda Cc: gregkh, Tianrui Zhao, Bibo Mao, Huacai Chen, kvm, loongarch, Dave Hansen, chenhuacai, lixianglai, patches, stable On Tue, May 12, 2026, Miguel Ojeda wrote: > On Tue, 12 May 2026 19:38:12 +0200 Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > > > > 6.18-stable review patch. If anyone has any objections, please let me know. > > > > ------------------ > > > > From: Xianglai Li <lixianglai@loongson.cn> > > > > commit 5203012fa6045aac4b69d4e7c212e16dcf38ef10 upstream. > > > > If we directly compile the switch.S file into the kernel, the address of > > the kvm_exc_entry function will definitely be within the DMW memory area. > > Therefore, we will no longer need to perform a copy relocation of the > > kvm_exc_entry. > > > > So this patch compiles switch.S directly into the kernel, and then remove > > the copy relocation execution logic for the kvm_exc_entry function. > > > > Cc: stable@vger.kernel.org > > Signed-off-by: Xianglai Li <lixianglai@loongson.cn> > > Signed-off-by: Huacai Chen <chenhuacai@loongson.cn> > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > For loongarch64, I am seeing a bunch of errors like: > > arch/loongarch/kvm/switch.S:201:1: error: unrecognized instruction mnemonic > EXPORT_SYMBOL_FOR_KVM(kvm_exc_entry) > ^ > > `EXPORT_SYMBOL_FOR_KVM` does not exist in 6.18. Does this need a subset > of commit 6276c67f2bc4 ("x86: Restrict KVM-induced symbol exports to KVM > modules where obvious/possible")? Either that or just convert EXPORT_SYMBOL_FOR_KVM() => EXPORT_SYMBOL_GPL(). If that's somewhat scriptable for ongoing LTS backports, that's probably the best option. EXPORT_SYMBOL_FOR_KVM() will only work for 6.18, and the list of backports needed to get EXPORT_SYMBOL_FOR_MODULES() working on older LTS kernels looks to be non-trivial If we do end up backporting EXPORT_SYMBOL_FOR_KVM() and others, we might as well also grab a subset of 01122b89361e ("perf: Use EXPORT_SYMBOL_FOR_KVM() for the mediated APIs") to ensure a kvm_types.h stub is present on all archs. That way EXPORT_SYMBOL_FOR_KVM() usage in arch-neutral code will also work. diff --git include/asm-generic/Kbuild include/asm-generic/Kbuild index 295c94a3ccc1..9aff61e7b8f2 100644 --- include/asm-generic/Kbuild +++ include/asm-generic/Kbuild @@ -32,6 +32,7 @@ mandatory-y += irq_work.h mandatory-y += kdebug.h mandatory-y += kmap_size.h mandatory-y += kprobes.h +mandatory-y += kvm_types.h mandatory-y += linkage.h mandatory-y += local.h mandatory-y += local64.h ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 6.18 091/270] LoongArch: KVM: Compile switch.S directly into the kernel 2026-05-12 21:53 ` Sean Christopherson @ 2026-05-13 3:06 ` Huacai Chen 2026-05-13 10:31 ` Greg KH 0 siblings, 1 reply; 8+ messages in thread From: Huacai Chen @ 2026-05-13 3:06 UTC (permalink / raw) To: Sean Christopherson Cc: Miguel Ojeda, gregkh, Tianrui Zhao, Bibo Mao, kvm, loongarch, Dave Hansen, chenhuacai, lixianglai, patches, stable On Wed, May 13, 2026 at 5:53 AM Sean Christopherson <seanjc@google.com> wrote: > > On Tue, May 12, 2026, Miguel Ojeda wrote: > > On Tue, 12 May 2026 19:38:12 +0200 Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > > > > > > 6.18-stable review patch. If anyone has any objections, please let me know. > > > > > > ------------------ > > > > > > From: Xianglai Li <lixianglai@loongson.cn> > > > > > > commit 5203012fa6045aac4b69d4e7c212e16dcf38ef10 upstream. > > > > > > If we directly compile the switch.S file into the kernel, the address of > > > the kvm_exc_entry function will definitely be within the DMW memory area. > > > Therefore, we will no longer need to perform a copy relocation of the > > > kvm_exc_entry. > > > > > > So this patch compiles switch.S directly into the kernel, and then remove > > > the copy relocation execution logic for the kvm_exc_entry function. > > > > > > Cc: stable@vger.kernel.org > > > Signed-off-by: Xianglai Li <lixianglai@loongson.cn> > > > Signed-off-by: Huacai Chen <chenhuacai@loongson.cn> > > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > > > For loongarch64, I am seeing a bunch of errors like: > > > > arch/loongarch/kvm/switch.S:201:1: error: unrecognized instruction mnemonic > > EXPORT_SYMBOL_FOR_KVM(kvm_exc_entry) > > ^ > > > > `EXPORT_SYMBOL_FOR_KVM` does not exist in 6.18. Does this need a subset > > of commit 6276c67f2bc4 ("x86: Restrict KVM-induced symbol exports to KVM > > modules where obvious/possible")? > > Either that or just convert EXPORT_SYMBOL_FOR_KVM() => EXPORT_SYMBOL_GPL(). If > that's somewhat scriptable for ongoing LTS backports, that's probably the best > option. EXPORT_SYMBOL_FOR_KVM() will only work for 6.18, and the list of backports > needed to get EXPORT_SYMBOL_FOR_MODULES() working on older LTS kernels looks to > be non-trivial > > If we do end up backporting EXPORT_SYMBOL_FOR_KVM() and others, we might as well > also grab a subset of 01122b89361e ("perf: Use EXPORT_SYMBOL_FOR_KVM() for the > mediated APIs") to ensure a kvm_types.h stub is present on all archs. That way > EXPORT_SYMBOL_FOR_KVM() usage in arch-neutral code will also work. I have already noticed Greg about this before. And I think the best solution is to use EXPORT_SYMBOL_GPL(). If Greg doesn't want to adjust manually, please drop this patch and I will send one. Huacai > > diff --git include/asm-generic/Kbuild include/asm-generic/Kbuild > index 295c94a3ccc1..9aff61e7b8f2 100644 > --- include/asm-generic/Kbuild > +++ include/asm-generic/Kbuild > @@ -32,6 +32,7 @@ mandatory-y += irq_work.h > mandatory-y += kdebug.h > mandatory-y += kmap_size.h > mandatory-y += kprobes.h > +mandatory-y += kvm_types.h > mandatory-y += linkage.h > mandatory-y += local.h > mandatory-y += local64.h > > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 6.18 091/270] LoongArch: KVM: Compile switch.S directly into the kernel 2026-05-13 3:06 ` Huacai Chen @ 2026-05-13 10:31 ` Greg KH 2026-05-13 11:58 ` Wentao Guan 0 siblings, 1 reply; 8+ messages in thread From: Greg KH @ 2026-05-13 10:31 UTC (permalink / raw) To: Huacai Chen Cc: Sean Christopherson, Miguel Ojeda, Tianrui Zhao, Bibo Mao, kvm, loongarch, Dave Hansen, chenhuacai, lixianglai, patches, stable On Wed, May 13, 2026 at 11:06:20AM +0800, Huacai Chen wrote: > On Wed, May 13, 2026 at 5:53 AM Sean Christopherson <seanjc@google.com> wrote: > > > > On Tue, May 12, 2026, Miguel Ojeda wrote: > > > On Tue, 12 May 2026 19:38:12 +0200 Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > > > > > > > > 6.18-stable review patch. If anyone has any objections, please let me know. > > > > > > > > ------------------ > > > > > > > > From: Xianglai Li <lixianglai@loongson.cn> > > > > > > > > commit 5203012fa6045aac4b69d4e7c212e16dcf38ef10 upstream. > > > > > > > > If we directly compile the switch.S file into the kernel, the address of > > > > the kvm_exc_entry function will definitely be within the DMW memory area. > > > > Therefore, we will no longer need to perform a copy relocation of the > > > > kvm_exc_entry. > > > > > > > > So this patch compiles switch.S directly into the kernel, and then remove > > > > the copy relocation execution logic for the kvm_exc_entry function. > > > > > > > > Cc: stable@vger.kernel.org > > > > Signed-off-by: Xianglai Li <lixianglai@loongson.cn> > > > > Signed-off-by: Huacai Chen <chenhuacai@loongson.cn> > > > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > > > > > For loongarch64, I am seeing a bunch of errors like: > > > > > > arch/loongarch/kvm/switch.S:201:1: error: unrecognized instruction mnemonic > > > EXPORT_SYMBOL_FOR_KVM(kvm_exc_entry) > > > ^ > > > > > > `EXPORT_SYMBOL_FOR_KVM` does not exist in 6.18. Does this need a subset > > > of commit 6276c67f2bc4 ("x86: Restrict KVM-induced symbol exports to KVM > > > modules where obvious/possible")? > > > > Either that or just convert EXPORT_SYMBOL_FOR_KVM() => EXPORT_SYMBOL_GPL(). If > > that's somewhat scriptable for ongoing LTS backports, that's probably the best > > option. EXPORT_SYMBOL_FOR_KVM() will only work for 6.18, and the list of backports > > needed to get EXPORT_SYMBOL_FOR_MODULES() working on older LTS kernels looks to > > be non-trivial > > > > If we do end up backporting EXPORT_SYMBOL_FOR_KVM() and others, we might as well > > also grab a subset of 01122b89361e ("perf: Use EXPORT_SYMBOL_FOR_KVM() for the > > mediated APIs") to ensure a kvm_types.h stub is present on all archs. That way > > EXPORT_SYMBOL_FOR_KVM() usage in arch-neutral code will also work. > I have already noticed Greg about this before. You did? Where? > And I think the best solution is to use EXPORT_SYMBOL_GPL(). > > If Greg doesn't want to adjust manually, please drop this patch and I > will send one. I'll go drop this one from the queue. thanks, greg k-h ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Re: [PATCH 6.18 091/270] LoongArch: KVM: Compile switch.S directly into the kernel 2026-05-13 10:31 ` Greg KH @ 2026-05-13 11:58 ` Wentao Guan 2026-05-13 12:04 ` Greg KH 0 siblings, 1 reply; 8+ messages in thread From: Wentao Guan @ 2026-05-13 11:58 UTC (permalink / raw) To: gregkh Cc: chenhuacai, chenhuacai, dave.hansen, kvm, lixianglai, loongarch, maobibo, ojeda, patches, seanjc, stable, zhaotianrui Hello, > On Wed, May 13, 2026 at 11:06:20AM +0800, Huacai Chen wrote: > > On Wed, May 13, 2026 at 5:53 AM Sean Christopherson <seanjc@google.com> wrote: > > > > > > On Tue, May 12, 2026, Miguel Ojeda wrote: > > > > On Tue, 12 May 2026 19:38:12 +0200 Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > > > > > > > > > > 6.18-stable review patch. If anyone has any objections, please let me know. > > > > > > > > > > ------------------ > > > > > > > > > > From: Xianglai Li <lixianglai@loongson.cn> > > > > > > > > > > commit 5203012fa6045aac4b69d4e7c212e16dcf38ef10 upstream. > > > > > > > > > > If we directly compile the switch.S file into the kernel, the address of > > > > > the kvm_exc_entry function will definitely be within the DMW memory area. > > > > > Therefore, we will no longer need to perform a copy relocation of the > > > > > kvm_exc_entry. > > > > > > > > > > So this patch compiles switch.S directly into the kernel, and then remove > > > > > the copy relocation execution logic for the kvm_exc_entry function. > > > > > > > > > > Cc: stable@vger.kernel.org > > > > > Signed-off-by: Xianglai Li <lixianglai@loongson.cn> > > > > > Signed-off-by: Huacai Chen <chenhuacai@loongson.cn> > > > > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > > > > > > > For loongarch64, I am seeing a bunch of errors like: > > > > > > > > arch/loongarch/kvm/switch.S:201:1: error: unrecognized instruction mnemonic > > > > EXPORT_SYMBOL_FOR_KVM(kvm_exc_entry) > > > > ^ > > > > > > > > `EXPORT_SYMBOL_FOR_KVM` does not exist in 6.18. Does this need a subset > > > > of commit 6276c67f2bc4 ("x86: Restrict KVM-induced symbol exports to KVM > > > > modules where obvious/possible")? > > > > > > Either that or just convert EXPORT_SYMBOL_FOR_KVM() => EXPORT_SYMBOL_GPL(). If > > > that's somewhat scriptable for ongoing LTS backports, that's probably the best > > > option. EXPORT_SYMBOL_FOR_KVM() will only work for 6.18, and the list of backports > > > needed to get EXPORT_SYMBOL_FOR_MODULES() working on older LTS kernels looks to > > > be non-trivial > > > > > > If we do end up backporting EXPORT_SYMBOL_FOR_KVM() and others, we might as well > > > also grab a subset of 01122b89361e ("perf: Use EXPORT_SYMBOL_FOR_KVM() for the > > > mediated APIs") to ensure a kvm_types.h stub is present on all archs. That way > > > EXPORT_SYMBOL_FOR_KVM() usage in arch-neutral code will also work. > > I have already noticed Greg about this before. > > You did? Where? Small problem, I guess where he means is 'stable-commits@vger.kernel.org', is a not public maillist? I want to find it in 'lore.kernel.org' but not found... BRs Wentao Guan ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Re: [PATCH 6.18 091/270] LoongArch: KVM: Compile switch.S directly into the kernel 2026-05-13 11:58 ` Wentao Guan @ 2026-05-13 12:04 ` Greg KH 2026-05-13 12:08 ` Wentao Guan 0 siblings, 1 reply; 8+ messages in thread From: Greg KH @ 2026-05-13 12:04 UTC (permalink / raw) To: Wentao Guan Cc: chenhuacai, chenhuacai, dave.hansen, kvm, lixianglai, loongarch, maobibo, ojeda, patches, seanjc, stable, zhaotianrui On Wed, May 13, 2026 at 07:58:10PM +0800, Wentao Guan wrote: > Hello, > > > On Wed, May 13, 2026 at 11:06:20AM +0800, Huacai Chen wrote: > > > On Wed, May 13, 2026 at 5:53 AM Sean Christopherson <seanjc@google.com> wrote: > > > > > > > > On Tue, May 12, 2026, Miguel Ojeda wrote: > > > > > On Tue, 12 May 2026 19:38:12 +0200 Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > > > > > > > > > > > > 6.18-stable review patch. If anyone has any objections, please let me know. > > > > > > > > > > > > ------------------ > > > > > > > > > > > > From: Xianglai Li <lixianglai@loongson.cn> > > > > > > > > > > > > commit 5203012fa6045aac4b69d4e7c212e16dcf38ef10 upstream. > > > > > > > > > > > > If we directly compile the switch.S file into the kernel, the address of > > > > > > the kvm_exc_entry function will definitely be within the DMW memory area. > > > > > > Therefore, we will no longer need to perform a copy relocation of the > > > > > > kvm_exc_entry. > > > > > > > > > > > > So this patch compiles switch.S directly into the kernel, and then remove > > > > > > the copy relocation execution logic for the kvm_exc_entry function. > > > > > > > > > > > > Cc: stable@vger.kernel.org > > > > > > Signed-off-by: Xianglai Li <lixianglai@loongson.cn> > > > > > > Signed-off-by: Huacai Chen <chenhuacai@loongson.cn> > > > > > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > > > > > > > > > For loongarch64, I am seeing a bunch of errors like: > > > > > > > > > > arch/loongarch/kvm/switch.S:201:1: error: unrecognized instruction mnemonic > > > > > EXPORT_SYMBOL_FOR_KVM(kvm_exc_entry) > > > > > ^ > > > > > > > > > > `EXPORT_SYMBOL_FOR_KVM` does not exist in 6.18. Does this need a subset > > > > > of commit 6276c67f2bc4 ("x86: Restrict KVM-induced symbol exports to KVM > > > > > modules where obvious/possible")? > > > > > > > > Either that or just convert EXPORT_SYMBOL_FOR_KVM() => EXPORT_SYMBOL_GPL(). If > > > > that's somewhat scriptable for ongoing LTS backports, that's probably the best > > > > option. EXPORT_SYMBOL_FOR_KVM() will only work for 6.18, and the list of backports > > > > needed to get EXPORT_SYMBOL_FOR_MODULES() working on older LTS kernels looks to > > > > be non-trivial > > > > > > > > If we do end up backporting EXPORT_SYMBOL_FOR_KVM() and others, we might as well > > > > also grab a subset of 01122b89361e ("perf: Use EXPORT_SYMBOL_FOR_KVM() for the > > > > mediated APIs") to ensure a kvm_types.h stub is present on all archs. That way > > > > EXPORT_SYMBOL_FOR_KVM() usage in arch-neutral code will also work. > > > I have already noticed Greg about this before. > > > > You did? Where? > > Small problem, I guess where he means is 'stable-commits@vger.kernel.org', is a > not public maillist? I want to find it in 'lore.kernel.org' but not found... It's a public list, anyone can sign up for it. Don't know if lore archives it, but I'm sure that someone does... thanks, greg k-h ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Re: [PATCH 6.18 091/270] LoongArch: KVM: Compile switch.S directly into the kernel 2026-05-13 12:04 ` Greg KH @ 2026-05-13 12:08 ` Wentao Guan 2026-05-13 15:29 ` Greg KH 0 siblings, 1 reply; 8+ messages in thread From: Wentao Guan @ 2026-05-13 12:08 UTC (permalink / raw) To: gregkh Cc: chenhuacai, chenhuacai, dave.hansen, guanwentao, kvm, lixianglai, loongarch, maobibo, ojeda, patches, seanjc, stable, zhaotianrui > On Wed, May 13, 2026 at 07:58:10PM +0800, Wentao Guan wrote: > > Hello, > > > > > On Wed, May 13, 2026 at 11:06:20AM +0800, Huacai Chen wrote: > > > > On Wed, May 13, 2026 at 5:53 AM Sean Christopherson <seanjc@google.com> wrote: > > > > > > > > > > On Tue, May 12, 2026, Miguel Ojeda wrote: > > > > > > On Tue, 12 May 2026 19:38:12 +0200 Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > > > > > > > > > > > > > > 6.18-stable review patch. If anyone has any objections, please let me know. > > > > > > > > > > > > > > ------------------ > > > > > > > > > > > > > > From: Xianglai Li <lixianglai@loongson.cn> > > > > > > > > > > > > > > commit 5203012fa6045aac4b69d4e7c212e16dcf38ef10 upstream. > > > > > > > > > > > > > > If we directly compile the switch.S file into the kernel, the address of > > > > > > > the kvm_exc_entry function will definitely be within the DMW memory area. > > > > > > > Therefore, we will no longer need to perform a copy relocation of the > > > > > > > kvm_exc_entry. > > > > > > > > > > > > > > So this patch compiles switch.S directly into the kernel, and then remove > > > > > > > the copy relocation execution logic for the kvm_exc_entry function. > > > > > > > > > > > > > > Cc: stable@vger.kernel.org > > > > > > > Signed-off-by: Xianglai Li <lixianglai@loongson.cn> > > > > > > > Signed-off-by: Huacai Chen <chenhuacai@loongson.cn> > > > > > > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > > > > > > > > > > > For loongarch64, I am seeing a bunch of errors like: > > > > > > > > > > > > arch/loongarch/kvm/switch.S:201:1: error: unrecognized instruction mnemonic > > > > > > EXPORT_SYMBOL_FOR_KVM(kvm_exc_entry) > > > > > > ^ > > > > > > > > > > > > `EXPORT_SYMBOL_FOR_KVM` does not exist in 6.18. Does this need a subset > > > > > > of commit 6276c67f2bc4 ("x86: Restrict KVM-induced symbol exports to KVM > > > > > > modules where obvious/possible")? > > > > > > > > > > Either that or just convert EXPORT_SYMBOL_FOR_KVM() => EXPORT_SYMBOL_GPL(). If > > > > > that's somewhat scriptable for ongoing LTS backports, that's probably the best > > > > > option. EXPORT_SYMBOL_FOR_KVM() will only work for 6.18, and the list of backports > > > > > needed to get EXPORT_SYMBOL_FOR_MODULES() working on older LTS kernels looks to > > > > > be non-trivial > > > > > > > > > > If we do end up backporting EXPORT_SYMBOL_FOR_KVM() and others, we might as well > > > > > also grab a subset of 01122b89361e ("perf: Use EXPORT_SYMBOL_FOR_KVM() for the > > > > > mediated APIs") to ensure a kvm_types.h stub is present on all archs. That way > > > > > EXPORT_SYMBOL_FOR_KVM() usage in arch-neutral code will also work. > > > > I have already noticed Greg about this before. > > > > > > You did? Where? > > > > Small problem, I guess where he means is 'stable-commits@vger.kernel.org', is a > > not public maillist? I want to find it in 'lore.kernel.org' but not found... > > It's a public list, anyone can sign up for it. Don't know if lore > archives it, but I'm sure that someone does... Thanks for your reply. It is interesting that now i found them in https://marc.info/?l=linux-stable-commits&m=177859589029820&w=2, and https://marc.info/?l=linux-stable-commits&m=177859840800303 BRs Wentao Guan ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Re: [PATCH 6.18 091/270] LoongArch: KVM: Compile switch.S directly into the kernel 2026-05-13 12:08 ` Wentao Guan @ 2026-05-13 15:29 ` Greg KH 0 siblings, 0 replies; 8+ messages in thread From: Greg KH @ 2026-05-13 15:29 UTC (permalink / raw) To: Wentao Guan Cc: chenhuacai, chenhuacai, dave.hansen, kvm, lixianglai, loongarch, maobibo, ojeda, patches, seanjc, stable, zhaotianrui On Wed, May 13, 2026 at 08:08:08PM +0800, Wentao Guan wrote: > > On Wed, May 13, 2026 at 07:58:10PM +0800, Wentao Guan wrote: > > > Hello, > > > > > > > On Wed, May 13, 2026 at 11:06:20AM +0800, Huacai Chen wrote: > > > > > On Wed, May 13, 2026 at 5:53 AM Sean Christopherson <seanjc@google.com> wrote: > > > > > > > > > > > > On Tue, May 12, 2026, Miguel Ojeda wrote: > > > > > > > On Tue, 12 May 2026 19:38:12 +0200 Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > > > > > > > > > > > > > > > > 6.18-stable review patch. If anyone has any objections, please let me know. > > > > > > > > > > > > > > > > ------------------ > > > > > > > > > > > > > > > > From: Xianglai Li <lixianglai@loongson.cn> > > > > > > > > > > > > > > > > commit 5203012fa6045aac4b69d4e7c212e16dcf38ef10 upstream. > > > > > > > > > > > > > > > > If we directly compile the switch.S file into the kernel, the address of > > > > > > > > the kvm_exc_entry function will definitely be within the DMW memory area. > > > > > > > > Therefore, we will no longer need to perform a copy relocation of the > > > > > > > > kvm_exc_entry. > > > > > > > > > > > > > > > > So this patch compiles switch.S directly into the kernel, and then remove > > > > > > > > the copy relocation execution logic for the kvm_exc_entry function. > > > > > > > > > > > > > > > > Cc: stable@vger.kernel.org > > > > > > > > Signed-off-by: Xianglai Li <lixianglai@loongson.cn> > > > > > > > > Signed-off-by: Huacai Chen <chenhuacai@loongson.cn> > > > > > > > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > > > > > > > > > > > > > For loongarch64, I am seeing a bunch of errors like: > > > > > > > > > > > > > > arch/loongarch/kvm/switch.S:201:1: error: unrecognized instruction mnemonic > > > > > > > EXPORT_SYMBOL_FOR_KVM(kvm_exc_entry) > > > > > > > ^ > > > > > > > > > > > > > > `EXPORT_SYMBOL_FOR_KVM` does not exist in 6.18. Does this need a subset > > > > > > > of commit 6276c67f2bc4 ("x86: Restrict KVM-induced symbol exports to KVM > > > > > > > modules where obvious/possible")? > > > > > > > > > > > > Either that or just convert EXPORT_SYMBOL_FOR_KVM() => EXPORT_SYMBOL_GPL(). If > > > > > > that's somewhat scriptable for ongoing LTS backports, that's probably the best > > > > > > option. EXPORT_SYMBOL_FOR_KVM() will only work for 6.18, and the list of backports > > > > > > needed to get EXPORT_SYMBOL_FOR_MODULES() working on older LTS kernels looks to > > > > > > be non-trivial > > > > > > > > > > > > If we do end up backporting EXPORT_SYMBOL_FOR_KVM() and others, we might as well > > > > > > also grab a subset of 01122b89361e ("perf: Use EXPORT_SYMBOL_FOR_KVM() for the > > > > > > mediated APIs") to ensure a kvm_types.h stub is present on all archs. That way > > > > > > EXPORT_SYMBOL_FOR_KVM() usage in arch-neutral code will also work. > > > > > I have already noticed Greg about this before. > > > > > > > > You did? Where? > > > > > > Small problem, I guess where he means is 'stable-commits@vger.kernel.org', is a > > > not public maillist? I want to find it in 'lore.kernel.org' but not found... > > > > It's a public list, anyone can sign up for it. Don't know if lore > > archives it, but I'm sure that someone does... > > Thanks for your reply. It is interesting that now i found them in > https://marc.info/?l=linux-stable-commits&m=177859589029820&w=2, > and https://marc.info/?l=linux-stable-commits&m=177859840800303 Ah, yeah, I had to delete that message due to that footer, and didn't even look at it on request of the sender as it was confidental information which is not allowed here. thanks, greg k-h ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2026-05-13 15:29 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20260512173940.376401154@linuxfoundation.org>
2026-05-12 20:52 ` [PATCH 6.18 091/270] LoongArch: KVM: Compile switch.S directly into the kernel Miguel Ojeda
2026-05-12 21:53 ` Sean Christopherson
2026-05-13 3:06 ` Huacai Chen
2026-05-13 10:31 ` Greg KH
2026-05-13 11:58 ` Wentao Guan
2026-05-13 12:04 ` Greg KH
2026-05-13 12:08 ` Wentao Guan
2026-05-13 15:29 ` Greg KH
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox