Re: [PATCH 1/2] x86/tdx: Add helper to query maximum TD Quote size

[Peter Fang <peter.fang@intel.com>]

On Fri, Jun 12, 2026 at 01:36:16PM +0100, Kiryl Shutsemau wrote:
> > 
> > Assisted-by: Claude:claude-opus-4-7
> > Assisted-by: GitHub Copilot:gpt-5.4
> 
> These supposes to be on the same line, no?
> 
> Documentation/process/coding-assistants.rst:  Assisted-by: AGENT_NAME:MODEL_VERSION [TOOL1] [TOOL2]

I see... I actually used two different agents, so looks like they should
be on separate lines instead?

One example that I found:
91e901c65b4d ("um: drivers: call kernel_strrchr() explicitly in
cow_user.c")

  [ ... ]
  Assisted-by: Claude:claude-opus-4-6
  Assisted-by: Codex:gpt-5-4

> 
> > Signed-off-by: Peter Fang <peter.fang@intel.com>
> 
> One nit below, otherwise:
> 
> Reviewed-by: Kiryl Shutsemau (Meta) <kas@kernel.org>

Thanks for the review Kiryl!

> 
> > +u32 tdx_get_max_quote_size(void)
> > +{
> > +	u64 val, ret;
> > +
> > +	ret = tdg_vm_rd(TDCS_QUOTE_MAX_SIZE, &val);
> > +
> > +	return ret ? 0 : (u32)val;
> 
> Cast is redundant.
> 

I'll fix that, thanks.

> > +}
> > +EXPORT_SYMBOL_GPL(tdx_get_max_quote_size);
> > +
> >  static void __noreturn tdx_panic(const char *msg)
> >  {
> >  	struct tdx_module_args args = {
> 
> -- 
>   Kiryl Shutsemau / Kirill A. Shutemov