Re: [PATCH v2 2/3] KVM: SVM: Do all per-VM AVIC initialization during vCPU precreation phase

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The function prototype `avic_vm_init(struct kvm *kvm)` remains in `arch/x86/kvm/svm/svm.h` despite its implementation being removed.
--

commit e515c341adc5a84997456546a40c3f72c03c42b6
Author: Sean Christopherson <seanjc@google.com>

    KVM: SVM: Do all per-VM AVIC initialization during vCPU precreation phase
    
    Move all per-VM AVIC initialization from VM creation to vCPU pre-creation,
    i.e. defer allocating the logical ID table and adding the VM to the GA Log
    list until vCPUs are created.  This will allow removing the VM from the GA
    Log list before vCPUs are destroyed without needing yet another kvm_x86_ops
    hook (.vm_pre_destroy() is very intentionally called if and only if VM
    creation fully succeeds).

> diff --git a/arch/x86/kvm/svm/avic.c b/arch/x86/kvm/svm/avic.c
> index 4a0a2dbd1687f..d71a2fed1a08b 100644
> --- a/arch/x86/kvm/svm/avic.c
> +++ b/arch/x86/kvm/svm/avic.c

[ ... ]

> @@ -308,47 +308,32 @@ static int avic_alloc_physical_id_table(struct kvm *kvm)

[ ... ]

> -int avic_vm_init(struct kvm *kvm)
> +static void avic_add_vm_to_ga_log_list(struct kvm *kvm)
>  {

[Severity: Low]
Does the function prototype for avic_vm_init() in arch/x86/kvm/svm/svm.h also
need to be removed? The declaration appears to still be present even though
the implementation is removed here.

> -	unsigned long flags;
> -	int err = -ENOMEM;
>  	struct kvm_svm *kvm_svm = to_kvm_svm(kvm);

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260630210156.457151-1-seanjc@google.com?part=2