From: Fuad Tabba <fuad.tabba@linux.dev>
To: kvm@vger.kernel.org
Cc: kvmarm@lists.linux.dev, Will Deacon <will@kernel.org>,
Alexandru Elisei <alexandru.elisei@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Andre Przywara <andre.przywara@arm.com>,
Oliver Upton <oliver.upton@linux.dev>,
Marc Zyngier <maz@kernel.org>, Fuad Tabba <tabba@google.com>
Subject: [PATCH kvmtool v2 2/4] Remove newline from end of die() aborts
Date: Wed, 8 Jul 2026 19:25:08 +0100 [thread overview]
Message-ID: <20260708182510.2181857-3-fuad.tabba@linux.dev> (raw)
In-Reply-To: <20260708182510.2181857-1-fuad.tabba@linux.dev>
die() already adds the newline at the end of the string.
Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>
Signed-off-by: Fuad Tabba <fuad.tabba@linux.dev>
---
util/util.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/util/util.c b/util/util.c
index 6f41e2c..05d49c4 100644
--- a/util/util.c
+++ b/util/util.c
@@ -128,14 +128,14 @@ void *mmap_hugetlbfs(struct kvm *kvm, const char *htlbfs_path, u64 size)
unsigned long blk_size;
if (statfs(htlbfs_path, &sfs) < 0)
- die("Can't stat %s\n", htlbfs_path);
+ die("Can't stat %s", htlbfs_path);
if ((unsigned int)sfs.f_type != HUGETLBFS_MAGIC)
- die("%s is not hugetlbfs!\n", htlbfs_path);
+ die("%s is not hugetlbfs!", htlbfs_path);
blk_size = (unsigned long)sfs.f_bsize;
if (sfs.f_bsize == 0 || blk_size > size) {
- die("Can't use hugetlbfs pagesize %ld for mem size %lld\n",
+ die("Can't use hugetlbfs pagesize %ld for mem size %lld",
blk_size, (unsigned long long)size);
}
@@ -144,10 +144,10 @@ void *mmap_hugetlbfs(struct kvm *kvm, const char *htlbfs_path, u64 size)
snprintf(mpath, PATH_MAX, "%s/kvmtoolXXXXXX", htlbfs_path);
fd = mkstemp(mpath);
if (fd < 0)
- die("Can't open %s for hugetlbfs map\n", mpath);
+ die("Can't open %s for hugetlbfs map", mpath);
unlink(mpath);
if (ftruncate(fd, size) < 0)
- die("Can't ftruncate for mem mapping size %lld\n",
+ die("Can't ftruncate for mem mapping size %lld",
(unsigned long long)size);
addr = mmap(NULL, size, PROT_RW, MAP_PRIVATE, fd, 0);
close(fd);
--
2.39.5
next prev parent reply other threads:[~2026-07-08 18:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-08 18:25 [PATCH kvmtool v2 0/4] Add guest_memfd support for arm64 Fuad Tabba
2026-07-08 18:25 ` [PATCH kvmtool v2 1/4] Initialize the return value in kvm__for_each_mem_bank() Fuad Tabba
2026-07-08 18:25 ` Fuad Tabba [this message]
2026-07-08 18:25 ` [PATCH kvmtool v2 3/4] Add support for registering guest_memfd-backed memory regions Fuad Tabba
2026-07-09 15:07 ` Alexandru Elisei
2026-07-09 15:32 ` Fuad Tabba
2026-07-08 18:25 ` [PATCH kvmtool v2 4/4] arm64: Add --guest-memfd option to back guest RAM with guest_memfd Fuad Tabba
2026-07-09 15:08 ` Alexandru Elisei
2026-07-09 15:33 ` Fuad Tabba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260708182510.2181857-3-fuad.tabba@linux.dev \
--to=fuad.tabba@linux.dev \
--cc=alexandru.elisei@arm.com \
--cc=andre.przywara@arm.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.linux.dev \
--cc=maz@kernel.org \
--cc=oliver.upton@linux.dev \
--cc=suzuki.poulose@arm.com \
--cc=tabba@google.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox