[PATCH] KVM: x86: Use KVM_X86_OP() for the .pi_update_irte() hook

[PATCH] KVM: x86: Use KVM_X86_OP() for the .pi_update_irte() hook

[Kai Huang]

Change to using KVM_X86_OP() instead of KVM_X86_OP_OPTIONAL() for the
.pi_update_irte() hook in kvm-x86-ops.h since now both VMX and SVM have
implemented it.

For the Fixes tag:

This hook was introduced for VMX posted-interrupt support.  SVM later
added its implementation, but at this point KVM_X86_OP* had not been
introduced yet.

Initially KVM introduced KVM_X86_OP_NULL (and KVM_X86_OP) and used it
for this hook.  But this was correct, because the use of KVM_X86_OP_NULL
was "to mark calls that do not follow the [svm|vmx]_func_name naming
convention" and the VMX one was named pi_update_irte(), i.e., did not
follow the convention.  See commit 9af5471bdbb2 ("KVM: x86: introduce
definitions to support static calls for kvm_x86_ops").

KVM later removed KVM_X86_OP_NULL (due to "the naming convention is not
in use anymore"), and added KVM_X86_OP_OPTIONAL for the hooks that can
be NULL pointer.  It used KVM_X86_OP_OPTIONAL for this hook, but should
use KVM_X86_OP instead.  See commit e4fc23bad813 ("KVM: x86: remove
KVM_X86_OP_NULL and mark optional kvm_x86_ops").

Note this hook was named .update_pi_irte() when it was introduced, but
got renamed to .pi_update_irte() at some point between the above two
commits.

Fixes: e4fc23bad813 ("KVM: x86: remove KVM_X86_OP_NULL and mark optional kvm_x86_ops")
Signed-off-by: Kai Huang <kai.huang@intel.com>
---

Hi Sean,

I am not entirely sure whether this needs a Fixes tag, but I added it plus
some history just in case.

---
 arch/x86/include/asm/kvm-x86-ops.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/include/asm/kvm-x86-ops.h b/arch/x86/include/asm/kvm-x86-ops.h
index 736129db272a..0acfe15643e1 100644
--- a/arch/x86/include/asm/kvm-x86-ops.h
+++ b/arch/x86/include/asm/kvm-x86-ops.h
@@ -110,7 +110,7 @@ KVM_X86_OP(handle_exit_irqoff)
 KVM_X86_OP_OPTIONAL(update_cpu_dirty_logging)
 KVM_X86_OP_OPTIONAL(vcpu_blocking)
 KVM_X86_OP_OPTIONAL(vcpu_unblocking)
-KVM_X86_OP_OPTIONAL(pi_update_irte)
+KVM_X86_OP(pi_update_irte)
 KVM_X86_OP_OPTIONAL(pi_start_bypass)
 KVM_X86_OP_OPTIONAL(apicv_pre_state_restore)
 KVM_X86_OP_OPTIONAL(apicv_post_state_restore)

base-commit: 6bc96b971766fbbbbdd9fb2642cedacaf02da957
-- 
2.55.0

Re: [PATCH] KVM: x86: Use KVM_X86_OP() for the .pi_update_irte() hook

[Sean Christopherson]

On Wed, 15 Jul 2026 21:05:05 +1200, Kai Huang wrote:
> Change to using KVM_X86_OP() instead of KVM_X86_OP_OPTIONAL() for the
> .pi_update_irte() hook in kvm-x86-ops.h since now both VMX and SVM have
> implemented it.
> 
> For the Fixes tag:
> 
> This hook was introduced for VMX posted-interrupt support.  SVM later
> added its implementation, but at this point KVM_X86_OP* had not been
> introduced yet.
> 
> [...]

Applied to kvm-x86 misc, thanks!

[1/1] KVM: x86: Use KVM_X86_OP() for the .pi_update_irte() hook
      https://github.com/kvm-x86/linux/commit/9498f4d6edd3

--
https://github.com/kvm-x86/linux/tree/next