From: sashiko-bot@kernel.org
To: "Tarun Sahu" <tarunsahu@google.com>
Cc: kvmarm@lists.linux.dev, "Marc Zyngier" <maz@kernel.org>,
"Oliver Upton" <oupton@kernel.org>,
kvm@vger.kernel.org
Subject: Re: [PATCH v4 09/11] docs: liveupdate: Add documentation for VM and guest_memfd preservation
Date: Tue, 28 Jul 2026 12:21:28 +0000 [thread overview]
Message-ID: <20260728122128.D0E831F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260728121138.1103610-10-tarunsahu@google.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Mismatched kernel-doc section titles cause Sphinx build warnings and missing documentation.
--
--- Patch [9]: [PATCH v4 09/11] docs: liveupdate: Add documentation for VM and guest_memfd preservation ---
commit a930d2f58a9edc06bdcfd10fb383e97d7fe3996c
Author: Tarun Sahu <tarunsahu@google.com>
docs: liveupdate: Add documentation for VM and guest_memfd preservation
Add Documentation/liveupdate/vmm.rst detailing VMM requirements, scope,
ordering constraints, and kernel-doc inclusions for KVM VM and
guest_memfd preservation via Live Update Orchestrator (LUO).
> diff --git a/Documentation/liveupdate/vmm.rst b/Documentation/liveupdate/vmm.rst
> new file mode 100644
> index 0000000000000..b8e8fb2b63c21
> --- /dev/null
> +++ b/Documentation/liveupdate/vmm.rst
> @@ -0,0 +1,107 @@
> +.. SPDX-License-Identifier: GPL-2.0-or-later
> +
> +=============================
> +VM & Guest_Memfd Preservation
> +=============================
> +
> +.. kernel-doc:: virt/kvm/kvm_luo.c
> + :doc: KVM VM Preservation via LUO
> +
> +.. kernel-doc:: virt/kvm/guest_memfd_luo.c
> + :doc: Guest_Memfd Preservation via LUO
[Severity: Low]
Does this section title exactly match the DOC: title in
virt/kvm/guest_memfd_luo.c?
If the source file uses "Guestmemfd Preservation via LUO" without the
underscore, this directive will fail to find the documentation and generate a
Sphinx build warning.
[ ... ]
> +VM & Guest_Memfd Preservation ABI
> +=================================
> +
> +.. kernel-doc:: include/linux/kho/abi/kvm.h
> + :doc: DOC: guest_memfd Live Update ABI
[Severity: Low]
Does this section title match the actual title in include/linux/kho/abi/kvm.h?
If the source file uses "KVM and guest_memfd Live Update ABI", this mismatch
will cause empty sections in the generated documentation.
Also, should the literal "DOC: " prefix be omitted here? The directive
typically only expects the text that follows the prefix.
> +
> +.. kernel-doc:: include/linux/kho/abi/kvm.h
> + :internal:
> +
> +See Also
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260728121138.1103610-1-tarunsahu@google.com?part=9
next prev parent reply other threads:[~2026-07-28 12:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-28 12:11 [PATCH v4 00/11] liveupdate: kvm: Guest_memfd preservation Tarun Sahu
2026-07-28 12:11 ` [PATCH v4 01/11] liveupdate: Add LIVEUPDATE_GUEST_MEMFD config option Tarun Sahu
2026-07-28 12:22 ` sashiko-bot
2026-07-28 12:11 ` [PATCH v4 02/11] KVM: Introduce kvm_create_vm_file() helper Tarun Sahu
2026-07-28 12:11 ` [PATCH v4 03/11] KVM: Export kvm_uevent_notify_vm_create() Tarun Sahu
2026-07-28 12:26 ` sashiko-bot
2026-07-28 12:11 ` [PATCH v4 04/11] KVM: Track weak reference to vm_file in struct kvm Tarun Sahu
2026-07-28 12:11 ` [PATCH v4 05/11] KVM: LUO: Support VM preservation across live updates Tarun Sahu
2026-07-28 12:27 ` sashiko-bot
2026-07-28 12:11 ` [PATCH v4 06/11] KVM: guest_memfd: Move internal definitions to internal header Tarun Sahu
2026-07-28 12:11 ` [PATCH v4 07/11] KVM: guest_memfd: Add support for freezing mappings Tarun Sahu
2026-07-28 12:20 ` sashiko-bot
2026-07-28 12:11 ` [PATCH v4 08/11] KVM: guest_memfd: Add support for preservation via LUO Tarun Sahu
2026-07-28 12:23 ` sashiko-bot
2026-07-28 12:11 ` [PATCH v4 09/11] docs: liveupdate: Add documentation for VM and guest_memfd preservation Tarun Sahu
2026-07-28 12:21 ` sashiko-bot [this message]
2026-07-28 12:11 ` [PATCH v4 10/11] KVM: selftests: Split ____vm_create() and add vm_create_from_fd() Tarun Sahu
2026-07-28 12:11 ` [PATCH v4 11/11] KVM: selftests: Add guest_memfd_preservation_test Tarun Sahu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260728122128.D0E831F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.linux.dev \
--cc=maz@kernel.org \
--cc=oupton@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=tarunsahu@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox